Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qEPEa-0000lg-7a for pgsql-hackers@arkaria.postgresql.org; Wed, 28 Jun 2023 07:05:00 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1qEPEZ-0005dC-0c for pgsql-hackers@arkaria.postgresql.org; Wed, 28 Jun 2023 07:04:59 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qEPEY-0005d3-Mu for pgsql-hackers@lists.postgresql.org; Wed, 28 Jun 2023 07:04:58 +0000 Received: from wout5-smtp.messagingengine.com ([64.147.123.21]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qEPEW-000vLl-48 for pgsql-hackers@lists.postgresql.org; Wed, 28 Jun 2023 07:04:58 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 1396D320090E; Wed, 28 Jun 2023 03:04:53 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Wed, 28 Jun 2023 03:04:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1687935892; x=1688022292; bh=HR g4d9WmbxUNoWCgR1K2O/LVizaJCyumbGGr13VenQs=; b=wki1ODF2Hgj0aGHJ1/ yJyDoE9Fl8NJQ2izuCzb/Vu6BY9aEY5y6HpK8YqlMxyZ46YEgo0c2HOOsqgDYQwd 7Ycb7tF4dKHFjjR/71EogZ9usBvM3+tBgmZt29X+OIjtKsI3Jf9Ei4k+QIdBvtbi 86qamNaJiR3tJkF8w3MqA+0Eoojb6jBDCtM2oSghMS/ZyZiEqCsQW8XIaU3VD29p RUECgTE86XuLN7I49EtLrrdMd7yny6Bx3eBkMAgxC4y99ep+RHGHXxn+Nl7Grxb3 8LHTJDoWK1FBT8/LLgt3AsRFi+06GlII30fNmOY//GODcHWmVOIiCkBpJGyKxCDa ig+w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1687935892; x=1688022292; bh=HRg4d9WmbxUNo WCgR1K2O/LVizaJCyumbGGr13VenQs=; b=Uv7LL0Qfz/mA1kYBpY+Cjo5QyT8ux MW29AcJwBizVM5e9+z7T9sXpRQTZNg3XhIgJPp3xhoofDv4LUPZXOz8P9gfq6FHX F2ll49W+GashxbNbNI+no/0Q3Cor356G1dgoq/iTSwaMk2zdQTil+JKIhqs67TAI RRkGKRWMDykz8/wtVFJFHlt+VykfUlzcSv6P1XQ9RK3wdMsdYWBhpdDUFw/PqprK IhytWwzwnTK24ai1UddhR0Me2LfubGM67r4rCPGPg3+Tzf0rYgJsXAHMK6FmroNu 7r1oUxeWY7Mlp8vC34czo9k/crHOFLcyLv5YFXzlJmZfIdq3MhSkMekrQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrtddugdduudehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne gfrhhlucfvnfffucdljedtmdenucfjughrpeffhffvvefukfhfgggtuggjsehgtderredt tddvnecuhfhrohhmpefoihgthhgrvghlucfrrghquhhivghruceomhhitghhrggvlhesph grqhhuihgvrhdrgiihiieqnecuggftrfgrthhtvghrnhepteelieefudffhffhtdetleeg geegfffhkeeuveetiefgudduvedutefggeeivdejnecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomhepmhhitghhrggvlhesphgrqhhuihgvrhdrgiih ii X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 28 Jun 2023 03:04:50 -0400 (EDT) Date: Wed, 28 Jun 2023 16:04:48 +0900 From: Michael Paquier To: Japin Li Cc: Richard Guo , PostgreSQL Hackers Subject: Re: Another incorrect comment for pg_stat_statements Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="YeqWInaxGXG/UC+r" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --YeqWInaxGXG/UC+r Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Jun 28, 2023 at 12:15:47PM +0800, Japin Li wrote: > - /* Remove the key if it exists, starting with the top-level entry */ > + /* Remove the key if it exists, starting with the non-top-level entry */ > key.toplevel = false; > entry = (pgssEntry *) hash_search(pgss_hash, &key, HASH_REMOVE, NULL); > if (entry) /* found */ Nice catch. That's indeed wrong. Will fix. -- Michael --YeqWInaxGXG/UC+r Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmSb25AACgkQnvQgOdby QH0Iow//bZuyiqif3rNXMhLWDxe1oOrpdNTTLZUNR6xd1tCZZIfqYicvRpzZYogG NsgtOFuXssx3DpaPcD6R/SSV9cSrbNX/1Jo2/LOYiplbVB21Jbs6an8LDeZutfQN 0Fc3qsLM66X1p6EC5UmhAZXCNW3HNLce8k/5hpYn8cTjfmhjeT1KgQsCkA76A9uq XkPxN3LuZVxRmc714VPs1WjRRtOrCCZpm6JF8R7+cEBi2hYH0kFy/4kUoixudf3q ExSiBoeSKbiDRNYq49RwEcGp+u5nJJKT6nAj7gVODKo2AUfmxbpBcWdCGIUC//rq WMORMr0PNJ6OeFEGO+nLtD37bGjuuJ2laMx3vRm0qFt/GS+JEFUmCrFhj06gHZQA PPTgCwQml/vj0dwCIX/RSJQ+H9AwGB1JhzUrOLIK623HeskXXGpmBxAFFXVObt9B ytMlPEXDLJbRajuFeNRHinwi1xyh/ogeQFq2KWvE2EK7mQtRDq7pK1Ien+pCW2M8 G8H6UYwpa69lU0Yg8zv+tetzdb2JlaLOdvKu9L0/tmarJNr16ztxZrvGifXT9E8B n3BrZn0X6TAtiqBUTY4JIfT2B/pQqejzQSYpjJ7RYd9TZ148L0s7ln1sIhXazvCh n2YaJl3Jj9XghaQ2d4mY/czvs0stk/FF0k6GaKZWRH5Eu9jzk9A= =mxLe -----END PGP SIGNATURE----- --YeqWInaxGXG/UC+r--