Feedback-ID: i0fe9450f:Fastmail
Date: Mon, 3 Jul 2023 16:11:51 +0900
From: Michael Paquier <michael@paquier.xyz>
To: "Drouvot, Bertrand" <bertranddrouvot.pg@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Autogenerate some wait events code and documentation
Message-ID: <ZKJ0tzXSH1LyqI9V@paquier.xyz>
References: <124bdcea-bdc8-e3d2-2357-0c6a857bc557@gmail.com>
 <ZFW6FTMIH00502RU@paquier.xyz>
 <ZFW9UYQFyftKpoaH@paquier.xyz>
 <106e8d0a-0820-687a-7da5-3143e1f5b05b@gmail.com>
 <ZGM1U5D5EuBUbasi@paquier.xyz>
 <976f4eb1-cbc0-9616-ec26-ebb4a252315c@gmail.com>
 <ZGSM8oOpXsXrXy/v@paquier.xyz>
 <69588eaf-02d7-95a8-0da4-3e120de16a59@gmail.com>
 <ZGWrTn//v+WAqMpN@paquier.xyz>
 <ZKJxZrnFTxoCx8a5@paquier.xyz>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="5vpzkdQp6akc1Evq"
Content-Disposition: inline
In-Reply-To: <ZKJxZrnFTxoCx8a5@paquier.xyz>
Archived-At: <https://www.postgresql.org/message-id/ZKJ0tzXSH1LyqI9V%40paquier.xyz>
Precedence: bulk


--5vpzkdQp6akc1Evq
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Jul 03, 2023 at 03:57:42PM +0900, Michael Paquier wrote:
> I think that we should add some options to the perl script to be more
> selective with the files generated.  How about having two options
> called --docs and --code to select one or the other, then limit what
> gets generated in each path?  I guess that it would be cleaner if we
> error in the case where both options are defined, and just use some
> gotos to redirect to each foreach loop to limit extra indentations in
> the script.  This would avoid the need to remove the C and H files
> from the docs, additionally, which is what the Makefile in doc/ does.
>=20
> I have fixed all the issues I've found in v11 attached, except for the
> last one (I have added the OUTDIR trick for reference, but that's
> incorrect and incomplete).  Could you look at this part?

Ah.  It took me a few extra minutes, but I think that we should set
"capture" to "false", no?  It looks like meson is getting confused,
expecting something in stdout but the new script generates a few
files, and does not output anything.  That's different from the other
doc-related perl scripts.
--
Michael

--5vpzkdQp6akc1Evq
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmSidLcACgkQnvQgOdby
QH2qhw/9HuoQtZaLWip7x+Ot1ZY1acxIBr22lr6x2auHsP2uw6RXnN58M5gUwxR9
aO3wMiZL0ZNjXjIZEBACv26sZcTpgZb7LrAMjcGxLrpu43bfjnBwnb/xyIHwpACg
DLSVl18Ll3JWTU0d1+/oGxItqqXO4HCh6AnpQPOL0TUUBxUWc4kCzTAj7I57kKwj
tGnFW6w/u3/0NJWjVU9iTIeKd9gV05dka0mRvX4j33AAnOgNUBSTJBi+y7wtPR2c
pHBNVd1mnfXNiwG43GbGSrLgq1OBIKj7lSTlhfZ24W6JMAzZdyXl2hWmUyk+YDfl
V5zvrcZ85AlSfiN+vc++SX98AKNVSu3pG8t4Y+Wd3TGccyhb+g+mwJpmRsZWJ7oC
X24YupeHcenfiUwKJ9dlgkTin7lNPRvORt0k/zAukSNAT45J/X/v13/taOw262Ae
zO/t/4CHlNBdWI6MmmVfxA1NsrIvwXrf2Xwg7HwZHNqD4u0L9i3lnHGIeU77mDqM
6i0fWO7b/PXp8zIpd1ot7o3V/cUQQOBDnNRvXl8Frdeo3Zi5/fHOrUVZHQGWm8Fo
dj//G+weBZrTjv+Fo9NL5unT/DycVkD0mt65WAAhYbuzLotDVV5GRvAfY2ZjVGPc
EWFyf0CIJjSHEgytwYS0HHIpARjLI1Ooqo7y4INBHpT0Z9uAT7Q=
=yYSi
-----END PGP SIGNATURE-----

--5vpzkdQp6akc1Evq--