Feedback-ID: i0fe9450f:Fastmail
Date: Thu, 6 Jul 2023 09:36:12 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Andres Freund <andres@anarazel.de>
Cc: "Drouvot, Bertrand" <bertranddrouvot.pg@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Autogenerate some wait events code and documentation
Message-ID: <ZKYMfGRK1PIlGiBB@paquier.xyz>
References: <ZGM1U5D5EuBUbasi@paquier.xyz>
 <976f4eb1-cbc0-9616-ec26-ebb4a252315c@gmail.com>
 <ZGSM8oOpXsXrXy/v@paquier.xyz>
 <69588eaf-02d7-95a8-0da4-3e120de16a59@gmail.com>
 <ZGWrTn//v+WAqMpN@paquier.xyz>
 <ZKJxZrnFTxoCx8a5@paquier.xyz>
 <ZKJ0tzXSH1LyqI9V@paquier.xyz>
 <0b3cdac7-f078-61a6-76e0-99db7aae78ce@gmail.com>
 <ZKTN//NfDeP1egLW@paquier.xyz>
 <20230705215939.ulnfbr4zavb2x7ri@awork3.anarazel.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="JoAN1J6bJ13uIK6x"
Content-Disposition: inline
In-Reply-To: <20230705215939.ulnfbr4zavb2x7ri@awork3.anarazel.de>
Archived-At: <https://www.postgresql.org/message-id/ZKYMfGRK1PIlGiBB%40paquier.xyz>
Precedence: bulk


--JoAN1J6bJ13uIK6x
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Jul 05, 2023 at 02:59:39PM -0700, Andres Freund wrote:
> Rebasing a patch over this I was a bit confused because I got a bunch of
> ""unable to parse wait_event_names.txt" errors. Took me a while to figure=
 out
> that that was just because I didn't include a trailing . in the descripti=
on.
> Perhaps that could be turned into a more meaningful error?
>=20
> 	die "unable to parse wait_event_names.txt"
> 	  unless $line =3D~ /^(\w+)\t+(\w+)\t+("\w+")\t+("\w.*\.")$/;

Agreed that we could at least add the $line in the error message
generated, at least, to help with debugging.

> I also do wonder if we should invest in generating the lwlock names as
> well. Except for a few abbreviations, the second column is always the
> camel-cased version of what follows WAIT_EVENT_. Feels pretty tedious to =
write
> that out.

And you mean getting rid of lwlocknames.txt?  The impact on dtrace or
other similar tools is uncertain to me because we have free number on
this list, and stuff like GetLWLockIdentifier() rely on the input ID
=66rom lwlocknames.txt.

> Perhaps we should just change the case of the upper-cased names (DSM, SSL,
> WAL, ...) to follow the other names?

So you mean renaming the existing events like WalSenderWaitForWAL to
WalSenderWaitForWal?  The impact on existing monitoring queries is not
zero because any changes would be silent, and that's the part that
worried me the most even if it can remove one column in the txt file.
--
Michael

--JoAN1J6bJ13uIK6x
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmSmDHwACgkQnvQgOdby
QH09dxAAgmRglJpuxFtJy36iJiG93DiCuBpQmi9/UAtOuQsBjhwFXm2qpYmRUa1C
nUnYCpBqdLBVvmagoFC6m28YP0WgAwgHom7X1hWGVptK+JvmRnzkNwWWrEpJvQol
fJfSd7Ant/w8EZwX1COHyNEC4vue5u1/uhZN6PcPg0+hAMCKsH3ewKQZdVI07+xe
rggOoipHFFlYV4KpHRCAZNI7f18YULJTTSo6/B/rV7fpEKHCKvYRVwxVPr7K+bpd
WL55BvSERl0gRHezw9MXfX5W+ppgLqflOi8SPD1GNLEbd78YJ/9at2fSIGu9gjdu
OFIurHezo015taE7x8xzH0ASYQMFSo3tkdSSt+OjyFGUb27DB8k7SQP+qwNyMoje
6dK5VS7rXdLPJvee+bZULRdQFKcBgOf3pz2iV7ldC0WcsvlY4MZFueLoRLAP3T7x
Mmyg8YQSkaRl9U865B1+gOOrmkkHDmmNIhYqX/jRuzEvrpFVtBe+7X7EHKL3W8/x
HX97RWgVk3E1sqY9l/jWd2q4oMZwQFWeXzWZCWENIQ2rDks0R3nywXrcfkDi+Chw
oYsobILn0NbItGnaZ6PtTUN3HtVYl5amOyUUcrLG7lBaZD+lAFscr+NLMmubP64m
+/Y3+KaMxtLMuYkpGuc79Nfg0Z6qEYu9z+6HCwW6g5j6P70RyCY=
=C+SF
-----END PGP SIGNATURE-----

--JoAN1J6bJ13uIK6x--