Feedback-ID: i0fe9450f:Fastmail
Date: Thu, 6 Jul 2023 11:14:51 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Masahiko Sawada <sawada.mshk@gmail.com>
Cc: "Imseih (AWS), Sami" <simseih@amazon.com>,
	Andres Freund <andres@anarazel.de>,
	"Drouvot, Bertrand" <bertranddrouvot.pg@gmail.com>,
	vignesh C <vignesh21@gmail.com>,
	Nathan Bossart <nathandbossart@gmail.com>,
	Robert Haas <robertmhaas@gmail.com>,
	"Bossart, Nathan" <bossartn@amazon.com>,
	Peter Geoghegan <pg@bowt.ie>, Justin Pryzby <pryzby@telsasoft.com>,
	"pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Subject: Re: Add index scan progress to pg_stat_progress_vacuum
Message-ID: <ZKYjm4ofOYuRHpXh@paquier.xyz>
References: <07FA1AA3-BE99-46F7-8A51-75D86DD5C12C@amazon.com>
 <ZC48RPeRz2DcNqqA@paquier.xyz>
 <3B4246CB-EECB-4A83-8FA1-8A4BB6970F2A@amazon.com>
 <ZC/tPKRXOKvROv+6@paquier.xyz>
 <B8A291C2-75E0-4EF8-BD95-CF57B4FF6572@amazon.com>
 <ZDM851ih3dolzF/B@paquier.xyz>
 <1F9143C4-D709-4F37-8FF0-D9D5E0C38BB7@amazon.com>
 <ZDY3sd1Ssv1fgFaX@paquier.xyz>
 <E088D96B-7E4B-456E-AFA9-6B4B76620B3E@amazon.com>
 <CAD21AoBUcCXQVFvnbFUKnCHgLijehbGBxz_MLeRet4+4-2D-UA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="pK1X90BNHBurQ7mW"
Content-Disposition: inline
In-Reply-To: 
 <CAD21AoBUcCXQVFvnbFUKnCHgLijehbGBxz_MLeRet4+4-2D-UA@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/ZKYjm4ofOYuRHpXh%40paquier.xyz>
Precedence: bulk


--pK1X90BNHBurQ7mW
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Jul 06, 2023 at 11:07:14AM +0900, Masahiko Sawada wrote:
> Thank you for updating the patch. It looks good to me too. I've
> updated the commit message.

Thanks.  I was planning to review this patch today and/or tomorrow now
that my stack of things to do is getting slightly lower (registered my
name as committer as well a few weeks ago to not format). =20

One thing I was planning to do is to move the new message processing
API for the incrementational updates in its own commit for clarity, as
that's a separate concept than the actual feature, useful on its own.

Anyway, would you prefer taking care of it?
--
Michael

--pK1X90BNHBurQ7mW
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmSmI5sACgkQnvQgOdby
QH3aIQ//asD7Q2jjYpwFSKwP86nhMbl8TRg5ecE1a8f0+x2FfzBjkrq4aggQ0ONw
9xMwDSkagU9yrDlrMbTE+arI9B/HEBWQI/T/AQL35QuJJZEyctdeyIYwX7rHCDh4
YXWnKD5DYCSFuRora7TuyAT2v0P7ss1u2Tkm36v61PuUmaAW6sQ3iVc+lMB4X7Pn
UxUKMVJP8QK7D0Pc/iOZsmb9BaAM7DoM+mAwl+t4HfYkbdBrKr2QyM1I6AcgEEnr
1InRZ5A0GaydE9U6IpSKZH0FiFA3xlEq0BhvidQPFGsV6KGZNgDoeVzyCHUP7mPt
k+ozhBlNx+rzGU8pWdIbbihJ8qcMQy/R2gW6B0PYh/19GmehcD6yZnfbOQIUK5dp
SvQwCV/n8tZs+e/26fLva2E4LoUqtszvsks0oLiRtKaQUKiOIn7QEbClgsXaQQI+
XpPXsFJwk+68cOVbknlajh0JLf/pWYH/OK8Jl3zHXBwRLp08IOhZp+JxHa5GTq+1
3RFZRSLO3fD86vsOiVIq36y9HsrNiI+f/gDUODraXucF3+0BzNDS2L4/QhkJrSb0
RVG41d2CIw07FhdLyEg8gJO8gHy81CbEa8W2TALsW+1BN6m6p0rslzc6OCWj988v
qDxdewiryO/9CIoo/u78zrNYiDH1FevM8HIQhXYW30VNQJ4Ru4Y=
=JbHc
-----END PGP SIGNATURE-----

--pK1X90BNHBurQ7mW--