Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qHdPh-00020K-4O for pgsql-hackers@arkaria.postgresql.org; Fri, 07 Jul 2023 04:49:49 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1qHdPe-0004Qx-E1 for pgsql-hackers@arkaria.postgresql.org; Fri, 07 Jul 2023 04:49:46 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qHdPc-0004Qf-W7 for pgsql-hackers@lists.postgresql.org; Fri, 07 Jul 2023 04:49:46 +0000 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qHdPU-002fN5-Bp for pgsql-hackers@lists.postgresql.org; Fri, 07 Jul 2023 04:49:44 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 8E8E13200938; Fri, 7 Jul 2023 00:49:31 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Fri, 07 Jul 2023 00:49:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1688705371; x=1688791771; bh=1J b46CI/P8fIiR9o+JLIIklFWctmxfZd98H0kjKEtoA=; b=uz16aQVdiWj0klq4SQ 1T+M6GO3SzzZkkKCOzFjQqOEKzvj+HPkCLhUenJ04ukifsxca96zXDs86IBg1Jni Mpz5uh+jFLXae4jzUQ6qaao5qEEqpYrz54PK+eLLIbocXNeffe5MPlRn4BJ0ZinF qPgvERpcE8ogLQMknZe5CGJ3KuuiObTw/ni9ZtBj14RcvYYuUmQDW5YcQ+krJziq 2SJF9O82bGZpMmxDQ9AhAAfjCyoAhef1hbf7r6mKa5Zi5qCTCaSPrNNBfs+yFeHj QZIw6sGtEMgQAw7z7Q446l1uE9G+FcwGhfDuMLK23gNuGz5vZ+sYeE284c1oKza+ s2pQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1688705371; x=1688791771; bh=1Jb46CI/P8fIi R9o+JLIIklFWctmxfZd98H0kjKEtoA=; b=iAUG70/3JuwfbHbp3rNHEnr0J3Aee Xs7YO8UToFb6HBh+DZwHY0edAJgKX4Ftyw0rRoHOU2LOIu/pHylbZKm99MVYn9m6 3NXeiyx3m0HhPeBjUnMZBvGPlr2dWoulbosDyJLIvIupznPIccdjeH5BXkqc5g+n sU3EjiqmHUg0lO/aBItPNrCXV/+ZxycRAZSnUNoKj11HgpXpZu3cU4yZ15WwGz3N aZj69097CRsUcL126CKsFR7AqfO5OW73IVfHLrph2yNBYOqsb1Z3pdR8mv7/Ph9T 1sMA5Kmb1okn4SCChpXcCEiTFaTa8pq9WOq8usuBiDAOWFyONcPNVWHeQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrvddtgdekhecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfg hrlhcuvffnffculdejtddmnecujfgurhepfffhvfevuffkfhggtggujgesghdtreertddt vdenucfhrhhomhepofhitghhrggvlhcurfgrqhhuihgvrhcuoehmihgthhgrvghlsehprg hquhhivghrrdighiiiqeenucggtffrrghtthgvrhhnpeetleeifedufffhhfdtteelgeeg geffhfekueevteeigfduudevudetgfegiedvjeenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpehmihgthhgrvghlsehprghquhhivghrrdighiii X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 7 Jul 2023 00:49:28 -0400 (EDT) Date: Fri, 7 Jul 2023 13:49:24 +0900 From: Michael Paquier To: Andres Freund Cc: "Drouvot, Bertrand" , PostgreSQL Hackers Subject: Re: Autogenerate some wait events code and documentation Message-ID: References: <69588eaf-02d7-95a8-0da4-3e120de16a59@gmail.com> <0b3cdac7-f078-61a6-76e0-99db7aae78ce@gmail.com> <20230705215939.ulnfbr4zavb2x7ri@awork3.anarazel.de> <20230707011943.qxbj3vj2iwsfgqvq@awork3.anarazel.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="RBLQHYb2/caMEqna" Content-Disposition: inline In-Reply-To: <20230707011943.qxbj3vj2iwsfgqvq@awork3.anarazel.de> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --RBLQHYb2/caMEqna Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jul 06, 2023 at 06:19:43PM -0700, Andres Freund wrote: > On 2023-07-06 09:36:12 +0900, Michael Paquier wrote: >> So you mean renaming the existing events like WalSenderWaitForWAL to >> WalSenderWaitForWal? >=20 > Yes. > >> The impact on existing monitoring queries is not zero because any changes >> would be silent, and that's the part that worried me the most even if it= can >> remove one column in the txt file. >=20 > Then let's just use - or so to indicate the inferred name, with a "string" > overriding it? Hmm. If we go down this road I would make the choice of simplicity and remove entirely a column, then, generating the snakecase from the camelcase or vice-versa (say like a $string =3D~ s/([a-z]+)/$1_/g;), even if it means having slightly incompatible strings showing to the users. And I'd rather minimize the number of exceptions we need to handle in this automation (aka no exception rules for some keywords like "SSL" or "WAL", etc.). -- Michael --RBLQHYb2/caMEqna Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmSnmVQACgkQnvQgOdby QH12Fw/+IdfLMc7OSV9+FwQK72CQWYzeCsr0wNUVRMywLjzS29dtnOu5lFZqQoO1 dn//SrtvmoroFMiR4w6o6vFvSB9/f8HJQkMqmXVTt4LMcu24gntkggHXtS4iE7H+ FpPleQK35/ISZ9c7YTNYNBaVfO6g77GBFcwx8fyB3Pp1YwFvXUOESHAsILXjOZYn cHe0XUgDOj4z0EvX4ZZh7F89DZbTNzuXPDOrjk7tLhrOFV3XX5qr6R7Ub+xmjIoc EnqWSL3dpFTuXonGc3Crph/f15x/IuQTqzz62ccMi1nHAuZjNl4OYzETba30+T/8 nHAJBYayk5hDsDkrUGGwsAeawLJCggAtX47IQtIvqZ3qn4GYw92h2WAg6sFzNdvT xdzP/d6RsgF5ZslBXuVIMqh89SYFjfqJnN1pCZK5fYE9XqhzTjmnrlnqoq5oTEml qXPQvp0HSe48QU4HVOvKmrx1O6doaUvMG6sZmjErQbUMi6w+HE+rWE8F8gn+BjnZ 9vWLsSV/DrSOJGZs4VUeIuw9vlhswitfVMic2etM4YgkEVg42JepkaD7oPBh75sd TayCGbsSRRWS6B5N2aKKTMT3W/McD5GNXksCmUj8Svnkevuuv7Nj8llYjryL7PSs swlm7KMkjsoScCDjQOPLypPlnuYI1vwcjCM6lkUcMnV7YxYw6ZQ= =BA1t -----END PGP SIGNATURE----- --RBLQHYb2/caMEqna--