Feedback-ID: i0fe9450f:Fastmail
Date: Sun, 9 Jul 2023 16:36:11 +0900
From: Michael Paquier <michael@paquier.xyz>
To: "Drouvot, Bertrand" <bertranddrouvot.pg@gmail.com>
Cc: Andres Freund <andres@anarazel.de>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Autogenerate some wait events code and documentation
Message-ID: <ZKpjawSAHIjYV2+Q@paquier.xyz>
References: <ZKJxZrnFTxoCx8a5@paquier.xyz>
 <ZKJ0tzXSH1LyqI9V@paquier.xyz>
 <0b3cdac7-f078-61a6-76e0-99db7aae78ce@gmail.com>
 <ZKTN//NfDeP1egLW@paquier.xyz>
 <20230705215939.ulnfbr4zavb2x7ri@awork3.anarazel.de>
 <ZKYMfGRK1PIlGiBB@paquier.xyz>
 <20230707011943.qxbj3vj2iwsfgqvq@awork3.anarazel.de>
 <ZKeZVPEBkBxYs1FY@paquier.xyz>
 <ZKo4b1bDI5+FoTex@paquier.xyz>
 <1f74adab-5ed8-450a-853a-f0b4bfe0e751@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="iJyskfGtxjEuphZA"
Content-Disposition: inline
In-Reply-To: <1f74adab-5ed8-450a-853a-f0b4bfe0e751@gmail.com>
Archived-At: <https://www.postgresql.org/message-id/ZKpjawSAHIjYV2%2BQ%40paquier.xyz>
Precedence: bulk


--iJyskfGtxjEuphZA
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, Jul 09, 2023 at 09:15:34AM +0200, Drouvot, Bertrand wrote:
> I also noticed that you now provide the culprit line in case of parsing
> failure (thanks for that).

Yes, that's mentioned in the commit message I quickly wrote in 0002.

>  #
> -#   "C symbol in enums" "format in the system views" "description in the=
 docs"
> +#   "format in the system views" "description in the docs"
>=20
> Should we add a note here about the impact of the "format in the system v=
iews" on
> the auto generated enum? (aka how it is generated based on its format)?

There is one, but now that I look at it WAIT_EVENT repeated twice does
not look great, so this could use "FooBarName" or equivalent:
+   # Generate the element name for the enums based on the
+   # description.  Camelcase strings like "WaitEventName"
+   # are converted to WAIT_EVENT_WAIT_EVENT_NAME.
--
Michael

--iJyskfGtxjEuphZA
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmSqY2sACgkQnvQgOdby
QH24zg//WMd03ucgRlWwFNxrv2dPSUFRSpLkYm2BFEs0oQbria3/iDazKW8+143y
DY3oPhXJq4GbGF5LN51W2C+acd286j62E8qingTFhU7Rrr7zsRip5qfwc8CNelRM
UnPMxFHCEpL9C9rYQEEHwzsJEu4J7zTNbWDRY0gSJiG9408LpmpRX8hCiHx2Zua+
m6NbAC2lbUQC/pOSz7Bm4qZGrmN7zi1C1G6rKiES921BSs5fW1SyLdDrezA9imv8
yMKmXJwQUAr1guyAp5ijXTX44ZaIk/HTTp/uOFTdUOcf0hrrR60Dj7EbvR3hi2Co
DNTkIBdu4WuJDPI692w0tKmgCj/i1suV1tveK/zleN8e/KLgWg8sIYPVV2uhea0h
S2kGiMJGBWrG59LcTaxqwEusLR7t7YgQvAgyIAICXO/+R77TbKbICZN2h//YCnr2
MwHqv9N1SplrI3kOybEmBbdDbyXRmViFHJvD6V2dx+4nRgxvnO/aaHysAfDlGlpD
9poF2IYVO2v96/Hh7iZNyWhER5sa3X1tiVTFQF6DflGvPxuU1o9nZH5p2x11xTiV
hIqY15yn16HKVZs+HdD9iAWiDDxpireJKnnOzLPAR29GsCkZCOH+EM7V16MSLDWt
fHSxcBTev8lOmzUFKtyiEUMzaPPDZnao7UnvRdR7l+IbqmDDBIA=
=2Iwo
-----END PGP SIGNATURE-----

--iJyskfGtxjEuphZA--