Feedback-ID: i0fe9450f:Fastmail
Date: Tue, 11 Jul 2023 07:52:45 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Andres Freund <andres@anarazel.de>,
	"Drouvot, Bertrand" <bertranddrouvot.pg@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Autogenerate some wait events code and documentation
Message-ID: <ZKyLvXMS/D3hMFj4@paquier.xyz>
References: <ZKo4b1bDI5+FoTex@paquier.xyz>
 <20230710071136.jiedze443q7o5vsp@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="lrUKE2kZsOqoP5bo"
Content-Disposition: inline
In-Reply-To: <20230710071136.jiedze443q7o5vsp@alvherre.pgsql>
Archived-At: <https://www.postgresql.org/message-id/ZKyLvXMS/D3hMFj4%40paquier.xyz>
Precedence: bulk


--lrUKE2kZsOqoP5bo
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Jul 10, 2023 at 09:11:36AM +0200, Alvaro Herrera wrote:
> I don't like this bit, because it means the .txt file is now ungreppable
> as source of the enum name.  Things become mysterious and people have to
> track down the event name by reading the the Perl generating script.
> It's annoying.  I'd rather have the extra column, even if it means a
> little duplicity.

Hmm.  I can see your point that we'd lose the direct relationship
between the enum and string when running a single `git grep` from the
tree, still attempting to do that does not actually lead to much
information gained?  Personally, I usually grep for code when looking
for consistent information across various paths in the tree.  Wait
events are very different: each enum is used in a single place in the
tree making their grep search the equivalent of looking at
wait_event_names.txt anyway?

The quotes in the second columns can be removed even with your
argument in place.  That improves a bit the format.
--
Michael

--lrUKE2kZsOqoP5bo
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmSsi70ACgkQnvQgOdby
QH351hAAj7AlIcF+axa6KlDD+3wgUbOiwyjPmpnVWgIy81OuQF8F6NlKUKiWIVMZ
MHvfVNGkI6LouMacWe9ln6CMv7iceIiApHcMnMlXfqoEAbt94rkLo+f3fHKzKSkh
jFwQcXQDqZG+KKDqJEqVZuY3qU+pVAdL770Co1cUsq0XNOQk3Ozvdr4siNHm+wqJ
MjTYLWt4ebL5VpxStyqcxR9KS4ft08E8l5+BnF+NEMDxuGUvc2sdHpi7BDXkBZXL
DtDw11SmraCzYmLzuL8tsgKXQgkcx7y1aqZVBqVPb+RoPVYeedg7+qeJ5ngfQDyF
T8fNbw/E4tx8C/qRazpof4myuJaMz8QzZq7Wcy5Z+iigNggI6JL7p25AnYqHoHAh
aNV/+0zmmGptXyhf0wW46LAz+U6VqzsL/OCyDIxLz1ARGcP9PO7IQLyviC/Kn0Ki
AwtNfZGoglsRW/R+P8vN2x/+BnsiWPj8AtAhyG5VVOp87YTrJ9v6pJyuXf9oAwJz
tZlgYXgJsl09VvKgfEccfuCyLCE+0mVtduAEqy501pCAjet5beYuOFaJXBb6Z7a3
WAubUh09qTCTd8njn3TFgYX6oAf8QPIqOuH90IPvFbEqq2SuC3XdMUVGSn+7offs
KbWa5zVP7K8buF+pCasGGhcrZbhY+/Jr1CJOyWa/GlZV4+m08Bs=
=vkK4
-----END PGP SIGNATURE-----

--lrUKE2kZsOqoP5bo--