Feedback-ID: i0fe9450f:Fastmail
Date: Mon, 17 Jul 2023 10:16:02 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Andres Freund <andres@anarazel.de>
Cc: "Drouvot, Bertrand" <bertranddrouvot.pg@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
	Alvaro Herrera <alvherre@alvh.no-ip.org>
Subject: Re: Autogenerate some wait events code and documentation
Message-ID: <ZLSWUh3dpZPlvrso@paquier.xyz>
References: <ZKeZVPEBkBxYs1FY@paquier.xyz>
 <ZKo4b1bDI5+FoTex@paquier.xyz>
 <1f74adab-5ed8-450a-853a-f0b4bfe0e751@gmail.com>
 <ZKpjawSAHIjYV2+Q@paquier.xyz>
 <9682e829-4120-a3d5-4834-d909ad4b49d8@gmail.com>
 <ZKuVKPB+rwYH5cuw@paquier.xyz>
 <e318fee2-ab72-9d71-6b8b-c99753f4cecc@gmail.com>
 <ZK9S3jFEV1X797Ll@paquier.xyz>
 <ZLDT0kOh0tuh6IpV@paquier.xyz>
 <20230716192120.t53prl2uruingo6z@awork3.anarazel.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="HEdmgoeMywJSx4r2"
Content-Disposition: inline
In-Reply-To: <20230716192120.t53prl2uruingo6z@awork3.anarazel.de>
Archived-At: <https://www.postgresql.org/message-id/ZLSWUh3dpZPlvrso%40paquier.xyz>
Precedence: bulk


--HEdmgoeMywJSx4r2
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, Jul 16, 2023 at 12:21:20PM -0700, Andres Freund wrote:
> I think the search issue is valid, so I do think going the other way is
> preferrable. I.e. use just the enum value in the .txt and generate the ca=
mel
> case name from that. That allows you to search the define used in code and
> find a hit in the file.
>=20
> I personally would still leave off the WAIT_EVENT prefix in the .txt, I t=
hink
> most of us can remember to chop that off.

So you mean to switch a line that now looks like that:
WAIT_EVENT_FOO_BAR   FooBar        "Waiting on Foo Bar."
To that:
FOO_BAR   "Waiting on Foo Bar."
Or even that:
WAIT_EVENT_FOO_BAR   "Waiting on Foo Bar."

Sure, it is an improvement for any wait events that use WAIT_EVENT_
when searching them, but this adds more magic into the LWLock and Lock
areas if the same conversion is applied there.  Or am I right to
assume that you'd mean to *not* do any of that for these two classes?
These can be treated as exceptions in the script when generating the
wait event names from the enum elements, of course.

> I don't think we need to be particularly consistent with wait events acro=
ss
> major versions. They're necessarily tied to how the code works, and we've
> yanked that around plenty.

IMO, it depends on the code path involved.  For example, I know of
some code that relies on SyncRep to track backends waiting on a sync
reply, and that's one sensible to keep compatible.  I'd be sad if
something like that breaks suddenly after a major release.
--
Michael

--HEdmgoeMywJSx4r2
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmS0llIACgkQnvQgOdby
QH1yXA//TyQs1iC3n4BtgKcUdT+M3Bb8Yha4jB8m2ZMz1S8H7BZYBRPys3Z5I3uH
2IT1xv4t64/ygZa2Owt2sNEpxVDW/KLzVGuRrVYic4Lw/jLJCLW4lexLrMkiWKCh
siqP2zWRbQHX+hGjplpeiMpUovl+vMA3boQQARPGlbnE1L89O8/o7UfwT6UDEY21
Pn3dkMWpZOVo6WRlJchcyX1HDYgH/WP+JlEhHevM4ZYBIpzJTaH8sWWXPeNRhi4f
U+tQMUSn8sfe8yc5A5WQE6ng3R/3wvFmQD13vo3zvLXdOrL14WsKZJJ0UxNgRYBU
/QTDhk6iFpsIvEaYXMkSr5dNAkikqovhD27vl8e3jYZ4DimxREwYqaxFidm4jk1O
EGnuYkOZaJJ1hyW7XS77snlAw1CSavEoWuCJtBdqiVWC7TdM2O24KE5cknniueZt
4Tm5INqv1exxG1dqf7skZl2p6FAg9FKXAByv5zKiScHXd1sCWQMTp8WvD0Z16wel
FcH0oqpRVMUMSG9gyUH1YFP9XKKISE/PJK+/NWDAxcNi4XE5XpRQKtni3UR/UBq8
q5K5FNUnOjSV4cT11DFSmwtpOpN9jj0p55zxuGMcKQANDrwEysLhVkf+ZXLwn5RW
t7A+pemrMeWYx+hxL8cXPSxCcG0Dvjy0c1T3RESoZz8+/VawPBk=
=np26
-----END PGP SIGNATURE-----

--HEdmgoeMywJSx4r2--