Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qLxGL-0014D4-PP for pgsql-hackers@arkaria.postgresql.org; Wed, 19 Jul 2023 02:50:01 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1qLxGK-00GLNC-9p for pgsql-hackers@arkaria.postgresql.org; Wed, 19 Jul 2023 02:50:00 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qLxGK-00GLN4-0X for pgsql-hackers@lists.postgresql.org; Wed, 19 Jul 2023 02:50:00 +0000 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qLxGH-000Ecn-EK for pgsql-hackers@postgresql.org; Wed, 19 Jul 2023 02:49:58 +0000 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id C11A53200708; Tue, 18 Jul 2023 22:49:55 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 18 Jul 2023 22:49:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; t=1689734995; x=1689821395; bh=jE +qEa8xyU4JzoOpLeRhImJS2tbeFMXD+f2RChGbJ/8=; b=L81/IQGBZs0YHrtyA4 BIb5XTIU2obVzPhbx3KSzfXr1Lov00uXPn+ux6vniKJC/+I9xYmezrGhoGCec0n6 nQ5LsDj6v6YeyZq7BMDDfyvedv5wTZ79RvH6zbujdandemyQTtzHf17/Ncej/AND Ffb3ryblwxW4Uz8avrkflT/PrNPY65wF+q68HaBdMC5g+FeYDtwJ9jYDpW9o8T9e KpnUE5m52XmEGgSuDPrvQE+udYfDbNE1T9HLYDCXDyo21pAuMM4MSHKHU5lslD9P gwPPSfhCVnw1xPEGEC3BUEZwIClhGMjT3gVxcU4nKkTpgYMSl7jTW/c+oAUzMJYi XbCg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1689734995; x=1689821395; bh=jE+qEa8xyU4Jz oOpLeRhImJS2tbeFMXD+f2RChGbJ/8=; b=f+dqIaSe5gMZSFK8SUYpGLfW3svTg f/RUP9jo9RYrGPyUTClFB+fxIfqiHV/It7ECiWD/NWaRmw65CVd7NOhPCGzvQYFG CBEK2ZGuERaMh4W2wBrSHItHl1jDCk0P2WIOpQyPDYRx1wKeOksc/6UmFtbDinli GQ5956qMi8mPdNgRjuaO/uYVyx43ZSVeo4pAyZMYKriNW4WEz3O5clYfHrSV9Zdz Pt0iN8agQHbWUWBFcuMPIaxRUXaRrm4tooFTDJG+GrHORev9lH7D+JSfc8wImjlB f98xG42ljlh3hOXMZYIH99RUQVo2/e2NdEZWXSZhon7TUg/l89hWtWyiA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrgeehgdeifecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfg hrlhcuvffnffculdejtddmnecujfgurhepfffhvfevuffkfhggtggujgesghdtreertddt vdenucfhrhhomhepofhitghhrggvlhcurfgrqhhuihgvrhcuoehmihgthhgrvghlsehprg hquhhivghrrdighiiiqeenucggtffrrghtthgvrhhnpeetleeifedufffhhfdtteelgeeg geffhfekueevteeigfduudevudetgfegiedvjeenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpehmihgthhgrvghlsehprghquhhivghrrdighiii X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 18 Jul 2023 22:49:52 -0400 (EDT) Date: Wed, 19 Jul 2023 11:49:49 +0900 From: Michael Paquier To: Justin Pryzby Cc: Soumyadeep Chakraborty , Zhihong Yu , pgsql-hackers@postgresql.org, Ashwin Agrawal , vanjared@vmware.com Subject: Re: ALTER TABLE SET ACCESS METHOD on partitioned tables Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="DpB3mR9BYKwbcjJA" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --DpB3mR9BYKwbcjJA Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sun, Jul 16, 2023 at 09:37:28PM -0500, Justin Pryzby wrote: > I understand that it's possible for it to be conditional, but I don't > undertand why it's desirable/important ? Because it's cheaper on repeated commands, like no CCI necessary. > It's not conditional in the tablespace code that this follows, nor > others like ATExecSetStatistics(), ATExecForceNoForceRowSecurity(), > ATExecSetCompression(), etc, some of which are recently-added. If it's > important to do here, isn't it also important to do everywhere else ? Good point here. I am OK to discard this point. -- Michael --DpB3mR9BYKwbcjJA Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmS3T00ACgkQnvQgOdby QH14kQ/+O2AyqRjxaMCehrYlK6i7jxzAtYDvgkUltVEKuqst92Xcrcq2DEqyGiKw epZ7T5hIA+lTyDJRtF8ztwqwKpOxu94dVMoPCDlRk1OtNhc94AjvyLDIxXY2NU1u KSsfjzyHZbDvvMOmtUXenmEgjDFDOjeFSnorkZ7U6Wm5yzzkU6YYyXMiO8/Bqxgp ZYXcTnnjsTNvMpG6v7z7wjxfVnkkcPS5/l3UScrmLgQlHVULk2XtmWYh/MCr+Kbs uMaP1W8PccxOak6iYX4MFxwuwJesM6br85TzMKts+jjVvrg4YyspPqjPAYvafEGG 0xXMR7f1ImHZVKDyk/gola6My/XCAAxAghcIIpj4Ui/J31E1FwmRHZPxADp3XiYD +HAZSFNNRa2pevL8E/OSX/2Q9X1JnfUWQ0DAjl10boH+ltUutshO9XkRJG5HNfNi wX6Ov793M/QNwnYhZ/SD82IIOF/C6RaGybp30qKBWhMzKnXCbg6PAmgghAbp0OEC 4wN5LTorKz0kg1vuowOtdBfhg4UtzP/ybmt0yqEs73JSpPLTMN1HFrUWGqEGMOP5 SpAv0LWSbNO5K9ihFxoLrvnZbJFzioKdHHu9HYyrnuu9XKmyF7RRdeewFUBFBQ8o 5LqG7scAxxmEfg5HmzHLFAUpOrxg1MfmgrcgQ+B5vQ5pAC3ekTw= =sI1i -----END PGP SIGNATURE----- --DpB3mR9BYKwbcjJA--