Feedback-ID: i0fe9450f:Fastmail
Date: Thu, 20 Jul 2023 13:39:36 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Cc: Masahiro Ikeda <ikedamsh@oss.nttdata.com>,
	pgsql-hackers@lists.postgresql.org
Subject: Re: Support worker_spi to execute the function dynamically.
Message-ID: <ZLi6iHwMAqhfYVdn@paquier.xyz>
References: <d30d3ea7d21cb7c9e1e3cc47e301f1b6@oss.nttdata.com>
 <ZLiwP5vrT/SENzim@paquier.xyz>
 <CALj2ACVOCiXirZFRL-gi7mV2zgdH4e3-vyJQx2fxdzycJTv3qg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="/eouRrRR8iPRZciK"
Content-Disposition: inline
In-Reply-To: <CALj2ACVOCiXirZFRL-gi7mV2zgdH4e3-vyJQx2fxdzycJTv3qg@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/ZLi6iHwMAqhfYVdn%40paquier.xyz>
Precedence: bulk


--/eouRrRR8iPRZciK
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Jul 20, 2023 at 09:43:37AM +0530, Bharath Rupireddy wrote:
> +1. However, a comment above helps one to understand why some GUCs are
> defined before if (!process_shared_preload_libraries_in_progress). As
> this is an example extension, it will help understand the reasoning
> better. I know we will it in the commit message, but a direct comment
> helps:
>=20
>     /*
>      * Note that this GUC is defined irrespective of worker_spi shared li=
brary
>      * presence in shared_preload_libraries. It's possible to create the
>      * worker_spi extension and use functions without it being specified =
in
>      * shared_preload_libraries. If we return from here without defining =
this
>      * GUC, the dynamic workers launched by worker_spi_launch() will keep
>      * crashing and restarting.
>      */

WFM to be more talkative here and document things, but I don't think
that's it.  How about a simple "These GUCs are defined even if this
library is not loaded with shared_preload_libraries, for
worker_spi_launch()."
--
Michael

--/eouRrRR8iPRZciK
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmS4uogACgkQnvQgOdby
QH3ofw/+LG7N2oJUrIeJPMgbw1lD1i5OAZxourZPTpLki52ry5OpyqKvf3DsE4rh
t+cZF0lk7v3m8KIGkPNoATcJscqhSCjZVk8aSXN2LH/OnqWaZnoKd+eyIH+jSVAr
O3p1pUmN1lDjX/0MsjTWJCMc6Yy3T/I5SbUnuxFuTi89SDGIGrQxGdTju9habkgb
2rRY7wH5GrAuaWgqmGbAYbZQVPpzcu5ex1XUjY//3zGTMAFCXVR2S4OkWeSz3XBi
HmU2FNp3wOuFEGm6sbrmT79JQTd+x3cu8FS5wyVqH7U3adx/AXgLNEpUwSCFIeoP
TFfmZl+UCrXjqaT4YkeyHxwmdvVGJn/uxLB8hO6NsTDofUyIVH6K3lOYd6zyDaER
PL1eiJACVH7280RCwA02zgM61iLlE0xFaunitAv+/MVWWipNgUSUJ0FemFBePE1J
jYX5lUOzOy+XgwlfKZW56iDBwdnywUKp5hRBz1Ch4WkvsCocr/D3VTWg+RQuDiAT
aTbeowMEbYIAO65Blk9zxuBrHrkCmxxIKXq04+2630SYOAV8VMzqlrFT9rN1qU08
SFt1E0tVkevjNxgUCDn3aqXMGiTtzfYxHQwW4wjFGeh7ZLfRTAKR3yEWRfHDOO2u
l7wrBAxJ3n2CGetGky7B8/x32+5U8FhkHkyCDilGT9XAprN1XSk=
=Pa6h
-----END PGP SIGNATURE-----

--/eouRrRR8iPRZciK--