Feedback-ID: i0fe9450f:Fastmail
Date: Fri, 21 Jul 2023 12:08:47 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Cc: Masahiro Ikeda <ikedamsh@oss.nttdata.com>,
	pgsql-hackers@lists.postgresql.org
Subject: Re: Support worker_spi to execute the function dynamically.
Message-ID: <ZLn2v/eMkqmny4J6@paquier.xyz>
References: <d30d3ea7d21cb7c9e1e3cc47e301f1b6@oss.nttdata.com>
 <ZLiwP5vrT/SENzim@paquier.xyz>
 <CALj2ACVOCiXirZFRL-gi7mV2zgdH4e3-vyJQx2fxdzycJTv3qg@mail.gmail.com>
 <ZLi6iHwMAqhfYVdn@paquier.xyz>
 <CALj2ACWj7qF-YYVi05okBFJnPugkwsM8PSrEwfHs-tQqKO80Uw@mail.gmail.com>
 <46e53055d8d1c92704d3cd2709c722e7@oss.nttdata.com>
 <CALj2ACV0fr-9OTZqtWu-9XrtUbBZCYb0UK859gfvJ0oqm3YvUA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="AtMo6NJvKIMfWBbP"
Content-Disposition: inline
In-Reply-To: <CALj2ACV0fr-9OTZqtWu-9XrtUbBZCYb0UK859gfvJ0oqm3YvUA@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/ZLn2v/eMkqmny4J6%40paquier.xyz>
Precedence: bulk


--AtMo6NJvKIMfWBbP
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Jul 20, 2023 at 03:44:12PM +0530, Bharath Rupireddy wrote:
> I don't think that change is correct. The worker_spi essentially shows
> how to start bg workers with RegisterBackgroundWorker and dynamic bg
> workers with RegisterDynamicBackgroundWorker. If
> shared_preload_libraries =3D worker_spi not specified in there, you will
> miss to start RegisterBackgroundWorkers. Is giving an initidb time
> database name to worker_spi.database work there? If the database for
> bg workers doesn't exist, changing bgw_restart_time from
> BGW_NEVER_RESTART to say 1 will help to see bg workers coming up
> eventually.

Yeah, it does not move the needle by much.  I think that we are
looking at switching this module to use a TAP test in the long term,
instead, where it would be possible to test the scenarios we want to
look at *with* and *without* shared_preload_libraries especially with
the custom wait events for extensions in mind if we add our tests in
this module.

It does not change the fact that Ikeda-san is right about the launch
of dynamic workers with this module being broken, so I have applied v1
with the comment I have suggested.  This will ease a bit the
implementation of any follow-up test scenarios, while avoiding an
incorrect pattern in this template module.=20
--
Michael

--AtMo6NJvKIMfWBbP
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmS59r8ACgkQnvQgOdby
QH1WzA//Xq1r1O8BMYeNCoMwJQU2WZUoLwXRXqp+DNxkh5uOWNGtoLbwOXVcQrhQ
aK5YCPUpsyi6sFiHvqX79od2aHDi9oUIA+TxnSt+fPK+HS51cDD6PVnu2aVosOYz
fDb7XYksWpOzS5n50bSQ0oYFjgYAnM5/O/pT2giU3XbT1XUGJMqhp3ScShuzwNWa
UETprX7SkPja6JwCiaSrSer0A4EDrGWHHor0geqUwwwhYwbogWSOFiM2J+TSJ2vO
iJI8CG9hEdOTKtw418e03SLbp1+T3jxhaQZoPOCp0WJSV1Ha/VGp1GiC0IrNKTeV
SC8sBiT4Xt2yZsQIaTQaLAc9uk6SdD0VMT3VA6d1kpz2SSKVH3Hgs68WeVIPAaHt
Sfe/cu5sJQgWwsE0tYvVS0mBPrdZneBo420OMwlQa6GMOef8b0rKTsCuu00YDTdp
a5n9GjOf1HQqoQR51xzHpOMAj3P2lBpJJ3QUEmzGkJDf3+8D3kUjNEnCmxguw3HJ
ch7ny6qz7Ppm4t4ECakJHDx8MyAR9VS3NLhAqRxEoL+Gg6siIU0blLL2bUmH2rDO
RddT4IxxRBYb3wZPPGN9uAqe5I5KXO6EEJbaprvoftRNCx3smP7Ebe+qbUVtOZGX
Ro6UejPxYvDunMmJRJNW2okKWbbzTxhCppLjifLR+ot+JJgSef8=
=fwQq
-----END PGP SIGNATURE-----

--AtMo6NJvKIMfWBbP--