Feedback-ID: i0fe9450f:Fastmail
Date: Fri, 21 Jul 2023 15:24:19 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Cc: Masahiro Ikeda <ikedamsh@oss.nttdata.com>,
	pgsql-hackers@lists.postgresql.org
Subject: Re: Support worker_spi to execute the function dynamically.
Message-ID: <ZLokkzw6pmvDU9bM@paquier.xyz>
References: <d30d3ea7d21cb7c9e1e3cc47e301f1b6@oss.nttdata.com>
 <ZLiwP5vrT/SENzim@paquier.xyz>
 <CALj2ACVOCiXirZFRL-gi7mV2zgdH4e3-vyJQx2fxdzycJTv3qg@mail.gmail.com>
 <ZLi6iHwMAqhfYVdn@paquier.xyz>
 <CALj2ACWj7qF-YYVi05okBFJnPugkwsM8PSrEwfHs-tQqKO80Uw@mail.gmail.com>
 <46e53055d8d1c92704d3cd2709c722e7@oss.nttdata.com>
 <CALj2ACV0fr-9OTZqtWu-9XrtUbBZCYb0UK859gfvJ0oqm3YvUA@mail.gmail.com>
 <ZLn2v/eMkqmny4J6@paquier.xyz>
 <CALj2ACVUxgcQaGh3HpBJ6Xg9FRqj7UNDomd5E1y=tRKs2wcntA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="2IGLA/+jEQEUele+"
Content-Disposition: inline
In-Reply-To: <CALj2ACVUxgcQaGh3HpBJ6Xg9FRqj7UNDomd5E1y=tRKs2wcntA@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/ZLokkzw6pmvDU9bM%40paquier.xyz>
Precedence: bulk


--2IGLA/+jEQEUele+
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Jul 21, 2023 at 11:24:08AM +0530, Bharath Rupireddy wrote:
> Okay. Here's a quick patch for adding TAP tests to the worker_spi
> module. We can change it to taste.

What do you think if we removed completely the sql/ test, moving it to
TAP so as we have only one cluster set up when running a make check?
worker_spi.sql only does two waits (one for the initialization and one
to check that the tuple has been processed), so these could be
replaced by some poll_query_until()?

As we have a dynamic.conf, installcheck is not supported so we don't
use anything with this switch.  Besides, updating
shared_preload_libraries and restarting the node in TAP is cheaper
than a second initdb.

-       snprintf(worker.bgw_name, BGW_MAXLEN, "worker_spi worker %d", i);
-       snprintf(worker.bgw_type, BGW_MAXLEN, "worker_spi");
+       snprintf(worker.bgw_name, BGW_MAXLEN, "worker_spi static worker %d", i);
+       snprintf(worker.bgw_type, BGW_MAXLEN, "worker_spi static worker");
[..]
-   snprintf(worker.bgw_name, BGW_MAXLEN, "worker_spi worker %d", i);
-   snprintf(worker.bgw_type, BGW_MAXLEN, "worker_spi");
+   snprintf(worker.bgw_name, BGW_MAXLEN, "worker_spi dynamic worker %d", i);
+   snprintf(worker.bgw_type, BGW_MAXLEN, "worker_spi dynamic worker");

Good idea to split that.
--
Michael

--2IGLA/+jEQEUele+
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmS6JJMACgkQnvQgOdby
QH0M5w//a6PT1Xgv76JtNS/p13E6M0baZT8rioao+zXImfvgeYfl9laCfN3UotVt
Wxm20bVq/REs1VuEn2X0tOBut9j2gxxKIvhaZGC9IxJZ81SDqJ1Ze0CN3jxscOEs
7YVP0jNaYlJsP32b/hzLHBvTSO0lzhT/zg6Wvv12pjg00kYwMgszJ+38x/lLScsd
mEozsm5lfCWiKtukxdk9esNTOBNawGvqovnWY9KCE7tLYV/s7iubTHNRHPKVdJZZ
QobjEMX+8WQCQ0drFYeNlEys5oZ32OdGZAEH6IgVLsHRF3gKnfsYoA1Gdm4L9z6v
ujNDdVFFVW/0OlgzN9zNAJnNCJJlhRqfz1Odvv05VaTnbz3WapB+709yAWtgADKV
xbCkhlSSQ/fWBC0yozvPVvE7x1YaqOVZaacgnMZEIL6nR4AXuV/86WdYBTvSJmI8
McZs+wabQFGfllM42NESnzkeS++BCsHsMFToXsuxs7PSuvAYaTzSIWDWLcGdpww5
rAK0Ub9JXbn+Glr2u1VbuhltQX9yEJ/EMwtAs7KIHxEdK71YJZE/iqzPT1oDgSA9
pYTMbWehufAnJjsBrZrwKFN912N599J+43ECWuOJMfZ8fLy2J5QspQR31qi223QN
qHgiJkSHxNNep9CfoOcN8DQ8WBX7uz/+e4SCzoClHcsphmvhu/o=
=2gzD
-----END PGP SIGNATURE-----

--2IGLA/+jEQEUele+--