public inbox for [email protected]
help / color / mirror / Atom feedFrom: Michael Paquier <[email protected]>
To: jian he <[email protected]>
Cc: Garrett Thornburg <[email protected]>
Cc: [email protected]
Subject: Re: PATCH: Add REINDEX tag to event triggers
Date: Wed, 26 Jul 2023 08:50:56 +0900
Message-ID: <[email protected]> (raw)
In-Reply-To: <CACJufxErztdYqGnN5WPfG6PX+WL3hX9DaP2_9Z4sp--cEmWy-w@mail.gmail.com>
References: <CAEEqfk5bm32G7sbhzHbES9WejD8O8DCEOaLkxoBP7HNWxjPpvg@mail.gmail.com>
<CACJufxErztdYqGnN5WPfG6PX+WL3hX9DaP2_9Z4sp--cEmWy-w@mail.gmail.com>
On Tue, Jul 25, 2023 at 04:34:47PM +0800, jian he wrote:
> so T_ReindexStmt should only be in ProcessUtilitySlow, if you want
> to create an event trigger on reindex?
>
> regression tests work fine. I even play with partitions.
It would be an idea to have some regression tests for partitions,
actually, so as some patterns around ReindexMultipleInternal() are
checked. We could have a REINDEX DATABASE in a TAP test with an event
trigger, as well, but I don't feel strongly about the need to do that
much extra work in 090_reindexdb.pl or 091_reindexdb_all.pl if
partitions cover the multi-table case.
--
Michael
Attachments:
[application/pgp-signature] signature.asc (833B, ../[email protected]/2-signature.asc)
download
view thread (2+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected]
Subject: Re: PATCH: Add REINDEX tag to event triggers
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox