Feedback-ID: i0fe9450f:Fastmail
Date: Sat, 29 Jul 2023 11:38:00 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Andres Freund <andres@anarazel.de>
Cc: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>,
	Masahiro Ikeda <ikedamsh@oss.nttdata.com>,
	pgsql-hackers@lists.postgresql.org
Subject: Re: Support worker_spi to execute the function dynamically.
Message-ID: <ZMR7iIXxNOP80c9O@paquier.xyz>
References: <CALj2ACV0fr-9OTZqtWu-9XrtUbBZCYb0UK859gfvJ0oqm3YvUA@mail.gmail.com>
 <ZLn2v/eMkqmny4J6@paquier.xyz>
 <CALj2ACVUxgcQaGh3HpBJ6Xg9FRqj7UNDomd5E1y=tRKs2wcntA@mail.gmail.com>
 <ZLokkzw6pmvDU9bM@paquier.xyz>
 <CALj2ACVWW2NU78kJ=xEbz8qcZgWeae+cVp8TYbvGTdpYjVKjjA@mail.gmail.com>
 <e4e5bee9d241a00a0edd9ee4e90fe69c@oss.nttdata.com>
 <CALj2ACWR9ncAiDF73unqdJF1dmsA2R0efGXX2624X+YVxcAVWg@mail.gmail.com>
 <20230728022332.egqzobhskmlf6ntr@awork3.anarazel.de>
 <ZMNH6Q+W3lhMGXoh@paquier.xyz>
 <20230728203415.m6sw4ulpfnixtfin@awork3.anarazel.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="VlOfv3oagQo9dL7X"
Content-Disposition: inline
In-Reply-To: <20230728203415.m6sw4ulpfnixtfin@awork3.anarazel.de>
Archived-At: <https://www.postgresql.org/message-id/ZMR7iIXxNOP80c9O%40paquier.xyz>
Precedence: bulk


--VlOfv3oagQo9dL7X
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Jul 28, 2023 at 01:34:15PM -0700, Andres Freund wrote:
> On 2023-07-28 13:45:29 +0900, Michael Paquier wrote:
>> Having each bgworker on its own schema would be enough to prevent
>> conflicts, but I'd like to add a second thing: a check on
>> pg_stat_activity.wait_event after starting the workers.  I have added
>> something like that in the patch I have posted today for the custom
>> wait events at [1] and it enforces the startup sequences of the
>> workers in a stricter way.
>=20
> Is that very meaningful? ISTM the interesting thing to check for would be=
 that
> the state is idle?

That's interesting for the sake of the other patch to check that the
custom events are reported.  Anyway, I am a bit short in time, so I
have applied the simplest fix where the dynamic workers just use a
different base ID to get out of your way.
--
Michael

--VlOfv3oagQo9dL7X
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmTEe4gACgkQnvQgOdby
QH3nExAAoq9cUOOI/rqTuaLQdDMB+S5bzvneI4C/Sb3nDjkY/C7OwxCOg7rWoQgQ
woEywPuwRmOFAP7CdnHhEsLpjosPqzliuMPoq/L7U6jkpYWhmJ44cnzW8Zctk7bY
QqZJOrzLQ+oT6dJgwvqTWXan29qAoF9oEf0RWQrz6+n9fPnBtlpQHyjQQlXNdxbn
EinfeoWcY951J1+OZZxH7OM5nLe8vc2EouwO5JkIEvWpQIS1IhbrTE4RjOWawKNy
kwlGvajsIAxI3O5aicLosglZYu1iNNSiINk3kxlREiwb5+pvDb9F0UBcD2X3XGXt
9M3bDMv28YgK9BsdFFNobD2x4Dss1epzzICMTdKHiOTD/tig2T5p5YcplBfMnvWM
rJafuw3Dl+3pSOccBVoubch29ZFb1gLWvahNMl1jRmCP4FDJhD0NxFDxAXKs8SZ+
nXAWFdQOEpqtTkqFIuUUpsEaX291fTFL1maeUad94K9tf+/zv34xt8y1ZAEHb5Rq
eOregTOI/nlR4shObkbLgtiKNpDfQG+Gjiz+wwJUWUg7no7hq/LH/MJFBUCgNZfJ
s0Bfx0wt6qV7e2Yq7ST1TIUnQhHeAxFY+swmEbu6cdWJuRzP50nQnSFnaiQHS63T
ma2A6IAi1aY3P3x2Xb8fWkN3DG10o7s2FmUYFABDXRkcC1JfcnI=
=uxsq
-----END PGP SIGNATURE-----

--VlOfv3oagQo9dL7X--