Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qQQ4b-00Dpml-Je for pgsql-hackers@arkaria.postgresql.org; Mon, 31 Jul 2023 10:24:21 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1qQQ4Z-00Db8S-VK for pgsql-hackers@arkaria.postgresql.org; Mon, 31 Jul 2023 10:24:19 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qQQ4Z-00Db8K-Lj for pgsql-hackers@lists.postgresql.org; Mon, 31 Jul 2023 10:24:19 +0000 Received: from out5-smtp.messagingengine.com ([66.111.4.29]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qQQ4X-001RNl-MN for pgsql-hackers@lists.postgresql.org; Mon, 31 Jul 2023 10:24:19 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id A87C85C0185; Mon, 31 Jul 2023 06:24:16 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Mon, 31 Jul 2023 06:24:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; t=1690799056; x=1690885456; bh=PR fhZsHh9vUCVxef5ge+p1HP2RkWaXnAWojC+zeQIUw=; b=4IxPt42jZ6YrN8tq5V pRaZeairX4c3+6ErleRHXs3NACfSqpesFPDGxq9iztAJKyGdvLsNuRSrslgpqFOB 8/bAZv73r3nDbzlMfjLYyPct2v0v3LxIn+pzPw2GjldEbvGnaozSlHTJOL3Byihf DCwnN0S7/THb+ANtP52CXTW/q0Y0p4PDmE6tJW0949Zho+q5RsegORbDy28zga31 tmvQU5Ekx3PJ6q3CdpG6QhG/90QuiaiOXbhrO9TMQ62kEuj9J6q+uej9WEr9XwbB zCRS4+EKwGcxg1xZH3JH04Pzy5xE3RDmmGz7LcA+6gKkkY45ViNXR1cWF+6aDW4E VxqA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1690799056; x=1690885456; bh=PRfhZsHh9vUCV xef5ge+p1HP2RkWaXnAWojC+zeQIUw=; b=FwXzVxguv5UJKuzlGDNeogd76J+0W IHZzNocdArfY2k6j1YHxFBcx7nSJQw8tuKMOsbNUizDSfEqz4CeOh7nfmR2sQCYt v8h6KaHVVP0hnr4Fr9tjOCR6v5Fbwt7tgGT6D+uu4h/+6W9+Cu+OEmjNiVFgHOG/ wZ2ChVX+yPEqXrJ4LDf/JdCCPQkFj0V2ePp9jYx+wBUh4nQA58f4bcff2S4Ujqqv keGD/YR80oamA6UFsPb2t8RfqRM7BVKT89FoTWRM1Fs3ToFA7E91FwCH+p5ldqM8 okVJNwtPFpE5eiaPG+WtxZSrqLM+H2/mBGV6HQwWki3SzXCVXGPPETtFg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrjeeggddthecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecufghrlhcuvffnffculdejtddmnecujfgurhepfffhvf evuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepofhitghhrggvlhcurfgrqhhu ihgvrhcuoehmihgthhgrvghlsehprghquhhivghrrdighiiiqeenucggtffrrghtthgvrh hnpeetleeifedufffhhfdtteelgeeggeffhfekueevteeigfduudevudetgfegiedvjeen ucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmihgthh grvghlsehprghquhhivghrrdighiii X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 31 Jul 2023 06:24:14 -0400 (EDT) Date: Mon, 31 Jul 2023 19:24:09 +0900 From: Michael Paquier To: Kyotaro Horiguchi Cc: ikedamsh@oss.nttdata.com, bharath.rupireddyforpostgres@gmail.com, tristan@neon.tech, andres@anarazel.de, pgsql-hackers@lists.postgresql.org Subject: Re: Support to define custom wait events for extensions Message-ID: References: <446d286f3272437df705ee69ad0d8793@oss.nttdata.com> <20230731.171021.2208978510550133838.horikyota.ntt@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="P7qCUsnlfcNa+GXU" Content-Disposition: inline In-Reply-To: <20230731.171021.2208978510550133838.horikyota.ntt@gmail.com> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --P7qCUsnlfcNa+GXU Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jul 31, 2023 at 05:10:21PM +0900, Kyotaro Horiguchi wrote: > +/* > + * Return the name of an wait event ID for extension. > + */ > +static const char * > +GetWaitEventExtensionIdentifier(uint16 eventId) >=20 > This looks inconsistent. Shouldn't it be GetWaitEventExtentionName()? This is an inspiration from GetLWLockIdentifier(), which is kind of OK by me. If there is a consensus in changing that, fine by me, of course. -- Michael --P7qCUsnlfcNa+GXU Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmTHi8kACgkQnvQgOdby QH2zpQ/9GwgXoZkek8Ql1XUaBa8Wj2UWoTiEozS9Ou0YPXfhTlCrmYbBRJDSom2B /7CIqpVd2yEIgFo3FylpAjWyAqhjRVSSK9xmRR81+7cjRegvsqU/llgAw1FLhFJ9 ACXP/fLfR083NqKAxvMztJqnya/GJ/AEkqf0L570mGrVMWOtgZYBz+EA2n5biD4m DcNUu/Kvac38Umw7B6KLIGPHFr/yBd4aGyg0r9lvm1RZgXU0ojWJUqB1kFVfk1lX +7sGH2y/KIkzboPhzvOtHl2CNfb7w1qovRvJCtKdmpFXqqo7tiRquQdymKYqEF7i yLPv2PbR90eihSS3T2UW41ZURYPYrfB6nBMnP1oAw9XCZeFMZFHg0jIecEjJynUx ifPMgsj1UtbefI/HvrHKx6WqGiAeG746pXyMHp0T4VdKmlORDRG1k162+kvLEp+1 IAnPpn3hyfnFL65bV4UhXz74ikQ4h861CZ4ld/2U4lQAuqtb1LZ6c36FXGaGlDWy lsnYKlCPZB3Klw4NRLLny9R21Uegqx5fFUDaghDrCwaLBBWuotiCNaaQmenfUvZW j1Vd6x+jAEtY4sD/pQlHRuURtg8a8wGPewZhfTLQRMvy1K1r1/1RVBhGy1EWkAHZ cPUXFrDKDTEgj8V19I4DHjbC98OfWPh2yK9VAja3sBHB8cDCKTk= =oAEg -----END PGP SIGNATURE----- --P7qCUsnlfcNa+GXU--