Feedback-ID: i0fe9450f:Fastmail
Date: Thu, 17 Aug 2023 09:31:55 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>,
	Tatsuo Ishii <ishii@sraoss.co.jp>, davecramer@gmail.com,
	tgl@sss.pgh.pa.us, peter@eisentraut.org, robertmhaas@gmail.com,
	smithpb2250@gmail.com, pgsql-hackers@lists.postgresql.org
Subject: Re: Using defines for protocol characters
Message-ID: <ZN1qe0dYIIKmzOPo@paquier.xyz>
References: <ZNvwDsy2lfGXoUUc@paquier.xyz>
 <20230815214007.ptksp5nmtwt3yrjn@alvherre.pgsql>
 <20230816192956.GA2908487@nathanxps13>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="Wc0VB/OEg8uiKS+U"
Content-Disposition: inline
In-Reply-To: <20230816192956.GA2908487@nathanxps13>
Archived-At: <https://www.postgresql.org/message-id/ZN1qe0dYIIKmzOPo%40paquier.xyz>
Precedence: bulk


--Wc0VB/OEg8uiKS+U
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Aug 16, 2023 at 12:29:56PM -0700, Nathan Bossart wrote:
> I moved the definitions out to a separate file in v6.

Looks sensible seen from here.

This patch is missing the installation of protocol.h in
src/tools/msvc/Install.pm for MSVC.  For pqcomm.h, we are doing that:
lcopy('src/include/libpq/pqcomm.h', $target . '/include/internal/libpq/')
    || croak 'Could not copy pqcomm.h';

So adding two similar lines for protocol.h should be enough (I assume,
did not test).

In fe-exec.c, we still have a few things for the type of objects to
work on:
- 'S' for statement.
- 'P' for portal.
Should these be added to protocol.h?  They are part of the extended
protocol.

The comment at the top of PQsendTypedCommand() mentions 'C' and 'D',
but perhaps these should be updated to the object names instead?

pqFunctionCall3(), for PQfn(), has a few more hardcoded characters for
its status codes.  I'm OK to do things incrementally so it's fine by
me to not add them now, just noticing on the way what could be added
to this new header.
--
Michael

--Wc0VB/OEg8uiKS+U
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmTdansACgkQnvQgOdby
QH0wCxAAhdyK9VrUyXsRxS7kwk5v79lpHgPHU+ykTYPUCr22zhJqJIKSg1K3swKY
N7ji41oXJPV/dn3pSnqgFuaER3LZiv3qCHfTCEEkKQa2Lz1X7RyMz4O1oLt8cGQ6
7t2+9/ZUI4vX/Sq4c1ikdxu+Dmz+OUU0MTKbC/kWHc3S+dWwgF2Acnqo5j/nazjc
JJt2hEk3CFMhsl79LdUv9OQ/yfSWDMjf8XnWkWomcf5gI4ccUx7+DeQ86tA7JZQg
UZOoYgUNZYG2QIsDCJY5DbPVDohvP0nMU9XDngzws4+mIR+hT3rrYoyY5aMl+WCv
MD/cFmsIK3rOCiwFtloFVUIhlAGCFa/9+9ZUHpLKly3r5ZxoRfqtfRk9JJ60JKbk
1wo6Eu09yjPMA13RiEH5Ju7HrQgBoNIc/PARnXB5Ms4CGKmXK0LS+cEyOyc2NzA+
2lj6rQNKInDO5+gLPotiI6tQ49g8IBHqbxwcrhaBPaxUfUiZ0uwDeHHlIy6o6vW0
8ygxcB5+d2I3PflAiPOy7Znc2TtwqgqSK41+8gigCRjkCcQsmPdlg4yhV5Mz6Raa
g1YDx2blyDNVWXO0nQioOFfN+ZrC/qUXV3dngtSbtYWWvzqE2jg4KgOs3yKJybGs
DNxF3HEcMa6MKsoddXql/X6kI5xNVr8UNNZyoPtPNiNDDYWcGbs=
=zA7N
-----END PGP SIGNATURE-----

--Wc0VB/OEg8uiKS+U--