Feedback-ID: i0fe9450f:Fastmail
Date: Fri, 18 Aug 2023 08:31:37 +0900
From: Michael Paquier <michael@paquier.xyz>
To: jian he <jian.universality@gmail.com>
Cc: "Drouvot, Bertrand" <bertranddrouvot.pg@gmail.com>,
	Postgres hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Normalization of utility queries in pg_stat_statements
Message-ID: <ZN6t2cfi21+YFoet@paquier.xyz>
References: <0e067034-e92c-302b-24ed-492bca228e26@gmail.com>
 <Y+7n+uz6XkzJpB7z@paquier.xyz>
 <14965f63-6d78-45ff-d029-daafe8eddb40@gmail.com>
 <Y/Lbt12YUHSU2fYl@paquier.xyz>
 <Y/LcU/u8CbD+nxYp@paquier.xyz>
 <Y/7Y9U/y/keAW3qH@paquier.xyz>
 <1f84685f-1ffd-4937-de63-aaa1513a0b7e@gmail.com>
 <ZAFBR1cwIq39ywX+@paquier.xyz>
 <ZAgo9QEPa4JWghVX@paquier.xyz>
 <CACJufxEjM5M=N+f5R5yRYghoXpMiUM=sRwSio-YczsaVxU8Xqg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="DLwLtTdJaTPKAUAy"
Content-Disposition: inline
In-Reply-To: <CACJufxEjM5M=N+f5R5yRYghoXpMiUM=sRwSio-YczsaVxU8Xqg@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/ZN6t2cfi21%2BYFoet%40paquier.xyz>
Precedence: bulk


--DLwLtTdJaTPKAUAy
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Aug 16, 2023 at 05:11:47PM +0800, jian he wrote:
> SELECT calls, toplevel, rows, query FROM pg_stat_statements ORDER BY
> query COLLATE "C";
> returns:
>  calls | toplevel | rows |               query
> -------+----------+------+------------------------------------
>      1 | t        |    0 | CALL ptest3($1)
>      2 | f        |    2 | INSERT INTO cp_test VALUES ($2, x)
>      1 | t        |    1 | SELECT pg_stat_statements_reset()
>=20
> here, the intermediate CALL part is optimized away. or should I expect
> CALL ptest1($1) also in pg_stat_statements?

I would have guessed that ptest1() being called as part of ptest3()
should show up in the report if you use track =3D all, as all the nested
queries of a function, even if it is pure SQL, ought to show up.  Now
note that ptest1() not showing up is not a new behavior, ~15 does the
same thing by missing it.
--
Michael

--DLwLtTdJaTPKAUAy
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmTerdkACgkQnvQgOdby
QH2ipw//cMatyFfVfXX7WnYmuWu17OuALo3B//6786VlGmYi8c9FxFYHU91Jykb+
D52iZUGepzrJclEEwQ8ojiiAHyEhso7ZdQl4Fe6EKT6gPg5tpVREXNwVkzBIz2B3
156NTaai6YSO7MgscOu63UXxPa63JXKz/FP2uUHwvsTZXpmaaGhtUACWQk6OM+Gu
O6/RerQnFhbmuIHKoEqXoxSM2yjqksDXEW0d57a3F4RhSh3Y9EoneXaBChn7XG72
n0Je4jqWSAkyc2rioa5e8f+IVJUqcNjqhbnUtY/lSsFd2RCDXyMJBCMddQzf8+gT
J0EsWCmT0MInWCjrq9U5/p8z6Q1lcfchVGkbDxUoeYuNa1pnMMse5tiRqDgBjdUw
gRjbM0YX+/QEKm8oPyjkexupUkgYa5FpOTPIgxuf+MgZZfKYEsRHO7nce27eX7Mg
c9U5Fv9X2WnasJHH3FMQO8FNQdGfK+EoVdBaIQmqx0v8xGJvTgLq5g3VJQVoFfS8
nSiSCdGmZssLc2EYhzfmvWyd9G45MeSWLyVjD62ZP9W4m8nfsn+MiKhWIcrYV2wP
bmAMZDP93n6nEWCh1PDbHu82IpN0tzJa6P/Exf89h0hTL2AOVF5IltHsJW/qwEZS
043BX9dv2NqtU1n1mbrXpWyR8XbrTu7lKaQ8HLQDJCQJswT57Pk=
=nwWT
-----END PGP SIGNATURE-----

--DLwLtTdJaTPKAUAy--