Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qW9yC-002JK2-A7 for pgsql-hackers@arkaria.postgresql.org; Wed, 16 Aug 2023 06:25:28 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1qW9yA-003kSh-QW for pgsql-hackers@arkaria.postgresql.org; Wed, 16 Aug 2023 06:25:26 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qW9vd-003hQU-Rf for pgsql-hackers@lists.postgresql.org; Wed, 16 Aug 2023 06:22:49 +0000 Received: from out1-smtp.messagingengine.com ([66.111.4.25]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qW9vb-000QGC-7F for pgsql-hackers@lists.postgresql.org; Wed, 16 Aug 2023 06:22:49 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 2641E5C00F5; Wed, 16 Aug 2023 02:22:46 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Wed, 16 Aug 2023 02:22:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm1; t=1692166966; x=1692253366; bh=dt XF5vpVVHkNXFND+jMJCiBYpv8E40pVPL8h0SeoTbc=; b=DX/V/fpH65w9K2M239 77eay3FkGZD9CDtncgFnFo8/iVK05n8D6aZjCVZHgd++SSGC2E2v8DFEWYnfc7Oc +P8omFBPRgqOPjG6b83lC3mb/pfBm5Fdrum2mOsu1wQhwZ+rZajexcIWWKkCHRB2 lQ0GblQ2bw/lLCsopXWKJcoa6Je3l0saRkwMTPFqthcqUhOhj121iSxDx6TVxZdK R8jEQ5CMTKLrtxKQ2aaRVdLtMuI0m6fDjP+3tlG8EDL4rmoVoMA0duXNVUtOu9FM 68TpN852ZOxlQlvC+74PUVg1nQhew31FbhirhQkX4LAFz6HyE6+XRqeSk4U1qgAW xBAA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1692166966; x=1692253366; bh=dtXF5vpVVHkNX FND+jMJCiBYpv8E40pVPL8h0SeoTbc=; b=FO5YxJDDcOVx1jbsSKVmMMFhOphP9 r7frjWYa6etmHER9jxyD+zjKRrBQcZqZGyZNEf8cQUHWDjukO+tixsQorgcYM4GM VM0it3mnxPHHH1CPRyxpvNZc5fT+XlqcQHQS1wUrNcVBCgsNKzbcE15PuQzhHAc2 aTAMVlurKDk+la9fYGoeTUND5BGzCSA9aWRKCJuteLDGgaxGGwp/q48HImdct64t 7aAeV+5eX+Dn37LlMs6KIh1xKiuhZ3jrbb28C59zX+OTzzANI+wbHRYFEVB/Elkn 4/QW+9qbfPgx+vAv/drAgXsOD41GPXD8eX2RNji5EqRHQaTN5VK5XQ6LQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedruddtkedguddtjecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enfghrlhcuvffnffculdejtddmnecujfgurhepfffhvfevuffkfhggtggujgesghdtreer tddtvdenucfhrhhomhepofhitghhrggvlhcurfgrqhhuihgvrhcuoehmihgthhgrvghlse hprghquhhivghrrdighiiiqeenucggtffrrghtthgvrhhnpeetleeifedufffhhfdtteel geeggeffhfekueevteeigfduudevudetgfegiedvjeenucevlhhushhtvghrufhiiigvpe dtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmihgthhgrvghlsehprghquhhivghrrdig hiii X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 16 Aug 2023 02:22:44 -0400 (EDT) Date: Wed, 16 Aug 2023 15:22:41 +0900 From: Michael Paquier To: "Drouvot, Bertrand" Cc: Kyotaro Horiguchi , tgl@sss.pgh.pa.us, pgsql-hackers@lists.postgresql.org Subject: Re: WIP: new system catalog pg_wait_event Message-ID: References: <0109438a-9672-322b-7638-04ad47c97d0f@gmail.com> <1dc98591-0d06-f0da-bc88-21f529d6fb8e@gmail.com> <20230808.115332.301701413576096139.horikyota.ntt@gmail.com> <2f84b397-d020-493c-924c-610b9dd18f8d@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="/N+BXwpqG0SiPsEx" Content-Disposition: inline In-Reply-To: <2f84b397-d020-493c-924c-610b9dd18f8d@gmail.com> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --/N+BXwpqG0SiPsEx Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Aug 16, 2023 at 07:04:53AM +0200, Drouvot, Bertrand wrote: > I'd prefer the singular form. There is a lot of places where it's already used > (pg_database, pg_user, pg_namespace...to name a few) and it looks like that using > the plural form are exceptions. Okay, fine by me. Also, I would remove the "wait_event_" prefixes to the field names for the attribute names. > Yeah, now that af720b4c50 is done, I'll add the custom wait events handling > in v6. Thanks. I guess that the hash tables had better remain local to wait_event.c. -- Michael --/N+BXwpqG0SiPsEx Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmTcazEACgkQnvQgOdby QH102A/9EiRt5I3Z4KvqFzwYA9WX6G9CgTpYRWDqOXJuLrFnspOXGEx2hD4pX7zm yqX5iT/C4eji7+1YfOTTKpMZMHgzJNxsGLd1OyL665iyy6WAu2jl+3waWAezQdHu C/acQpSjMQAcvNMIN9ucTFWG9rkpcT4OJco0clWZrBmHK1o5aijXp8Rodon8FV0h 9Ka+sJAVCR7we5/BQXXilQ3T05rc6KmEN+MXTZ+41Tajr+0yvNkVikeeieBXH4l6 +1koQ19x7BpqY2+d7G/Pxno/9qJNE3CYcLiElhB9pIrYyw8eoCLV27nc4pcib/Jr +MSLYNaj/uz+grmG8JSdtXDJtKgiLprbPiyB0sEBffY9ekSE5/9xxp81Wk6SSVpT WWF7V6X9MrWLjEEU+ZgI93c6S2gz7GAxsojYADHlxR7jWdJT152HekZG7V3Q+iXu ac/VzaRlUiqBFl/LnIlMgLkCo9nD1Y/Vf3rT4qyD2zw8iL0kWuebWcc3pBUS7AVr rwUJbIo05j7PWRSP9LP5x6lZL8NtgO8XEwRe6JHayMBhszxZP99XTRyuzu8RBaXo s+cXW/EG5Ku/CQXWUtThGOMb28ozNH2NApa7hAn3DFwamfeMJ8FLaPya2YeMNHzs cRvsJlwVPnbdtRsanlknHSWzIWNOVxo03YPbEJE1Q7FbkDhhbTE= =4tlf -----END PGP SIGNATURE----- --/N+BXwpqG0SiPsEx--