Feedback-ID: i0fe9450f:Fastmail
Date: Wed, 30 Aug 2023 08:22:27 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: "Imseih (AWS), Sami" <simseih@amazon.com>,
	Ian Lawrence Barwick <barwick@gmail.com>,
	pgsql-hackers <pgsql-hackers@postgresql.org>,
	"robertmhaas@gmail.com" <robertmhaas@gmail.com>
Subject: Re: pg_stat_get_backend_subxact() and backend IDs?
Message-ID: <ZO59s6in+aACdCGb@paquier.xyz>
References: <CAB8KJ=j-ACb3H4L9a_b3ZG3iCYDW5aEu3WsPAzkm2S7JzS1Few@mail.gmail.com>
 <20230824023206.GA1128857@nathanxps13.lan>
 <20230824025140.GB1128857@nathanxps13.lan>
 <20230824161913.GA1394441@nathanxps13.lan>
 <CAB8KJ=iWYvB1odjFRZybsPeUV8HUAiVVjY9RMHSdvWy1t77cLg@mail.gmail.com>
 <20230825153251.GA1593219@nathanxps13>
 <20230825192949.GA1917227@nathanxps13>
 <CF0C64D6-BB5C-4F84-98BB-8852A1C01A40@amazon.com>
 <ZOv+MHonWVgW/bpf@paquier.xyz>
 <20230829164655.GA2138073@nathanxps13>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="ck5Bp49YHKXzPK3T"
Content-Disposition: inline
In-Reply-To: <20230829164655.GA2138073@nathanxps13>
Archived-At: <https://www.postgresql.org/message-id/ZO59s6in%2BaACdCGb%40paquier.xyz>
Precedence: bulk


--ck5Bp49YHKXzPK3T
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Aug 29, 2023 at 09:46:55AM -0700, Nathan Bossart wrote:
> This was my first reaction [0].  I was concerned about renaming the
> exported functions so close to release, so I was suggesting that we hold
> off on that part until v17.  If there isn't a concern with renaming these
> functions in v16, I can proceed with something more like v2.

Thanks for the pointer.  This version is much better IMO, because it
removes entirely the source of the confusion between the difference in
backend ID and index ID treatments when fetching the local entries in
the array.  So I'm okay to rename these functions now, before .0 is
released to get things in a better shape while addressing the issue
reported.

+extern LocalPgBackendStatus *pgstat_get_local_beentry_by_index(int beid);=
=20

Still I would to a bit more of s/beid/id/ for cases where the code
refers to an index ID, and not a backend ID, especially for the
internal routines.
--
Michael

--ck5Bp49YHKXzPK3T
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmTufbMACgkQnvQgOdby
QH0isw//VTGtqpq6l5AyOsazGzRJPn972iK60j5faSrAZ1t8BsV8KuoFVXQjPDf0
ttyx1i2udt2JYBbTv7rMZgBUEoQH+y5tLFWTrlypOwOetDA0SIQy7wPk3YAX1HUo
bqaeMEyEXjfonmcV0WBPNimbgp7n7xdD1+3UlDqwJiIcs06cWYJvIi/dKkDLoWI3
mr+AjY2Ypb+g03kjDdF6h/fJMXj8cQw24dib3KuoNWvtonAyO4qHRT7Qav+yJtCq
xGFhnexRa8+fK1bU9Njvthzo3epAmxsnh94uoFR/+KVl7jM3O0w4y402BQROwDFa
YkxMFglqIACSa0tehm9drNH1eiT/Bo9tcKTh+n7Kw224AONic+Czymp1ciVbtvvT
NVMuMN8NcUA7xxtuMQ+4PCY8+8xmdvfm7EBPvThL+uT0pxHj0Qdrk3SWlJ9laWLh
62FkkZY1Q0sCgEoMiwhEO16rjJpAOez8hTHMZ5TcjX/VBrfLjxwiUjWNthrHdLRJ
3DAu7JQurFfAkangm1XlfCbtqDMVrJRVq13Halzk3U2jqPO2aAGZNPmTfhlK4j1Y
lPsTJzOdncorovHUB7brD3yXyuGUL8PKnKokr6yXe7pXO1rTpMKe5W3o+qvnq/DN
JYStswL7beghP1Ax1n0OXtOABRKbfVTQaRf9CXhBj+/VtGFAOxU=
=SkxV
-----END PGP SIGNATURE-----

--ck5Bp49YHKXzPK3T--