Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qbCaU-00BNpA-DV for pgsql-hackers@arkaria.postgresql.org; Wed, 30 Aug 2023 04:13:51 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1qbCaS-00ENe4-Iq for pgsql-hackers@arkaria.postgresql.org; Wed, 30 Aug 2023 04:13:48 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qbCaR-00ENd2-7R for pgsql-hackers@lists.postgresql.org; Wed, 30 Aug 2023 04:13:48 +0000 Received: from out2-smtp.messagingengine.com ([66.111.4.26]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qbCaM-001roh-SO for pgsql-hackers@postgresql.org; Wed, 30 Aug 2023 04:13:46 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id CA4D85C012B; Wed, 30 Aug 2023 00:13:39 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Wed, 30 Aug 2023 00:13:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm1; t=1693368819; x=1693455219; bh=Kh cKI71zW7lHF1gUghA77so1dVoZhJn+mgE2IpkhNFY=; b=MbO5193tAHuWwN7pte nK8hpIVblIk5vlf+3ntZsxf/uYyiZAUmvpcNoJX/c2vpOWVeWp2tAOWu5vkRuSBH tqulWondusZ2Uy15TLSe1PmYcgrhw1uP02WPBWj+rdehZYrvX0LzkFzojs1llfC/ uu3Nb4eaJ3vmWMtkA7cebecwhjZN8uWLLeEXXxvMtbQYVoZ0J5cMYavXx4OjqiFZ gJMwxWFTH/Mny9ug0iIjLBopSXjcBsYmw3xcJWuslSx6dO2GB5ERvLzY/iw13Ofo en+66ULMyv79KbChR62tRMXei5+hYSCgq4oz9Q2Bc2jimQmRtQyGerZu1sWEjH5O MxhA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1693368819; x=1693455219; bh=KhcKI71zW7lHF 1gUghA77so1dVoZhJn+mgE2IpkhNFY=; b=aANq+wUypbpYfd7SexrZYIGJGIuk5 NbBQ0J+iuE8UGTOkyezbqLx3EUs79Dw5BCicLGtqrFb74cR53pfHr6xSjYrnYvUu aSdklcGuBPKnJossL68UawdCvdVkzVabvGITve3WHwr7EY2VUS6ThIg9eA+W+NN6 uB+N4TMOhBtwgh35XBkmtCjW/hL+8LnoGAUJCycdW9S5hNZd2Zq/lnAWGP1F+keh uyp6UEEgtjvyRbiggBpI7QNpsI8qhm+bzLyq5xV/T1/AXUeAPyOafVEb5ViiS77g J3NmBMNaWBj430HqP13qO0FU05tUb3M9Hnt3f5bf5wJOUwDNA1RO+Grtg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrudefjedgkedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne gfrhhlucfvnfffucdljedtmdenucfjughrpeffhffvvefukfhfgggtuggjsehgtderredt tddvnecuhfhrohhmpefoihgthhgrvghlucfrrghquhhivghruceomhhitghhrggvlhesph grqhhuihgvrhdrgiihiieqnecuggftrfgrthhtvghrnhepteelieefudffhffhtdetleeg geegfffhkeeuveetiefgudduvedutefggeeivdejnecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomhepmhhitghhrggvlhesphgrqhhuihgvrhdrgiih ii X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 30 Aug 2023 00:13:36 -0400 (EDT) Date: Wed, 30 Aug 2023 13:13:31 +0900 From: Michael Paquier To: Nathan Bossart Cc: "Imseih (AWS), Sami" , Ian Lawrence Barwick , pgsql-hackers , "robertmhaas@gmail.com" Subject: Re: pg_stat_get_backend_subxact() and backend IDs? Message-ID: References: <20230824025140.GB1128857@nathanxps13.lan> <20230824161913.GA1394441@nathanxps13.lan> <20230825153251.GA1593219@nathanxps13> <20230825192949.GA1917227@nathanxps13> <20230829164655.GA2138073@nathanxps13> <20230830020151.GA2488217@nathanxps13> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="iVbE0XG+HkWsuitA" Content-Disposition: inline In-Reply-To: <20230830020151.GA2488217@nathanxps13> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --iVbE0XG+HkWsuitA Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Aug 29, 2023 at 07:01:51PM -0700, Nathan Bossart wrote: > On Wed, Aug 30, 2023 at 08:22:27AM +0900, Michael Paquier wrote: >> +extern LocalPgBackendStatus *pgstat_get_local_beentry_by_index(int beid= );=20 >>=20 >> Still I would to a bit more of s/beid/id/ for cases where the code >> refers to an index ID, and not a backend ID, especially for the >> internal routines. >=20 > Makes sense. I did this in v4. Yep, that looks more consistent, at quick glance. -- Michael --iVbE0XG+HkWsuitA Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmTuwesACgkQnvQgOdby QH1pcw//YzLil7WRGQ1IyMSS9/poKfDJNUghXBi74dCbSDxOUWQSkbArZMDgLTsg SIFkg0gTcHyjocNtX/fWOLJBQHX9JTJbGJLkx80UfwVa5HFJ/gnFLLPCaV9xQ3ef vdAbTuqoLQa/YKDfK3/C1EX9VaQNUyJLxodE5f8YitEMrkBGt7eAV/h//27uDqlV n548+Vw32EJhYuZtUG/UqS5UtdtBnTf0WKfBMGRvYlMX5aR6KGux1AdAeRx7EhvK 5rIU6/fY+R2jsIHdm4THkBdBbrixOwgkQ2MOBDLqMpNGLXX/NIZICFRyM/iV6S4X Imk55s5e8OyDebT1lcGm3SvTlxHTXFtcWyBo0Kijn/ZLrUAtwndHePFP2VP6T5Km 2qFr3dT5Q1g8rFsNtNppUE6IvLv5V3l/WNBU98tMigD4lSFd53+ITe9MIcd89WmD ZeTJRByhUSFjiQsnj8IPd+Jei1NwNtrHopmJrYIhF5qt/o7P4H7jWTesttnjBjO3 IplZW+0EW9IqCluFaOilONCK8q4AtBqb1xM0cW0ZWkrvFiI+NtDprmRtOyV3OPNt rVJq70m0C6zesBaIf0nbDXhC7cvc2iFLZHTI4OhXxUBgNnyIKy5O0AEFvym4pS2j loVyJJfRZSRgi2xYbDXQmoiso5m2mSu31frPOHB0GSEEjRoEtuA= =A8tG -----END PGP SIGNATURE----- --iVbE0XG+HkWsuitA--