public inbox for [email protected]
help / color / mirror / Atom feedFrom: Michael Paquier <[email protected]>
To: Peter Geoghegan <[email protected]>
Cc: Ranier Vilela <[email protected]>
Cc: Pg Hackers <[email protected]>
Subject: Re: Avoid a possible overflow (src/backend/utils/sort/logtape.c)
Date: Fri, 25 Aug 2023 10:18:48 +0900
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAH2-Wznn84Qjtzb53NPEnbjOS6nYLZv+3fdhZEup76WdHHdv1Q@mail.gmail.com>
References: <CAEudQApLDWCBR_xmwNjGBrDo+f+S4E87x3s7-+hoaKqYdtC4JQ@mail.gmail.com>
<ZOfsGzuS/[email protected]>
<CAH2-Wznn84Qjtzb53NPEnbjOS6nYLZv+3fdhZEup76WdHHdv1Q@mail.gmail.com>
On Thu, Aug 24, 2023 at 05:33:15PM -0700, Peter Geoghegan wrote:
> I am in favor of fixing the problem. I don't quite recall what it was
> that made the discussion stall last time around.
I think that you mean this one:
https://www.postgresql.org/message-id/[email protected]...
Still that looks entirely different to me. Here we have a problem
where the number of free blocks stored may cause an overflow in the
internal routine retrieving a free block, but your other thread
is about long being not enough on Windows. I surely agree that
there's an argument for improving this interface and remove its use of
long in the long-term but that would not be backpatched. I also don't
see why we cannot do the change proposed here until then, and it's
backpatchable.
There is a second thread related to logtape.c here, but that's still
different:
https://www.postgresql.org/message-id/flat/CAH2-Wzn5PCBLUrrds%3DhD439LtWP%2BPD7ekRTd%3D8LdtqJ%2BKO5D...
--
Michael
Attachments:
[application/pgp-signature] signature.asc (833B, ../[email protected]/2-signature.asc)
download
view thread (5+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: Avoid a possible overflow (src/backend/utils/sort/logtape.c)
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox