Feedback-ID: i0fe9450f:Fastmail
Date: Mon, 28 Aug 2023 09:52:09 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>
Subject: Logger process and "LOG:  could not close client or listen socket:
 Bad file descriptor"
Message-ID: <ZOvvuQe0rdj2slA9@paquier.xyz>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="8LSby7w7SkWMQFbG"
Content-Disposition: inline
Archived-At: <https://www.postgresql.org/message-id/ZOvvuQe0rdj2slA9%40paquier.xyz>
Precedence: bulk


--8LSby7w7SkWMQFbG
Content-Type: multipart/mixed; boundary="e2d+Op/TWPMOp+ma"
Content-Disposition: inline


--e2d+Op/TWPMOp+ma
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi all,
(Heikki in CC.)

After b0bea38705b2, I have noticed that the syslogger is generating a
lot of dummy LOG entries:
2023-08-28 09:40:52.565 JST [24554]
LOG:  could not close client or listen socket: Bad file descriptor =20

The only reason why I have noticed this issue is because I enable the
logging collector in my development scripts.  Note that the pg_ctl
test 004_logrotate.pl, the only one with logging_collector set, is
equally able to reproduce the issue.

The root of the problem is ClosePostmasterPorts() in syslogger.c,
where we close the postmaster ports, but all of them are still set at
0, leading to these spurious logs.

=46rom what I can see, this is is a rather old issue, because
ListenSocket[] is filled with PGINVALID_SOCKET *after* starting the
syslogger.  It seems to me that we should just initialize the array
before starting the syslogger, so as we don't get these incorrect
logs?

Thoughts?  Please see the attached.
--
Michael

--e2d+Op/TWPMOp+ma
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment; filename="syslogger-sockets.patch"
Content-Transfer-Encoding: quoted-printable

diff --git a/src/backend/postmaster/postmaster.c b/src/backend/postmaster/p=
ostmaster.c
index 41bccb46a8..acd46718fc 100644
--- a/src/backend/postmaster/postmaster.c
+++ b/src/backend/postmaster/postmaster.c
@@ -1141,6 +1141,17 @@ PostmasterMain(int argc, char *argv[])
 				 errmsg("could not remove file \"%s\": %m",
 						LOG_METAINFO_DATAFILE)));
=20
+	/*
+	 * Establish input sockets.
+	 *
+	 * First, mark them all closed, and set up an on_proc_exit function that's
+	 * charged with closing the sockets again at postmaster shutdown.
+	 */
+	for (i =3D 0; i < MAXLISTEN; i++)
+		ListenSocket[i] =3D PGINVALID_SOCKET;
+
+	on_proc_exit(CloseServerPorts, 0);
+
 	/*
 	 * If enabled, start up syslogger collection subprocess
 	 */
@@ -1173,17 +1184,6 @@ PostmasterMain(int argc, char *argv[])
 	ereport(LOG,
 			(errmsg("starting %s", PG_VERSION_STR)));
=20
-	/*
-	 * Establish input sockets.
-	 *
-	 * First, mark them all closed, and set up an on_proc_exit function that's
-	 * charged with closing the sockets again at postmaster shutdown.
-	 */
-	for (i =3D 0; i < MAXLISTEN; i++)
-		ListenSocket[i] =3D PGINVALID_SOCKET;
-
-	on_proc_exit(CloseServerPorts, 0);
-
 	if (ListenAddresses)
 	{
 		char	   *rawstring;

--e2d+Op/TWPMOp+ma--

--8LSby7w7SkWMQFbG
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmTr77kACgkQnvQgOdby
QH2A+g/+Lzga07TiKTBlgxtKODjtg8YFUNlQms6kdkZSa5h6tfcYWvUTpU3YG1wt
igSBVp3k8WBJ4k2kTo1riNH4eblki1g14BoJ4iueZ4dFVXEsz/1WsTcs7OxVeEUu
bBVVvCbE5ozTtKg51wxM17RSG6HVg/BPCfUO7mG59fJm2JsHX1UHqkTF6JYcWyHn
xj+BsJIjtwOLwgR79rg8Yin0SIp9cnf5wwrpz+bmyu7yreaP5WjUh3gXAhAJgt2+
9FAG0xRfrdUpcnvY4Qjt3050U/A4idmImNCXRHtINEC6dR1FS4pFnVCGgTs2vbsv
iUTm2T71RqSBhMg0UKWVo/gOssO65LQYMPHuk66NM+lEWFo5VhlAqgZNHhJ4HZ1W
UE2zv9fJP15EE7m9ajJp1JlzqCKDtdp92iMPx4trqIM/I3KwCOP96SoSQrbDT78A
S9/M+3MosEwa9Zf9W/7bDQvh/lsTshigCq3jqoHgMIdguV07isn/cdYZcOiWeQ3X
80NzAOBIM5WK+RMw0xKJosrdyqKbbvSo4cMITHWcyFY2gtLc47Ngs+CSMZbUVetQ
BJMovn7lkm92RAS9v9HoXzYdsxZLmGklcGvOhK9GFOyLKmz2Or0iIyA+aCEu5lrt
kOl9rrqHrqfFbmYRLunHNGtd5lixC3z3/hEuQxaaHK2XGd0USMs=
=4w7y
-----END PGP SIGNATURE-----

--8LSby7w7SkWMQFbG--