Feedback-ID: i0fe9450f:Fastmail
Date: Mon, 11 Sep 2023 07:33:16 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Jim Jones <jim.jones@uni-muenster.de>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: [PATCH] Add inline comments to the pg_hba_file_rules view
Message-ID: <ZP5ELFdn28Hn1Hfi@paquier.xyz>
References: <4d623899-36ac-71b5-311d-2a4672d75736@uni-muenster.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="PoyjEQnp5qFMKskA"
Content-Disposition: inline
In-Reply-To: <4d623899-36ac-71b5-311d-2a4672d75736@uni-muenster.de>
Archived-At: <https://www.postgresql.org/message-id/ZP5ELFdn28Hn1Hfi%40paquier.xyz>
Precedence: bulk


--PoyjEQnp5qFMKskA
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Sep 04, 2023 at 12:54:15PM +0200, Jim Jones wrote:
> The patch slightly changes the test 004_file_inclusion.pl to accommodate =
the
> new column and the hba comments.
>=20
> Discussion: https://www.postgresql.org/message-id/flat/3fec6550-93b0-b542=
-b203-b0054aaee83b%40uni-muenster.de

Well, it looks like what I wrote a couple of days ago was perhaps
confusing:
https://www.postgresql.org/message-id/ZPHAiNp%2ByKMsa/vc%40paquier.xyz
https://www.postgresql.org/message-id/ZPE8A7EnUH+ax5kw@paquier.xyz

This patch touches hbafuncs.c and the system view pg_hba_file_rules,
but I don't think this stuff should touch any of these code paths.
That's what I meant in my second message: the SQL portion should be
usable for all types of configuration files, even pg_ident.conf and
postgresql.conf, and not only pg_hba.conf.  A new SQL function
returning a SRF made of the comments extracted and the line numbers=20
can be joined with all the system views of the configuration files,
like sourcefile and sourceline in pg_settings, etc.
--
Michael

--PoyjEQnp5qFMKskA
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmT+RCwACgkQnvQgOdby
QH21iw/+KHifKl4V2hNclT9gd8GThzYmkonxoc0W2HKAihF8NiZWeHF81AQZ8O5R
N5QLsXQSCyNeSfRU6/defF6s8+mf6pZrpS0a7n9sR6n+Jz1BeTWMsk0DpzjhDOo/
2u+UTHrv2jEALMz2eSz8mcsFQg7tcfonV6DuF110ARcEs31u2vzeekzIIdWjRA9i
hE3M9pPMvre6zuZAH06YY6gDh6YTgIZLYRARX3cEHZalz6gsMNLdWkkeYN0nl0nW
5kdRhkwe8UoVObaYFkjE63QhCuDJaR4NfcnhUKtrIeUMT5IrK78A1jK0Q0b6CQkn
7gXcsjFD84+p+wjT/RK0VVG5zKBt7151b8AqMDKrW2yg0ZHdQzPrPZ4D1epQpCg5
BNZgYy7O1zRYefuEWkr5g0+KvLnY+hFO0fY5dPCue+ha7WfKa9SIDt8JjlBSTWhz
OtjCOLuEKNGogD7/g0vbxieSfuGoA3inLp11quON52CyW5Z4BllVtc3MtqKzbVEj
FIjaUwfZmjXt1ThnnE7dyPcdcHK9OwxNTuEuEao68yFjCbGtJgN/juNhLh8Od5FE
cwv+vAX/KmYdWn08lQepPrelmi/czEskZCMnQsnzpCdz4JvkLOhD3t5asrm7R7W7
UozkEPHYkxyVBj2DH8YG3QbZ/cG/5qbomzKaONh9YEUIY/JgEGQ=
=gcEt
-----END PGP SIGNATURE-----

--PoyjEQnp5qFMKskA--