Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qbYFy-00CM6S-P1 for pgsql-hackers@arkaria.postgresql.org; Thu, 31 Aug 2023 03:22:07 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1qbYFx-003aFg-4X for pgsql-hackers@arkaria.postgresql.org; Thu, 31 Aug 2023 03:22:04 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qbYFv-003aFS-Q7 for pgsql-hackers@lists.postgresql.org; Thu, 31 Aug 2023 03:22:04 +0000 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qbYFp-001tUZ-Dk for pgsql-hackers@postgresql.org; Thu, 31 Aug 2023 03:22:02 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 0B3B932003C0; Wed, 30 Aug 2023 23:21:53 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Wed, 30 Aug 2023 23:21:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm1; t=1693452113; x=1693538513; bh=gk ILu1jktPdDce2X7qua3FgUuVYvL8o5ULYeJmjSxCI=; b=iFj/eiMTx629Afcvj/ s0EzOq1JZPJcSH1XETI9jZdKqLmJTLgbK4+aT0Dhr85LAGjTa5HRkv1PMg0wKlVy XdBjgo7BelbpvK5lL+OZM2+2MycR7bzfn6HWqL2F5bcP6gmLexCl+D110T3nNGCO bdiYsv/X2sqODww81AF8WfTUdAVUMFbGC9/QGI4WCHzssrd2NGrLpLIZvtKqVDt7 5Z6k3s2zlbFLVZ0nNGihWCisqYLWuERwK6+LKy2xWO48QOeUUWOQyD2cuv2E/lCr a/N73KG8sMYHMpjxmr4s0wwo3XUDwZ/kZg/n+RRp1KeERk0L6b9Gxam9rYkaX0un rsSQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1693452113; x=1693538513; bh=gkILu1jktPdDc e2X7qua3FgUuVYvL8o5ULYeJmjSxCI=; b=XTlPW+bwm0z09cPmTX8a8OgtCyp7F nr/KygEBuU2T1f4dlrFWQVgWMM3G6F/PTxEl8a+c/byLKou2P0uBSO6EKkS2F8YL syYKfctCpqXcyfH4NyNBUWv/fvWMZWZeoz9I78UPENnUlIklw4HPSjJ9zEGsXAR+ 59WbWXITFjjrJwSUCR8x1RIDdQxELKHl8dxtODqNaJ2eDcarGL4XALDg735ilvoC FU3WUMy0zasWtZqaVZh/5dNQ+7tUB7ugy4ihISQguLSCNAquSd4u8JMzhGa7XZ66 rGGCAiAyeXdeh7Vb2ynIwTnP+TNv9E0gU5oOQeylWoe7ewepXAFAHnRhA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrudefledgieelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne gfrhhlucfvnfffucdljedtmdenucfjughrpeffhffvvefukfhfgggtuggjsehgtderredt tddvnecuhfhrohhmpefoihgthhgrvghlucfrrghquhhivghruceomhhitghhrggvlhesph grqhhuihgvrhdrgiihiieqnecuggftrfgrthhtvghrnhepteelieefudffhffhtdetleeg geegfffhkeeuveetiefgudduvedutefggeeivdejnecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomhepmhhitghhrggvlhesphgrqhhuihgvrhdrgiih ii X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 30 Aug 2023 23:21:52 -0400 (EDT) Date: Thu, 31 Aug 2023 12:21:47 +0900 From: Michael Paquier To: Ranier Vilela Cc: Pg Hackers Subject: Re: Replace some cstring_to_text to cstring_to_text_with_len Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="flq5HLXnFSitXbZh" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --flq5HLXnFSitXbZh Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Aug 30, 2023 at 03:00:13PM -0300, Ranier Vilela wrote: > cstring_to_text has a small overhead, because call strlen for > pointer to char parameter. >=20 > Is it worth the effort to avoid this, where do we know the size of the > parameter? Are there workloads where this matters? -- Michael --flq5HLXnFSitXbZh Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmTwB0sACgkQnvQgOdby QH1zQhAAjX9lKGtrmFvx4hCxwd37oV5WROfD9ozc7SxxuP6hkpmyQNU53uK434bl vKLPzmDGnka1GtjV40+v3vARrzh5DcSQh75IqKI5UbNbe08BdxUwIAxl6ijb8K3H pFohCKoO2TqIAF3G7UUmuqExlYlqpKDTvLMw5ei3Gjd0VDoAU2wB6yEygnwZRp3j g/1iWiiWYM3lMmDAocfW9zlErI7GLXwLwCv692lJxhd1OsFxPAMPzojirYbRx2HW VDtYbvpYMkjOtE4fazeIEqPwKBcmaJK/H74/qd0lauW4HDJmc3XBoQl7Wvwsnut6 iwdm+hLxTwPoo0A4+JLjg6sF/nTuHY+H/VdWLtRPxr9yBkSODGaiI2U05oVCTZfj enuqxFMZ9WG+UAQhEWXTZeauie3fhp6fsHsGvG35Tc3RBKkl47dBMGayK1RtGa+x JujrFXyyKjlSk1ljadKTyJoJ++JkZVjQRQRO27+vXj2FJx5JCepCILh9ux2dUYos WAiz6/KS4ocLMDJ18oP6tTTPeqCHbFOffvBOuR/v4402/Un6R8QPoNJoVCgiq/N+ q8PM5iOTjVuWVnpZmHbBfhu+qoWEZryfkBeF21OZMnS3vAFwkhKv7dm1s48GaxbG ZKWSma/A+kwQBmSXCsH+XD3hYTJwvfnMd6e6V2A2AWUzwFiCpqY= =fg3x -----END PGP SIGNATURE----- --flq5HLXnFSitXbZh--