Feedback-ID: i0fe9450f:Fastmail
Date: Tue, 5 Sep 2023 20:50:24 +0900
From: Michael Paquier <michael@paquier.xyz>
To: "Drouvot, Bertrand" <bertranddrouvot.pg@gmail.com>
Cc: Andres Freund <andres@anarazel.de>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
	Alvaro Herrera <alvherre@alvh.no-ip.org>
Subject: Re: Autogenerate some wait events code and documentation
Message-ID: <ZPcWADeGRwK1WzIb@paquier.xyz>
References: <ZK9S3jFEV1X797Ll@paquier.xyz>
 <ZLDT0kOh0tuh6IpV@paquier.xyz>
 <20230716192120.t53prl2uruingo6z@awork3.anarazel.de>
 <ZLSWUh3dpZPlvrso@paquier.xyz>
 <ZOxVHQwEC/9X/p/z@paquier.xyz>
 <6dc1587f-2ca6-4dd6-b389-94a05912fda5@gmail.com>
 <ZO2TLRFLT73IFN8T@paquier.xyz>
 <171299a1-6110-43ca-bb79-66b82e0baa12@gmail.com>
 <ZPbAUmywqWB+8wGY@paquier.xyz>
 <cc11ccbb-b97c-4025-8118-f31996b06dd6@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="ElV4QIbanyc8tzkB"
Content-Disposition: inline
In-Reply-To: <cc11ccbb-b97c-4025-8118-f31996b06dd6@gmail.com>
Archived-At: <https://www.postgresql.org/message-id/ZPcWADeGRwK1WzIb%40paquier.xyz>
Precedence: bulk


--ElV4QIbanyc8tzkB
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Sep 05, 2023 at 11:06:36AM +0200, Drouvot, Bertrand wrote:
> Oh ok, out of curiosity, why are 2 whitespaces intentional?

That depends on the individual who write the code, but I recall that
this is some old-school style from the 70's and/or the 80's when
typing machines were still something.  I'm just used to this style
after the end of a sentence in a comment.

> That looks good. I just noticed that v5 did re-introduce the "issue" that
> was fixed in 00e49233a9.
>=20
> Also, v5 needs a rebase due to f691f5b80a.
>=20
> Attaching v6 taking care of the 2 points mentioned above.

Dammit, thanks.  These successive rebases are a bit annoying..  The
data produced is consistent, and the new contents can be grepped, so I
think that I am just going to apply both patches and move on to other
topics.
--
Michael

--ElV4QIbanyc8tzkB
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmT3FgAACgkQnvQgOdby
QH3C6w//VKC+XFuc85enV0fF1fJFbuQhAeqr2ir2vpc5kEY0Z2AjY5fAYBJw2wvq
jvbp5zKpVi9kkf9zo+NhTceonXWKaLF6NJTzw593KR5NqaqXJ2cA0dxG711O0A3X
7pjVf7IUlbxXSDzz5un+Rus1x1yV3Xtpbk+k0dBMGi7S8irohJO9FgheqYCQoPg4
r2rOVicK4Jw9EbwQH1QuVXWk8Ex44EEpjjCY3yOjSIi71lB2NUEOHTNB486X0eza
guuesLI5gTJimfcTR7Jdu380qU54V9BO8DwND39Wj7su8hzYOkrtJR5Sg5aMVyUi
vDgKnE/uCQu4Hr61/yCDj4GevXuMgq56DIQFwfNhANq3mpvYAYtfz3thFU0CSIVd
rd0/nEs2llr1sS6HzWpGMeEvsoYgFzH1KEgGhe+lVVzG7RJOSl7vYwAn6aDjwdRs
7+L+JOaI6rFKiruw2zl5qnb6OBjerpesXIkz4MP9M7em1Qm11NzwnxlAVUD468O9
e5qbt7he0RQT7eg8VbIjYw0nKKySrkueHUVrgYvwC/6xUCs48oMCY6kPutbFhI9P
pqzMx1idrQ5/3hPwN2g3FnU0pJ77xiYQ7Ju+iOLmUammmlNgpSeb5J9xS1e+JedJ
I2TKwNDjpHIk8FEcWsfavL5EgGXNFeIFjXcytu84Wo6rZgYsXXo=
=fa22
-----END PGP SIGNATURE-----

--ElV4QIbanyc8tzkB--