public inbox for [email protected]  
help / color / mirror / Atom feed
From: Bruce Momjian <[email protected]>
To: Magnus Hagander <[email protected]>
Cc: PostgreSQL-development <[email protected]>
Subject: Re: Release notes wording about logical replication as table owner
Date: Wed, 6 Sep 2023 15:36:28 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <CABUevEwBXi5oqqMj429Lxjro1uu-fdKgSkJtgJS5aTOmujEGQQ@mail.gmail.com>
References: <CABUevEwBXi5oqqMj429Lxjro1uu-fdKgSkJtgJS5aTOmujEGQQ@mail.gmail.com>

On Wed, Sep  6, 2023 at 09:29:25PM +0200, Magnus Hagander wrote:
> We have:
> 
> "This improves security and now requires subscription owners to be
> either superusers or to have SET ROLE permissions on all tables in the
> replication set. The previous behavior of performing all operations as
> the subscription owner can be enabled with the subscription
> run_as_owner option."
> 
> How does one have SET ROLE permissions on a table? I think that's
> supposed to be:
> 
> "subscription owners be either superusers or to have SET ROLE
> permissions on all roles owning tables in the replication set."
> 
> Or something like that? Or can someone suggest a better wording?

You are exactly corrected.  Patch attached and applied.

-- 
  Bruce Momjian  <[email protected]>        https://momjian.us
  EDB                                      https://enterprisedb.com

  Only you can decide what is important to you.


Attachments:

  [text/x-diff] role.diff (769B, ../[email protected]/2-role.diff)
  download | inline diff:
diff --git a/doc/src/sgml/release-16.sgml b/doc/src/sgml/release-16.sgml
index 0fa0d25fe1..5f174e99f6 100644
--- a/doc/src/sgml/release-16.sgml
+++ b/doc/src/sgml/release-16.sgml
@@ -1818,7 +1818,7 @@ Author: Robert Haas <[email protected]>
        This improves security and now requires subscription
        owners to be either superusers or to have <link
        linkend="sql-set-role"><command>SET ROLE</command></link>
-       permissions on all tables in the replication set.
+       permission on all roles owning tables in the replication set.
        The previous behavior of performing all operations as the
        subscription owner can be enabled with the subscription <link
        linkend="sql-createsubscription"><option>run_as_owner</option></link>


view thread (3+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: Release notes wording about logical replication as table owner
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox