public inbox for [email protected]
help / color / mirror / Atom feedFrom: Michael Paquier <[email protected]>
To: Ashutosh Bapat <[email protected]>
Cc: Junwang Zhao <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: [BackendXidGetPid] only access allProcs when xid matches
Date: Fri, 8 Sep 2023 10:05:37 +0900
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAExHW5t90bD6az+8+xw1QWu=RnU0We-7NuUttRekA_KQyCU-ig@mail.gmail.com>
References: <CAEG8a3+i9gtqF65B+g_puVaCQuf0rZC-EMqMyEjGFJYOqUUWfA@mail.gmail.com>
<CAExHW5v=aAXtKfKAaYx96t=VXFnkVuKShgCcD7n9-t7d=jT8=Q@mail.gmail.com>
<CAEG8a3+aSwYJ1qWDhF83KXCqYgqQ567ENAzdmUsDOPCh=h-guw@mail.gmail.com>
<CAExHW5voH=E3N3n8fWn03O5BaNZGwnM83XZLc3U4hEsP=jpMhg@mail.gmail.com>
<CAEG8a3JUYLmD5N-3JTtHq1EtsKGhwFVg7JZU6dgS3xwzJFOgTQ@mail.gmail.com>
<CAExHW5v3w23oycGkUCKUcRU50-8+nE8u3uWW9mNNOxbBtq8Qow@mail.gmail.com>
<CAExHW5tNXRgX0LS283CpegqEiS5xRbYvqGiqQu1BUwbU9+d2_g@mail.gmail.com>
<CAEG8a3KtuaH4Zsfz1a=J9ctsCRWU8c3XJEFUKmqZpkDVSqQ=Tg@mail.gmail.com>
<CAExHW5t90bD6az+8+xw1QWu=RnU0We-7NuUttRekA_KQyCU-ig@mail.gmail.com>
On Thu, Sep 07, 2023 at 04:34:20PM +0530, Ashutosh Bapat wrote:
> I would still love to see some numbers. It's not that hard. Either
> using my micro benchmark or Michael's. We may or may not see an
> improvement. But at least we tried. But Michael feels otherwise,
> changing it to RoC is fine.
I have hardcoded a small SQL function that calls BackendXidGetPid() in
a tight loop a few hundred millions of times, and I see no difference
in runtime between HEAD and the patch under -O2. The argument about
readability still applies for me, so applied.
--
Michael
Attachments:
[application/pgp-signature] signature.asc (833B, ../[email protected]/2-signature.asc)
download
view thread (3+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected]
Subject: Re: [BackendXidGetPid] only access allProcs when xid matches
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox