Feedback-ID: i0fe9450f:Fastmail
Date: Fri, 22 Sep 2023 14:21:46 +0900
From: Michael Paquier <michael@paquier.xyz>
To: David Rowley <dgrowleyml@gmail.com>
Cc: Ryoga Yoshida <bt23yoshidar@oss.nttdata.com>,
	pgsql-hackers@lists.postgresql.org
Subject: Re: Bug fix in vacuumdb --buffer-usage-limit xxx -Z
Message-ID: <ZQ0kanW9OGJYymWs@paquier.xyz>
References: <08930c0b541700a5264e5fbf3a685f5a@oss.nttdata.com>
 <CAApHDvqRHeik_F8egXCQZXXnRgjj-Wg2rLsds1Kx-efv_1bYnA@mail.gmail.com>
 <CAApHDvqrfvwJy1g7bwBQgr9uTJU9e4OEtiLLDVfNuPmjB3+QFw@mail.gmail.com>
 <ZQvbvSygEe3aLUev@paquier.xyz>
 <CAApHDvok_7zMMjDj-zcze+monKD8AQe5LpqgZ6U1PaPrvcnE8A@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="RyTd63GSJZlQ6ZuP"
Content-Disposition: inline
In-Reply-To: 
 <CAApHDvok_7zMMjDj-zcze+monKD8AQe5LpqgZ6U1PaPrvcnE8A@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/ZQ0kanW9OGJYymWs%40paquier.xyz>
Precedence: bulk


--RyTd63GSJZlQ6ZuP
Content-Type: multipart/mixed; boundary="YvYCb8YZ2yTmffDV"
Content-Disposition: inline


--YvYCb8YZ2yTmffDV
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Sep 21, 2023 at 06:56:29PM +1200, David Rowley wrote:
> I deem it pretty unlikely that someone will accidentally remove the
> code that I just committed and a test to test that vacuumdb -Z
> --buffer-usage-limit ... passes the BUFFER_USAGE_LIMIT option would
> likely just forever mark that we once had a trivial bug that forgot to
> include the --buffer-usage-limit when -Z was specified.

Perhaps so.

> If others feel strongly that a test is worthwhile, then I'll reconsider.

I don't know if you would like that, but the addition is as simple as
the attached, FYI.
--
Michael

--YvYCb8YZ2yTmffDV
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment; filename="vacuumdb-tests.patch"

diff --git a/src/bin/scripts/t/100_vacuumdb.pl b/src/bin/scripts/t/100_vacuumdb.pl
index eccfcc54a1..597bbd8f54 100644
--- a/src/bin/scripts/t/100_vacuumdb.pl
+++ b/src/bin/scripts/t/100_vacuumdb.pl
@@ -40,6 +40,10 @@ $node->issues_sql_like(
 	[ 'vacuumdb', '--disable-page-skipping', 'postgres' ],
 	qr/statement: VACUUM \(DISABLE_PAGE_SKIPPING, SKIP_DATABASE_STATS\).*;/,
 	'vacuumdb --disable-page-skipping');
+$node->issues_sql_like(
+	[ 'vacuumdb', '--buffer-usage-limit', '0', 'postgres' ],
+	qr/statement: VACUUM \(SKIP_DATABASE_STATS, BUFFER_USAGE_LIMIT '0'\).*;/,
+	'vacuumdb --buffer-usage-limit');
 $node->issues_sql_like(
 	[ 'vacuumdb', '--skip-locked', 'postgres' ],
 	qr/statement: VACUUM \(SKIP_DATABASE_STATS, SKIP_LOCKED\).*;/,
@@ -48,6 +52,10 @@ $node->issues_sql_like(
 	[ 'vacuumdb', '--skip-locked', '--analyze-only', 'postgres' ],
 	qr/statement: ANALYZE \(SKIP_LOCKED\).*;/,
 	'vacuumdb --skip-locked --analyze-only');
+$node->issues_sql_like(
+	[ 'vacuumdb', '--buffer-usage-limit', '0', '--analyze-only', 'postgres' ],
+	qr/statement: ANALYZE \(BUFFER_USAGE_LIMIT '0'\).*;/,
+	'vacuumdb --buffer-usage-limit --analyze-only');
 $node->command_fails(
 	[ 'vacuumdb', '--analyze-only', '--disable-page-skipping', 'postgres' ],
 	'--analyze-only and --disable-page-skipping specified together');

--YvYCb8YZ2yTmffDV--

--RyTd63GSJZlQ6ZuP
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmUNJGoACgkQnvQgOdby
QH3U9Q/7BRlcdzUA9l3MxwYm14SpTS2fnXBV8JXsgNW1hZ6d+jY0VNUuMN/dA+04
fXC6JjJV9QbjdVbkpFeJ8TAZQ9SG6wD3MN2rv8gqeTJMbTA3knE7NzorGdFQsQFK
NOaB5DO18wYOI0on/9zuY/Iv6Sy3j5MRZaPIoFRnSk8g3LN/uANQc7wr6MLc3PMK
lz0El8g7NYNgL6yzKUiygp68dIX5Mlt5rEZCDLUivr8yyRVlzOMedE8MY0T989g4
18hQ1RebaP8ZVhm4RqEJ8K8ET9/oF9rXeQ7ssVmGIxV0LTPL077qmLab9nHuf10u
KF4wY6nA2flwPmggMWmHo+HFBds5b00H3hA7wUVR4OKRmkN3RpKkwJFLg5llyJkj
qDD8GsSHwLY2JUC/Bnu2/NxZtAWgHWkeughSXzXxk+KMJ0I4wvc5GrJh1U5g9JoO
M5Wu05Z6PRcG5hi8Ut0Ge+XpTIwn7e7ePdUn+SrIrSQpUAMVT15zmepAb1SZpHyi
Fq9mjoCU/rDMaFkK4N6pM1WP/1jmW57o9KK+EqHsdNDFNNVJMV7geH5ZyNj81afb
gMMSlvQoxlRKrCAJipUalv+vDYQb43iEU3yTLXYdwIBPYhNHbLOwAMkyIoZP0vjT
g3yQihp6t582vgY3bbcjplXLGdulUH/k2dv7xes40dAM9UHWq9Q=
=zf2R
-----END PGP SIGNATURE-----

--RyTd63GSJZlQ6ZuP--