Feedback-ID: i0fe9450f:Fastmail
Date: Thu, 14 Sep 2023 16:56:03 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Peter Eisentraut <peter@eisentraut.org>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Quoting filename in using facing log messages
Message-ID: <ZQK8k11sFEz64c8T@paquier.xyz>
References: <080EEABE-6645-4A46-AB20-6285ADAC44FE@yesql.se>
 <7bc486db-9888-7d23-2cae-6068b506785f@eisentraut.org>
 <EFFD4A1E-73A4-4616-9CC5-84FA25399F6F@yesql.se>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="PqohS23aTQgx1Yr7"
Content-Disposition: inline
In-Reply-To: <EFFD4A1E-73A4-4616-9CC5-84FA25399F6F@yesql.se>
Archived-At: <https://www.postgresql.org/message-id/ZQK8k11sFEz64c8T%40paquier.xyz>
Precedence: bulk


--PqohS23aTQgx1Yr7
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Sep 13, 2023 at 02:02:47PM +0200, Daniel Gustafsson wrote:
> It might be worth concatenating the errmsg() while there since we typical=
ly
> don't linebreak errmsg strings anymore for greppability:
>=20
> -	 errmsg("could not write to log file %s "
> -		"at offset %u, length %zu: %m",
> +	 errmsg("could not write to log file \"%s\" at offset %u, length %zu: %=
m",
>=20
> I don't have strong feelings wrt that, just have a vague memory of "conca=
tenate
> when touching" as an informal guideline.

Because these are slightly easier to grep when looking for a given
pattern in the tree.

(I'm OK with your patch as well, FWIW.)
--
Michael

--PqohS23aTQgx1Yr7
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmUCvJMACgkQnvQgOdby
QH3X2w/+LJMpImOBoCLOL7kA4TY4Kf915wmIeylntApJdyQ49YAQCEBo13ar2Vae
mjnT9xP0XKsfb7D4+Cp2j7ROrPHCRCcLCgu8mYcmkNZLEyWYbS2mscqOZPDFeuqZ
jTICQDXdFOS2pFRmYjq2PkSBGkQ0JniI3AryhQoECgCR+LfGQOAfGJsu/XjOUx17
g7u40t3+sE8AhEcJkqwjjjY0HtK6PGqUhpzf1UNKbi70ubJBXA4eZ127hH0s60Jb
w1LgdDpThfrzpcm4ADpWNCO9iA5gQMq56zQBSovEgUIeU1h9esFaIU0u/IY05Thu
KpkrcLprf1t8Zax5W70wCzokg9sAZ8QADHW48vi3GEozp3jSQw1uzRsVIEoZJ2B0
07i+S/4wBKRwxkNXEuEw3ujAGNS7Vf//Ae0p/3Ep84p5QRdzMMgJ6vWF4gcQJaUU
/7TGpi4lhVjUYpWMKAXaY7YksVxdir3qg94ovD382XdxWjxOoRuQWKYlpmvPOK0v
WQlmViaCYW8gdr5AV7DHaryrY/l0lsz7S1QaNtupo5bE63fsW6OMm/hxdo/hbT/o
Eisako5iBB+cIwhv95OaQyFmdfm+xa2ryycMOZ0eW8/YZeF2kGpRzdTje3R/WHxf
5OcW3UqQ/rGXucEAhQtAXwWyacA8R3lzAjDMKql4lt10qeaGoN4=
=wyAY
-----END PGP SIGNATURE-----

--PqohS23aTQgx1Yr7--