Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qgvlH-000JhB-Dc for pgsql-hackers@arkaria.postgresql.org; Thu, 14 Sep 2023 23:28:40 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1qgvlG-00BRqX-Ac for pgsql-hackers@arkaria.postgresql.org; Thu, 14 Sep 2023 23:28:38 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qgvlE-00BRo1-TP for pgsql-hackers@lists.postgresql.org; Thu, 14 Sep 2023 23:28:37 +0000 Received: from out1-smtp.messagingengine.com ([66.111.4.25]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qgvlB-004bRn-Km for pgsql-hackers@lists.postgresql.org; Thu, 14 Sep 2023 23:28:35 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id E397D5C01B0; Thu, 14 Sep 2023 19:28:31 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Thu, 14 Sep 2023 19:28:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1694734111; x=1694820511; bh=md y+lKLpGeZDGvOfp3zIIkWB6iJsZnG8V8e/dpLso5Y=; b=kVYEIGsqHw0YCbaBPp 1p2CFvlvm3tfc4hq7XKSvyPmVJuTs72O0j7VHzN955aaGrAehJBnPVKNJZV8rW9g 4ZLngCPB4pBzo4WbKrwYdvskvMHERLUpib4CKzFXT/6F5iGjOM1Kv4mai6q0BZhi ksKvlKdKmIX4Zu2u3uTJfKt5vE4GEHqnomVBoqKaQKyhh4w1YGvFNzIdlfHdXGtN +gIow54glepC64LZ/eq/pcGOfa7xi52WisA1nSeGvDCfSKHd3Q/nJSfgebnpbjDh bYBiWskr4jmFH2NkOG6uAAOFEKTiJD9W5clgPLSeQKUUFlJ9d3HofM7rv5yXmB1N vCNQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1694734111; x=1694820511; bh=mdy+lKLpGeZDG vOfp3zIIkWB6iJsZnG8V8e/dpLso5Y=; b=nrFfvGPlINK2J+o30NAiwLTM/zwMQ YZRYeoshNoxBAfl0RjCM/zbi+gJA9KnBzS97mKELrdWX62MPJq+2AsX5XGR56bDK 8BrknOQSwgJCtuf+RL9DMlZsGMuaPWktQ9hlTJ5XfNWYUeiFrXWIiRg9oho1W1kh vpvFcqC8yDHbyPAZ+OOB91Pn+ukTfPW8TiJd3nzSLweSePFsOvKJnfP/N0/YKJ4h NYWsrfDRLhGZpPH82uNaE8cWd8iAqRlh61fvYLEBrdFu53aQW6tUgPRIFNuqkmJv C6WGUXmRtt76+xAw+uZ8K28/Qy7zTVVBRsnAd9zJqZi/8O9sVtYq7Eshw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrudejuddgvdefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne gfrhhlucfvnfffucdljedtmdenucfjughrpeffhffvvefukfhfgggtuggjsehgtderredt tddvnecuhfhrohhmpefoihgthhgrvghlucfrrghquhhivghruceomhhitghhrggvlhesph grqhhuihgvrhdrgiihiieqnecuggftrfgrthhtvghrnhepteelieefudffhffhtdetleeg geegfffhkeeuveetiefgudduvedutefggeeivdejnecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomhepmhhitghhrggvlhesphgrqhhuihgvrhdrgiih ii X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 14 Sep 2023 19:28:30 -0400 (EDT) Date: Fri, 15 Sep 2023 08:28:26 +0900 From: Michael Paquier To: Jim Jones Cc: PostgreSQL Hackers , David Zhang Subject: Re: [PATCH] Add inline comments to the pg_hba_file_rules view Message-ID: References: <4d623899-36ac-71b5-311d-2a4672d75736@uni-muenster.de> <381eb298-92b3-9599-abe6-f04c9a151248@uni-muenster.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="E29RFuS35+DYriVH" Content-Disposition: inline In-Reply-To: <381eb298-92b3-9599-abe6-f04c9a151248@uni-muenster.de> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --E29RFuS35+DYriVH Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Sep 14, 2023 at 01:33:04PM +0200, Jim Jones wrote: > Just to make sure I got what you have in mind: you suggest to read the > pg_hba.conf a second time via a new (generic) function like pg_read_file() > that returns line numbers and their contents (+comments), and the results of > this new function would be joined pg_hba_file_rules in SQL. Is that correct? Yes, my suggestion was to define a new set-returning function that takes in input a file path and that returns as one row one comment and its line number from the configuration file. -- Michael --E29RFuS35+DYriVH Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmUDlxkACgkQnvQgOdby QH2ieg/+PTrBVr+G/aOwQ5HAUX1VaZZLSRIwWuY3bK1zcCFBXMUq3/5hElGoO17x nJkgwI1fYKDbKqXWZWW5YqN30/FnZFhmnTp4HMlDoaI9PTUxvtcmMRQVThYInkfX 8Ls3XveYCBEZKgHmTNtyzvFIjSRIGD5YqJMsDctXiC4vxjxv4nW4Xhm3jcAk4E8F 3QGK+F55kJc2TxRzayo9BWxP9b1t3xEoiYZdf5w0kzWmmbZ7ACI2XLTnso1RlxXC 4rq/IUvNT8bSLhRhAjH3EC8gmUwCdi8ozaMFdwyBfXA1/CJISHnh7ArpmEe7/2/A Az1yGL8Tg6XWpLWmCZvZ27AKJx2BD0HKuyCiOpBDSFIX2yPVqJXfaPsAT+AUe3lB PIAWZScpcj5+ZbSoy2ON5RCH4Qi8VX6Qyxg1QedO1VmCA0i/vRT2A37wHyNHgixT pM3LfMWY/defRnx8WDxfEE0QuAvar+6nRy3sPH4DXbQ628FeKnTkqbTmt+h9PVJa 007AOA3o77s4wV9t21+kJmRQXxA2EDMZvvUsK2wfO0dxE3qGzZ5pn7NsHXxH8kRp 5zSju0adgqPdzldpB6kx9hWRUFilYPDN6RjLHBeS9cIvRAItRAF9wvcH+abCiHBA zxRBxFo9sW+CSBE8V+ayr7dXOSD8bRK37kTMRmQRcreGLhxggnU= =//RS -----END PGP SIGNATURE----- --E29RFuS35+DYriVH--