Feedback-ID: i0fe9450f:Fastmail
Date: Sat, 16 Sep 2023 13:18:41 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Jim Jones <jim.jones@uni-muenster.de>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
	David Zhang <david.zhang@highgo.ca>
Subject: Re: [PATCH] Add inline comments to the pg_hba_file_rules view
Message-ID: <ZQUsoaxQhDFcvmkZ@paquier.xyz>
References: <4d623899-36ac-71b5-311d-2a4672d75736@uni-muenster.de>
 <ZP5ELFdn28Hn1Hfi@paquier.xyz>
 <381eb298-92b3-9599-abe6-f04c9a151248@uni-muenster.de>
 <ZQOXGj3aBin3uLO0@paquier.xyz>
 <b63625ca-580f-14dc-7e7c-f90cd4d95cf7@uni-muenster.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="9K8TSUV1CY+pIUF+"
Content-Disposition: inline
In-Reply-To: <b63625ca-580f-14dc-7e7c-f90cd4d95cf7@uni-muenster.de>
Archived-At: <https://www.postgresql.org/message-id/ZQUsoaxQhDFcvmkZ%40paquier.xyz>
Precedence: bulk


--9K8TSUV1CY+pIUF+
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Sep 15, 2023 at 09:37:23AM +0200, Jim Jones wrote:
> SELECT type, database, user_name, address, c.comment
> FROM=A0 pg_hba_file_rules h, pg_read_conf_comments(h.file_name) c
> WHERE user_name[1]=3D'jim' AND h.line_number =3D c.line_number ;
>=20
> =A0type | database | user_name |=A0 address=A0 | comment
> ------+----------+-----------+-----------+---------
> =A0host | {db}=A0=A0=A0=A0 | {jim}=A0=A0=A0=A0 | 127.0.0.1 | foo
> =A0host | {db}=A0=A0=A0=A0 | {jim}=A0=A0=A0=A0 | 127.0.0.1 | bar
> =A0host | {db}=A0=A0=A0=A0 | {jim}=A0=A0=A0=A0 | 127.0.0.1 | #foo#
> (3 rows)
>=20
>=20
> Is it more or less what you had in mind?

That was the idea.  I forgot about strpos(), but if you do that, do we
actually need a function in core to achieve that?  There are a few
fancy cases with the SQL function you have sent, actually..  strpos()
would grep the first '#' character, ignoring quoted areas.
--
Michael

--9K8TSUV1CY+pIUF+
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmUFLKEACgkQnvQgOdby
QH1Vmg//VjBzT63OvxyAlSQwzQD/1eBv7/a3/71n2vu3YV9v0HnEh5dHUBdkb4kP
/NTOGH2Erls7KpiVt4iiat7wXYLUa7YFbI4DKBcBoWBWrwwQBjlea3zEMQlC8J4t
mmoXaj910FnE1Rhojw4ttRbVVMxbm/CkmDPYcpgFF5oE7P2TwVv796NA1mfQPbB+
9YrKbuyyGQso4M3WyoYKzWLHFMXSSwpzhITAWoUvFu6vJvV+DOIqJ8JOvcfoqM+0
Cci4kktFfPr7vdaV6cORlMLtnxB404g+92dWHurzLqZHr0eQ4BgQJ7PtZFRE3PI5
O3vhFTdoEb4Okzllrd0Y/y5eaB7sPW+cRtANjSoLCvhNGeU741nIHqNIMD/wOo3G
aHb5dCwieep0MoHeZoepND74kehpVZ5riA6s0yuvFpoZFo4JV9WK8/X7qaLW+hjn
WPfop10+eyWSIG/ADomX3ex1Vp3m6zA8nnhsss/37dxE7NiOPSgAeThxgci/0wJ4
Hfw+zZQpIuOImWt+huw7hACnlfGa+QB3PG+Zw6c3nWjSdJobhum+ecNj/3w+vN/B
hN0HHsndIn5OzO1KakrA9JeaweObENMVDucPYFSaIEQl6T+1mDffwE9SQG+sYYmC
Q4Bte5Em8RgAxDA6snzHcLSnewBDk3eOzZj6+fXWh7d5EBEDuJk=
=pt3Y
-----END PGP SIGNATURE-----

--9K8TSUV1CY+pIUF+--