Feedback-ID: i0fe9450f:Fastmail
Date: Thu, 21 Sep 2023 11:32:57 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Ryoga Yoshida <bt23yoshidar@oss.nttdata.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Bug fix in vacuumdb --buffer-usage-limit xxx -Z
Message-ID: <ZQurWbkV9KJ96LSf@paquier.xyz>
References: <08930c0b541700a5264e5fbf3a685f5a@oss.nttdata.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="dlJFgKwXYTwbJERS"
Content-Disposition: inline
In-Reply-To: <08930c0b541700a5264e5fbf3a685f5a@oss.nttdata.com>
Archived-At: 
 <https://www.postgresql.org/message-id/ZQurWbkV9KJ96LSf%40paquier.xyz>
Precedence: bulk


--dlJFgKwXYTwbJERS
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Sep 21, 2023 at 10:44:49AM +0900, Ryoga Yoshida wrote:
> When --buffer-usage-limit option is specified, vacuumdb issues VACUUM or
> VACUUM ANALYZE command with BUFFER_USAGE_LIMIT option. Also if
> --buffer-usage-limit and -Z options are specified, vacuumdb should issue
> ANALYZE command with BUFFER_USAGE_LIMIT option. But it does not. That is,
> vacuumdb -Z seems to fail to handle --buffer-usage-limit option. This see=
ms
> a bug.
>=20
> You can see my patch in the attached file and how it works by adding -e
> option in vacuumdb.

Good catch, indeed the option is missing from the ANALYZE commands
built under analyze_only.  I can also notice that we have no tests for
this option in src/bin/scripts/t checking the shape of the commands
generated.  Could you add something for ANALYZE and VACUUM?  The
option could just be appended in one of the existing cases, for
instance.
--
Michael

--dlJFgKwXYTwbJERS
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmULq1kACgkQnvQgOdby
QH1Y6g/9E4EY+OirhqEhx/ybZKRwHuqJpn3oc5T2vPtMDw+Rn8I5OdKcAP85UoOY
Kx1IsI947T1rE5305bB+91hZ+4HR8RvpNQoPSMTvOZDmb1ymGI5hWvkJFohHe+wI
EsAb4KdUeZPmmhaQ7zUC7QOAE9897gmehpOIzyXvIT2gkEEJpu5twMsdS/dpw2zR
sO1gdFhOPYuVi71MuIl90Gd5fhJvbSOVj4nmWBcJeqTBMi5jTaOEgG1H9O4eEwRn
+Dj1cAlcDr2F8dUWfoILeH6whDaLM+EVEsBRs/WsftxPns0MbNJaIvegWnZ1CfZJ
YK08/0qJwCqwtpXacqERlDk/pJPyCT3b7fQTrHltg+eTTzZrgPPyQSDLGnBHleSH
sE/nqoUvsCwgzWuATun83aIYGVS0dbc3RE0L2ktjX/QgW8f6JLZgpU6IHfsuBmg+
Y3pvUfWjckNcMktYOHV3RUF6WvPBOqZgv/fplC+0qGdZExrcFSVj4ZyyyJEECE6c
N3L8YRoSRh2v4EZ+kjELnP3rg5KKR0kPm9e4Qx46GDBwSVfmt21ZebJi+4aLmwPy
9ad8pyq2pArR1vnbJtAm39GqrzFOCRSVDesRI3P8OJZ0xME9VO9BetNHmEL/OBi5
71Hh8nFlubcppz9kw8DD3NEmlgjEf8jvbb2x4CkQNRTKaiPNSGw=
=QisO
-----END PGP SIGNATURE-----

--dlJFgKwXYTwbJERS--