Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qjCit-009pKy-GB for pgsql-hackers@arkaria.postgresql.org; Thu, 21 Sep 2023 05:59:35 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1qjCir-008ok7-JV for pgsql-hackers@arkaria.postgresql.org; Thu, 21 Sep 2023 05:59:33 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qjCir-008ojg-9O for pgsql-hackers@lists.postgresql.org; Thu, 21 Sep 2023 05:59:33 +0000 Received: from out5-smtp.messagingengine.com ([66.111.4.29]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qjCio-005kyL-Iq for pgsql-hackers@lists.postgresql.org; Thu, 21 Sep 2023 05:59:31 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 058025C0254; Thu, 21 Sep 2023 01:59:30 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Thu, 21 Sep 2023 01:59:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1695275970; x=1695362370; bh=Hf xR4bmSx+LhEqm3XnvwjRgVqHIUEon4UFewsc/YypQ=; b=RqBO2N8y54RbQLMTv2 gL8ufJH0GIWVyocGIoVLomdSlkqi2tfH55mqsnpbLwUdenImJD/wUIBIIYr1v7K3 cpU/Rf94e+hvMpS6mHWHeK0deEqRjvbA3qCaJLAn8BJamjdRKpIb3p3kZrm2uzfQ ONG1HSowsnmzV7dTZVdPWbhSlG0CqQIiBdo7B1ddJ1EQty38YBax9Y3J4jprojnH gtkt+g0JBwoDf0mFW7KVwaKh+HZHrzdJt7KeLYlwo9ORsJio1OQ43kaJw8JMMk6x jF31KJ5351MedPT7dbt49eyuIJM70OHjjM7kUqUwEtZh9i4Gy5Ayt65anrYfyem8 CtBA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1695275970; x=1695362370; bh=HfxR4bmSx+LhE qm3XnvwjRgVqHIUEon4UFewsc/YypQ=; b=mQfGJDx083oDaD8zAp6TPPvERRKiM 7x/l7KJ+4VqCK3XSqgBFdJNWL6IyzoqMLkjK2HCbk0QOnkigo4VvhMJBDXqySzmd 6MrnlsXls4z/3wuA1Wg9OAMVODMZooKmzis/t7ICr24Y7EEafVTSRM40IGgMt49l aAn0KtZGHZAjoGbsBG7rESCpb0kOYLv+0mszWUiETusoCDrazD2bFYxcaTDUWJl3 5JLhjYWsOEbSAukz1vZbuEGoqzuWQdfCcu9xKV7zg1fb++FmRjox2hwO7IWIPflo Rh6H9XtvJx2MK+m2YAB9UqFoJ+vxvYSJ0dvQl8Bq5oA3u/5S7iyAcPwGA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrudekhedgfeefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucgfrhhlucfvnfffucdljedtmdenucfjughrpeffhf fvvefukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpefoihgthhgrvghlucfrrghq uhhivghruceomhhitghhrggvlhesphgrqhhuihgvrhdrgiihiieqnecuggftrfgrthhtvg hrnhepteelieefudffhffhtdetleeggeegfffhkeeuveetiefgudduvedutefggeeivdej necuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhhitg hhrggvlhesphgrqhhuihgvrhdrgiihii X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 21 Sep 2023 01:59:27 -0400 (EDT) Date: Thu, 21 Sep 2023 14:59:25 +0900 From: Michael Paquier To: David Rowley Cc: Ryoga Yoshida , pgsql-hackers@lists.postgresql.org Subject: Re: Bug fix in vacuumdb --buffer-usage-limit xxx -Z Message-ID: References: <08930c0b541700a5264e5fbf3a685f5a@oss.nttdata.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="qEGazs8Dfv8YpfgD" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --qEGazs8Dfv8YpfgD Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Sep 21, 2023 at 05:50:26PM +1200, David Rowley wrote: > I've pushed your patch plus some additional code to escape the text > specified in --buffer-usage-limit before passing it to the server in > commit 5cfba1ad6 That was fast. If I may ask, why don't you have some regression tests for the two code paths of vacuumdb that append this option to the commands generated for VACUUM and ANALYZE? -- Michael --qEGazs8Dfv8YpfgD Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmUL270ACgkQnvQgOdby QH0RBA//XtpHrTTspPqj/yFMgB31PKdFxsz6yRgFoAZxfSSVt4ICvCM8T/ANEc1c Jn2aeVcyb19dSivLqBca68gVxvZcAS2ZXeo3rgFQINuhrA2ai+/3ciVK1TD/AmCC Fu4+IPKtuzURo8hdF9oXPG188V6LvcwzkKIgWJ5u+qEYg0ykyZmUwJ7ZWZ7M7Pv6 QtHAoPQOctK5nioi9ybQcSc30w3u9fPGhJEDc0JvuZ839nZuid0wakGGqhrSwRns uQVsfZDEsxhrHiNZ62g+8l8RotkLcwnBNiSTWJaqxtqnmF9gHJ8NkkWqHc17mXP9 mQ62mPd/WzG5Sfen74v9fgWAXeu1LAFOiIdRZejaErDboc+54YuXJnB8FILExOE0 lbUA9C/jfH9CccV9IKybGD7z4tQrj2ZQGp7oEJbl2mFAt8hIBEVN/xxH16MNovc0 gTotx/oS/ZGVqHLnHoVcj+t4GbZUUvH0gUgg2ALZJHhavxCfm4+jatAMJXgBXXRL kUU1zlzlLEbUNu3xtEwu6vzYRIRvIWv9m+bYBxCq635H9wuRQMsr6FR7pHqAm8TQ OQl0xMFpFeY16FXAixAswpPD6HDn7JpeEfu9G6NZZurRIDQNqN7dfPW+d6Wqer6Q 18aGTuHjjDPrteM4EMjrBmpXfZZaXgChZcrtvzwYw4lI+ypYHhg= =xYBV -----END PGP SIGNATURE----- --qEGazs8Dfv8YpfgD--