public inbox for [email protected]help / color / mirror / Atom feed
[PATCH 3/4] Use correct 'statistics kind' in a couple places 6+ messages / 3 participants [nested] [flat]
* [PATCH 3/4] Use correct 'statistics kind' in a couple places @ 2021-03-07 00:38 Tomas Vondra <[email protected]> 0 siblings, 0 replies; 6+ messages in thread From: Tomas Vondra @ 2021-03-07 00:38 UTC (permalink / raw) A couple places used 'statistic kind' which is inconsistent, so use 'statistics kind' consistently. --- doc/src/sgml/catalogs.sgml | 2 +- src/backend/statistics/dependencies.c | 2 +- src/backend/statistics/extended_stats.c | 2 +- src/backend/statistics/mcv.c | 2 +- src/backend/statistics/mvdistinct.c | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/doc/src/sgml/catalogs.sgml b/doc/src/sgml/catalogs.sgml index b1de6d0674..64601d6b24 100644 --- a/doc/src/sgml/catalogs.sgml +++ b/doc/src/sgml/catalogs.sgml @@ -7358,7 +7358,7 @@ SCRAM-SHA-256$<replaceable><iteration count></replaceable>:<replaceable>&l <structfield>stxkind</structfield> <type>char[]</type> </para> <para> - An array containing codes for the enabled statistic kinds; + An array containing codes for the enabled statistics kinds; valid values are: <literal>d</literal> for n-distinct statistics, <literal>f</literal> for functional dependency statistics, and diff --git a/src/backend/statistics/dependencies.c b/src/backend/statistics/dependencies.c index f6e399b192..eac9285165 100644 --- a/src/backend/statistics/dependencies.c +++ b/src/backend/statistics/dependencies.c @@ -639,7 +639,7 @@ statext_dependencies_load(Oid mvoid) Anum_pg_statistic_ext_data_stxddependencies, &isnull); if (isnull) elog(ERROR, - "requested statistic kind \"%c\" is not yet built for statistics object %u", + "requested statistics kind \"%c\" is not yet built for statistics object %u", STATS_EXT_DEPENDENCIES, mvoid); result = statext_dependencies_deserialize(DatumGetByteaPP(deps)); diff --git a/src/backend/statistics/extended_stats.c b/src/backend/statistics/extended_stats.c index a030ea3653..8c05e10d0c 100644 --- a/src/backend/statistics/extended_stats.c +++ b/src/backend/statistics/extended_stats.c @@ -64,7 +64,7 @@ typedef struct StatExtEntry char *schema; /* statistics object's schema */ char *name; /* statistics object's name */ Bitmapset *columns; /* attribute numbers covered by the object */ - List *types; /* 'char' list of enabled statistic kinds */ + List *types; /* 'char' list of enabled statistics kinds */ int stattarget; /* statistics target (-1 for default) */ } StatExtEntry; diff --git a/src/backend/statistics/mcv.c b/src/backend/statistics/mcv.c index abbc1f1ba8..8335dff241 100644 --- a/src/backend/statistics/mcv.c +++ b/src/backend/statistics/mcv.c @@ -570,7 +570,7 @@ statext_mcv_load(Oid mvoid) if (isnull) elog(ERROR, - "requested statistic kind \"%c\" is not yet built for statistics object %u", + "requested statistics kind \"%c\" is not yet built for statistics object %u", STATS_EXT_DEPENDENCIES, mvoid); result = statext_mcv_deserialize(DatumGetByteaP(mcvlist)); diff --git a/src/backend/statistics/mvdistinct.c b/src/backend/statistics/mvdistinct.c index 9ef21debb6..e08c001e3f 100644 --- a/src/backend/statistics/mvdistinct.c +++ b/src/backend/statistics/mvdistinct.c @@ -153,7 +153,7 @@ statext_ndistinct_load(Oid mvoid) Anum_pg_statistic_ext_data_stxdndistinct, &isnull); if (isnull) elog(ERROR, - "requested statistic kind \"%c\" is not yet built for statistics object %u", + "requested statistics kind \"%c\" is not yet built for statistics object %u", STATS_EXT_NDISTINCT, mvoid); result = statext_ndistinct_deserialize(DatumGetByteaPP(ndist)); -- 2.26.2 --------------BCA1373AE29B32B57608F4EE Content-Type: text/x-patch; charset=UTF-8; name="0004-Extended-statistics-on-expressions-20210307.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0004-Extended-statistics-on-expressions-20210307.patch" ^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: Changing "Hot Standby" to "hot standby" @ 2022-03-03 01:24 Kyotaro Horiguchi <[email protected]> 2022-03-03 06:55 ` Re: Changing "Hot Standby" to "hot standby" Daniel Westermann (DWE) <[email protected]> 0 siblings, 1 reply; 6+ messages in thread From: Kyotaro Horiguchi @ 2022-03-03 01:24 UTC (permalink / raw) To: [email protected]; +Cc: [email protected]; [email protected] At Wed, 2 Mar 2022 15:22:44 +0000, "Daniel Westermann (DWE)" <[email protected]> wrote in > > Pretty sure that for titles we should keep English capitalization rules. > > Done like that. Thanks for taking a look. <para> - Hot Standby feedback propagates upstream, whatever the cascaded arrangement. + hot standby feedback propagates upstream, whatever the cascaded arrangement <para> - Hot Standby is the term used to describe the ability to connect to + hot standby is the term used to describe the ability to connect to They look like decapitalizing the first word in a sentsnce. regards. -- Kyotaro Horiguchi NTT Open Source Software Center ^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: Changing "Hot Standby" to "hot standby" 2022-03-03 01:24 Re: Changing "Hot Standby" to "hot standby" Kyotaro Horiguchi <[email protected]> @ 2022-03-03 06:55 ` Daniel Westermann (DWE) <[email protected]> 2022-03-03 07:17 ` Re: Changing "Hot Standby" to "hot standby" Kyotaro Horiguchi <[email protected]> 0 siblings, 1 reply; 6+ messages in thread From: Daniel Westermann (DWE) @ 2022-03-03 06:55 UTC (permalink / raw) To: Kyotaro Horiguchi <[email protected]>; +Cc: [email protected] <[email protected]>; [email protected] <[email protected]> Hi Kyotaro, >> <para> >>- Hot Standby is the term used to describe the ability to connect to >>+ hot standby is the term used to describe the ability to connect to >They look like decapitalizing the first word in a sentsnce. Thanks for having a look. Are you suggesting to change it like this? - Hot Standby is the term used to describe the ability to connect to + Hot standby is the term used to describe the ability to connect to Regards Daniel ^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: Changing "Hot Standby" to "hot standby" 2022-03-03 01:24 Re: Changing "Hot Standby" to "hot standby" Kyotaro Horiguchi <[email protected]> 2022-03-03 06:55 ` Re: Changing "Hot Standby" to "hot standby" Daniel Westermann (DWE) <[email protected]> @ 2022-03-03 07:17 ` Kyotaro Horiguchi <[email protected]> 2022-03-03 07:32 ` Re: Changing "Hot Standby" to "hot standby" Daniel Westermann (DWE) <[email protected]> 0 siblings, 1 reply; 6+ messages in thread From: Kyotaro Horiguchi @ 2022-03-03 07:17 UTC (permalink / raw) To: [email protected]; +Cc: [email protected]; [email protected] At Thu, 3 Mar 2022 06:55:43 +0000, "Daniel Westermann (DWE)" <[email protected]> wrote in > Hi Kyotaro, > > >> <para> > >>- Hot Standby is the term used to describe the ability to connect to > >>+ hot standby is the term used to describe the ability to connect to > > >They look like decapitalizing the first word in a sentsnce. > > Thanks for having a look. Are you suggesting to change it like this? > - Hot Standby is the term used to describe the ability to connect to > + Hot standby is the term used to describe the ability to connect to Yes. Isn't it the right form of a sentence? regards. -- Kyotaro Horiguchi NTT Open Source Software Center ^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: Changing "Hot Standby" to "hot standby" 2022-03-03 01:24 Re: Changing "Hot Standby" to "hot standby" Kyotaro Horiguchi <[email protected]> 2022-03-03 06:55 ` Re: Changing "Hot Standby" to "hot standby" Daniel Westermann (DWE) <[email protected]> 2022-03-03 07:17 ` Re: Changing "Hot Standby" to "hot standby" Kyotaro Horiguchi <[email protected]> @ 2022-03-03 07:32 ` Daniel Westermann (DWE) <[email protected]> 2022-03-07 16:06 ` Re: Changing "Hot Standby" to "hot standby" Daniel Westermann (DWE) <[email protected]> 0 siblings, 1 reply; 6+ messages in thread From: Daniel Westermann (DWE) @ 2022-03-03 07:32 UTC (permalink / raw) To: Kyotaro Horiguchi <[email protected]>; +Cc: [email protected] <[email protected]>; [email protected] <[email protected]> >> Thanks for having a look. Are you suggesting to change it like this? >> - Hot Standby is the term used to describe the ability to connect to >> + Hot standby is the term used to describe the ability to connect to >Yes. Isn't it the right form of a sentence? Done like that. Regards Daniel Attachments: [text/x-patch] align_hot_standby_v3.patch (5.0K, ../../ZR0P278MB0920D09CEB18F6372A2D662AD2049@ZR0P278MB0920.CHEP278.PROD.OUTLOOK.COM/2-align_hot_standby_v3.patch) download | inline diff: diff --git a/doc/src/sgml/high-availability.sgml b/doc/src/sgml/high-availability.sgml index b5b6042104..ea10fe2be8 100644 --- a/doc/src/sgml/high-availability.sgml +++ b/doc/src/sgml/high-availability.sgml @@ -548,7 +548,7 @@ protocol to make nodes agree on a serializable transactional order. rollforward will take considerably longer, so that technique only offers a solution for disaster recovery, not high availability. A standby server can also be used for read-only queries, in which case - it is called a Hot Standby server. See <xref linkend="hot-standby"/> for + it is called a hot standby server. See <xref linkend="hot-standby"/> for more information. </para> @@ -1032,7 +1032,7 @@ primary_slot_name = 'node_a_slot' </para> <para> - Hot Standby feedback propagates upstream, whatever the cascaded arrangement. + Hot standby feedback propagates upstream, whatever the cascaded arrangement. </para> <para> @@ -1499,16 +1499,16 @@ synchronous_standby_names = 'ANY 2 (s1, s2, s3)' <title>Hot Standby</title> <indexterm zone="high-availability"> - <primary>Hot Standby</primary> + <primary>hot standby</primary> </indexterm> <para> - Hot Standby is the term used to describe the ability to connect to + Hot standby is the term used to describe the ability to connect to the server and run read-only queries while the server is in archive recovery or standby mode. This is useful both for replication purposes and for restoring a backup to a desired state with great precision. - The term Hot Standby also refers to the ability of the server to move + The term hot standby also refers to the ability of the server to move from recovery through to normal operation while users continue running queries and/or keep their connections open. </para> @@ -1623,7 +1623,7 @@ synchronous_standby_names = 'ANY 2 (s1, s2, s3)' being executed during recovery. This restriction applies even to temporary tables, because table rows cannot be read or written without assigning a transaction ID, which is currently not possible in a - Hot Standby environment. + hot standby environment. </para> </listitem> <listitem> @@ -1703,7 +1703,7 @@ synchronous_standby_names = 'ANY 2 (s1, s2, s3)' <para> In normal operation, <quote>read-only</quote> transactions are allowed to use <command>LISTEN</command> and <command>NOTIFY</command>, - so Hot Standby sessions operate under slightly tighter + so hot standby sessions operate under slightly tighter restrictions than ordinary read-only sessions. It is possible that some of these restrictions might be loosened in a future release. </para> @@ -1746,7 +1746,7 @@ synchronous_standby_names = 'ANY 2 (s1, s2, s3)' </para> <para> - There are also additional types of conflict that can occur with Hot Standby. + There are also additional types of conflict that can occur with hot standby. These conflicts are <emphasis>hard conflicts</emphasis> in the sense that queries might need to be canceled and, in some cases, sessions disconnected to resolve them. The user is provided with several ways to handle these @@ -1947,8 +1947,8 @@ synchronous_standby_names = 'ANY 2 (s1, s2, s3)' If <varname>hot_standby</varname> is <literal>on</literal> in <filename>postgresql.conf</filename> (the default value) and there is a <link linkend="file-standby-signal"><filename>standby.signal</filename></link><indexterm><primary>standby.signal</primary><secondary>for hot standby</secondary></indexterm> - file present, the server will run in Hot Standby mode. - However, it may take some time for Hot Standby connections to be allowed, + file present, the server will run in hot standby mode. + However, it may take some time for hot standby connections to be allowed, because the server will not accept connections until it has completed sufficient recovery to provide a consistent state against which queries can run. During this period, @@ -2282,7 +2282,7 @@ HINT: You can then restart the server after making the necessary configuration <title>Caveats</title> <para> - There are several limitations of Hot Standby. + There are several limitations of hot standby. These can and probably will be fixed in future releases: <itemizedlist> @@ -2299,7 +2299,7 @@ HINT: You can then restart the server after making the necessary configuration <para> Valid starting points for standby queries are generated at each checkpoint on the primary. If the standby is shut down while the primary - is in a shutdown state, it might not be possible to re-enter Hot Standby + is in a shutdown state, it might not be possible to re-enter hot standby until the primary is started up, so that it generates further starting points in the WAL logs. This situation isn't a problem in the most common situations where it might happen. Generally, if the primary is ^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: Changing "Hot Standby" to "hot standby" 2022-03-03 01:24 Re: Changing "Hot Standby" to "hot standby" Kyotaro Horiguchi <[email protected]> 2022-03-03 06:55 ` Re: Changing "Hot Standby" to "hot standby" Daniel Westermann (DWE) <[email protected]> 2022-03-03 07:17 ` Re: Changing "Hot Standby" to "hot standby" Kyotaro Horiguchi <[email protected]> 2022-03-03 07:32 ` Re: Changing "Hot Standby" to "hot standby" Daniel Westermann (DWE) <[email protected]> @ 2022-03-07 16:06 ` Daniel Westermann (DWE) <[email protected]> 0 siblings, 0 replies; 6+ messages in thread From: Daniel Westermann (DWE) @ 2022-03-07 16:06 UTC (permalink / raw) To: Kyotaro Horiguchi <[email protected]>; +Cc: [email protected] <[email protected]>; [email protected] <[email protected]> >>> Thanks for having a look. Are you suggesting to change it like this? >>> - Hot Standby is the term used to describe the ability to connect to >>> + Hot standby is the term used to describe the ability to connect to >>Yes. Isn't it the right form of a sentence? I've created and entry in the Commitfest 2022-07 for this. Regards Daniel ^ permalink raw reply [nested|flat] 6+ messages in thread
end of thread, other threads:[~2022-03-07 16:06 UTC | newest] Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2021-03-07 00:38 [PATCH 3/4] Use correct 'statistics kind' in a couple places Tomas Vondra <[email protected]> 2022-03-03 01:24 Re: Changing "Hot Standby" to "hot standby" Kyotaro Horiguchi <[email protected]> 2022-03-03 06:55 ` Re: Changing "Hot Standby" to "hot standby" Daniel Westermann (DWE) <[email protected]> 2022-03-03 07:17 ` Re: Changing "Hot Standby" to "hot standby" Kyotaro Horiguchi <[email protected]> 2022-03-03 07:32 ` Re: Changing "Hot Standby" to "hot standby" Daniel Westermann (DWE) <[email protected]> 2022-03-07 16:06 ` Re: Changing "Hot Standby" to "hot standby" Daniel Westermann (DWE) <[email protected]>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox