public inbox for [email protected]  

help / color / mirror / Atom feed

From: Daniel Westermann (DWE) <[email protected]>
To: PostgreSQL Hackers <[email protected]>
Subject: docs: Fix format of CREATE FOREIGN TABLE example in postgres_fdw
Date: Wed, 15 Apr 2026 09:27:01 +0000
Message-ID: <ZR2PPFF1830B8773AC9735393FFF93F8665D2222@ZR2PPFF1830B877.CHEP278.PROD.OUTLOOK.COM> (raw)

Hi,

while reading https://www.postgresql.org/docs/devel/postgres-fdw.html  I've noticed that there is a single bracket on one line of the CREATE FOREIGN TABLE example.

Browsing through other docs (e,g. https://www.postgresql.org/docs/devel/sql-createtable.html ) there doesn't seem to be a rule for that but if there is a single bracket (e.g. CREATE TABLE distributors), the options that follow usually start at position one and are not indented (or they follow directly after the bracket).

The examples in file_fdw (https://www.postgresql.org/docs/devel/file-fdw.html) follow a mix of options which directly follow the bracket and on a new line.

Attached a small patch which makes it looking a bit better, at least in my opinion.

Regards
Daniel


Attachments:

  [text/x-patch] fix-create-foreign-table-example-format.patch (624B, 3-fix-create-foreign-table-example-format.patch)
  download | inline diff:
diff --git a/doc/src/sgml/postgres-fdw.sgml b/doc/src/sgml/postgres-fdw.sgml
index b81f33732fb..bf54f8937c4 100644
--- a/doc/src/sgml/postgres-fdw.sgml
+++ b/doc/src/sgml/postgres-fdw.sgml
@@ -1470,9 +1470,9 @@ CREATE USER MAPPING FOR local_user
 CREATE FOREIGN TABLE foreign_table (
         id integer NOT NULL,
         data text
-)
-        SERVER foreign_server
-        OPTIONS (schema_name 'some_schema', table_name 'some_table');
+) 
+SERVER foreign_server
+OPTIONS (schema_name 'some_schema', table_name 'some_table');
 </programlisting>
 
    It's essential that the data types and other properties of the columns

view thread (4+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: docs: Fix format of CREATE FOREIGN TABLE example in postgres_fdw
  In-Reply-To: <ZR2PPFF1830B8773AC9735393FFF93F8665D2222@ZR2PPFF1830B877.CHEP278.PROD.OUTLOOK.COM>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox