Feedback-ID: i0fe9450f:Fastmail
Date: Mon, 25 Sep 2023 14:38:57 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Ryoga Yoshida <bt23yoshidar@oss.nttdata.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Doesn't pgstat_report_wal() handle the argument "force"
 incorrectly
Message-ID: <ZREc8dGx2EBlJx4x@paquier.xyz>
References: <f87a4d7be70530606b864fd1df91718c@oss.nttdata.com>
 <ZRDatnXJqlx46zV9@paquier.xyz>
 <2f6f68343fcd244ef7be5dfae8e55f63@oss.nttdata.com>
 <ZREC3d5Aya0KPbSl@paquier.xyz>
 <5adaf4e34fca5612ff506b47f6e81e47@oss.nttdata.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="s+UcC3czUn1+xN5q"
Content-Disposition: inline
In-Reply-To: <5adaf4e34fca5612ff506b47f6e81e47@oss.nttdata.com>
Archived-At: <https://www.postgresql.org/message-id/ZREc8dGx2EBlJx4x%40paquier.xyz>
Precedence: bulk


--s+UcC3czUn1+xN5q
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Sep 25, 2023 at 02:16:22PM +0900, Ryoga Yoshida wrote:
> On 2023-09-25 12:47, Michael Paquier wrote:
> in attached file
>> +	/* like in pgstat.c, don't wait for lock acquisition when !force */
>=20
> Isn't it the case with force=3Dtrue and !force that it doesn't wait for t=
he
> lock acquisition.  In fact, force may be false.

We would not wait on the lock if force=3Dfalse, which would do
nowait=3Dtrue.  And !force reads the same to me as force=3Dfalse.

Anyway, I am OK to remove this part.  That seems to confuse you, so
you may not be the only one who would read this comment.

Another idea would be to do like in pgstat.c by adding the following
line, then use "nowait" to call each sub-function:
nowait =3D !force;
pgstat_flush_wal(nowait);
pgstat_flush_io(nowait);
--
Michael

--s+UcC3czUn1+xN5q
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmURHPEACgkQnvQgOdby
QH2Klg/7BXgRGZfZBVUwBIVfjy/3ipibe9nP4R83EXXsGUrIAhVk3H9YntAbaRsD
gLYt36IkO0zOeDdBkAVqik3u5as/uOm0JYCmPbvqtDKNxurJqWvQuQbFPZWXlfjL
ZbwvrE+7O0K7lkoFlksaLHGrnwJ0zG5B+x3X14XhA7zFXW4P4gc887KyRggKzqSC
+bxBScPqgMh9FwjkWSv+zZNU21a08aExq5/vauCj0QNQmkUWsD9hH7XeYa++w/7d
epxYwbBQXLwKOV1SneOaIFPul9QwKAIMHpbAUrAIdw9/kmNeyACTfiL9Htjbj/X6
EiQQ/rjuljgzdy8qKlh/Opj46bsr8efxoJVPz/YanuRzz+fec/o/WY5WhDwOEOn8
tw1e1SRa/W3MZZ4d4YHFgpVkQOA5ra/ZbmGZhgYdABVcDUSg4a4L2S2YOw0bQi5W
EElB0jo10eOqwqGA07wmt7luV8hXa5/13zhjdRz3V/qXM7HmIrxCDXsXdhgYXLOx
T4bczKDVsm8e4k9+cMKssRrdmnRlqtOz11SbUkZCVPF1R55FHfvl2QVKu4QwI0DY
7MUhYwbE0sgSEoySKcyiiZs8KTB9duMslw/mqCwK58dSlAQ8u0jEI0nc+JFVuz9H
FzmvcbowTaWmajI/CFb6t5ggTOZndp9wLDqQZf+NsH0naK9XRmk=
=Kka2
-----END PGP SIGNATURE-----

--s+UcC3czUn1+xN5q--