Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qlFHg-001ugk-TR for pgsql-hackers@arkaria.postgresql.org; Tue, 26 Sep 2023 21:07:56 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1qlFHd-00F5Tu-Dr for pgsql-hackers@arkaria.postgresql.org; Tue, 26 Sep 2023 21:07:53 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qlFHd-00F5TZ-3A for pgsql-hackers@lists.postgresql.org; Tue, 26 Sep 2023 21:07:53 +0000 Received: from momjian.us ([72.94.173.45]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qlFHZ-007kvA-W2 for pgsql-hackers@postgresql.org; Tue, 26 Sep 2023 21:07:52 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=momjian.us; s=2023062407; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description; bh=RP+rJEtkoP6ci2ljV4oQ3w+9GFG2guVJ0c3KYcAhNhM=; b=NHu4Q YcVVoVP8yWdT1wW4CcScDJ9iIW/GwjMmxSVPI0mecRHcE8IBdW4SUluaHaco7pfah9KC0VstG/VOX MzH8e1JMwb5JBAuq++WxPi2MyTti1nqIB0OdBwdNPs67i7tKHr91O+ap6lgJSg7wnmENiYzvb93v+ pUbZiWNcvFESxGOoEbhFK8ZK7czXY2AYNFke7rVBfxhUxUhzEBzSgOjh4NtLMC5B+dbGfW0WpYp0C TTTybl2KJ/sXH7B/HmPXBMAGFuUEtQpCczDkpybErICpLNd9IoRecVP12tRFhbI2zkyrAojFs/yEs XlHXdT6NltsCMa14XAL7RKdPVYB2A==; Received: from bruce by momjian.us with local (Exim 4.96) (envelope-from ) id 1qlFHW-00GnHS-02; Tue, 26 Sep 2023 17:07:46 -0400 Date: Tue, 26 Sep 2023 17:07:45 -0400 From: Bruce Momjian To: Daniel Gustafsson Cc: Tom Lane , Nathan Bossart , Dagfinn Ilmari =?utf-8?Q?Manns=C3=A5ker?= , PostgreSQL Hackers Subject: Re: Obsolete reference to pg_relation in comment Message-ID: References: <87sf9apnr0.fsf@wibble.ilmari.org> <20230726205031.GD3310393@nathanxps13> <1948637.1690406048@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Thu, Sep 7, 2023 at 10:44:25AM +0200, Daniel Gustafsson wrote: > > On 6 Sep 2023, at 21:13, Bruce Momjian wrote: > > On Wed, Jul 26, 2023 at 05:14:08PM -0400, Tom Lane wrote: > > >> I think we should reword this to just generically claim that holding > >> the Relation reference open for the whole transaction reduces overhead. > > > > How is this attached patch? > > Reads good to me, +1. Patch applied to master. I didn't think backpatching it made much sense since it is so localized. -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you.