Date: Tue, 26 Sep 2023 19:44:44 -0400
From: Bruce Momjian <bruce@momjian.us>
To: David Rowley <dgrowleyml@gmail.com>
Cc: "Imseih (AWS), Sami" <simseih@amazon.com>, Tom Lane <tgl@sss.pgh.pa.us>,
	Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
	"pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Subject: Re: Correct the documentation for work_mem
Message-ID: <ZRNs7O5VH1IOy24h@momjian.us>
References: <66590882-F48C-4A25-83E3-73792CF8C51F@amazon.com>
 <d4052199-0f74-da33-9b5e-2250aea05edd@enterprisedb.com>
 <3363505.1682097301@sss.pgh.pa.us>
 <ZPpn1bDx8ZriAvQZ@momjian.us>
 <CAApHDvrysy_z0ynH+TkK-YJ9fns0PN2y=RfB6oJaeS-7rhFgAQ@mail.gmail.com>
 <C0F1F23F-3F32-4B64-A31C-9FC92BE41A3F@amazon.com>
 <CAApHDvp2sAr9QLwucFLqz+uaO5iMxsy0uUEdoGTqw5r7iZ4Yzw@mail.gmail.com>
 <ZP8sMj4ZLj07AQe5@momjian.us>
 <CAApHDvrJxauZ6BC3=2JTDE-CUXbMTVLjV2S3gw-=bFRdRAgfsA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAApHDvrJxauZ6BC3=2JTDE-CUXbMTVLjV2S3gw-=bFRdRAgfsA@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/ZRNs7O5VH1IOy24h%40momjian.us>
Precedence: bulk

On Wed, Sep 27, 2023 at 02:05:44AM +1300, David Rowley wrote:
> On Tue, 12 Sept 2023 at 03:03, Bruce Momjian <bruce@momjian.us> wrote:
> >
> > On Mon, Sep 11, 2023 at 10:02:55PM +1200, David Rowley wrote:
> > > It's certainly not a show-stopper. I do believe the patch makes some
> > > improvements.  The reason I'd prefer to see either "and" or "and/or"
> > > in place of "or" is because the text is trying to imply that many of
> > > these operations can run at the same time. I'm struggling to
> > > understand why, given that there could be many sorts and many hashes
> > > going on at once that we'd claim it could only be one *or* the other.
> > > If we have 12 sorts and 4 hashes then that's not "several sort or hash
> > > operations", it's "several sort and hash operations".  Of course, it
> > > could just be sorts or just hashes, so "and/or" works fine for that.
> >
> > Yes, I see your point and went with "and",   updated patch attached.
> 
> Looks good to me.

Patch applied back to Postgres 11.

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EDB                                      https://enterprisedb.com

  Only you can decide what is important to you.