Date: Thu, 28 Sep 2023 13:29:21 -0500
From: Justin Pryzby <pryzby@telsasoft.com>
To: Ali Akbar <the.apaan@gmail.com>
Cc: Michael Paquier <michael.paquier@gmail.com>,
	Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>,
	tushar <tushar.ahuja@enterprisedb.com>,
	Tom Lane <tgl@sss.pgh.pa.us>, pgsql-hackers@postgresql.org,
	Alvaro Herrera <alvherre@alvh.no-ip.org>
Subject: Re: [HACKERS] pg_upgrade failed with error - ERROR: column "a" in
 child table must be marked NOT NULL
Message-ID: <ZRXGAaOvamcRjoL+@telsasoft.com>
References: 
 <CAB7nPqS72REPe5WpaY-17y4E9QGf0TtwfwjMKg_HLY9_MRdthQ@mail.gmail.com>
 <CACQjQLrQn8QkEYnURfJ00zVu-CXtcsMBYFUKHadv1H5kdRz9MQ@mail.gmail.com>
 <217ddce6-1b0f-509d-f8e0-5ddd9cad5d86@lab.ntt.co.jp>
 <CAB7nPqStji75D1M=DEkpOXsJbF151m=ZLrJ4jXTh-Czk3kKZ1Q@mail.gmail.com>
 <CACQjQLrN88BrpUAFv-soW+bCnDEkkWGc+z6cmSEMfGMpd+Aa=g@mail.gmail.com>
 <107ccc78-1a10-ff59-e837-e5c99dc8c152@lab.ntt.co.jp>
 <CACQjQLoMsE+1pyLe98pi0KvPG2jQQ94LWJ+PTiLgVRK4B=i_jg@mail.gmail.com>
 <20171214054902.GC23527@telsasoft.com>
 <CAB7nPqRgRbMWLaidxKW+n144kT+3xRfTSqNS8OUaV77FuQo48w@mail.gmail.com>
 <CACQjQLqoXTzCV4+-s1XOT62tY8ggkZkH4kY03gm2aQYOMXE+SA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: 
 <CACQjQLqoXTzCV4+-s1XOT62tY8ggkZkH4kY03gm2aQYOMXE+SA@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/ZRXGAaOvamcRjoL%2B%40telsasoft.com>
Precedence: bulk

On Thu, Dec 14, 2017 at 07:18:59PM +0700, Ali Akbar wrote:
> By the way, should i add this patch to the current commitfest?

The patch for pg_upgrade --check got forgotten 6 years ago, but it's a
continuing problem (we hit it again which cost an hour during
pg_upgrade) and ought to be (have been) backpatched.

I didn't dig into it, but maybe it'd even be possible to fix the issue
with ALTER..DROP NOT NULL ...

-- 
Justin