Feedback-ID: i0fe9450f:Fastmail
Date: Tue, 17 Oct 2023 08:21:39 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Laurenz Albe <laurenz.albe@cybertec.at>
Cc: David Steele <david@pgmasters.net>,
	Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
	pgsql-hackers@lists.postgresql.org, zxwsbg12138@gmail.com,
	david.zhang@highgo.ca
Subject: Re: Requiring recovery.signal or standby.signal when recovering with
 a backup_label
Message-ID: <ZS3Fg16lGdK1bCYW@paquier.xyz>
References: <ZArVOMifjzE7f8W7@paquier.xyz>
 <20230928.125851.2051261991058034791.horikyota.ntt@gmail.com>
 <4f94351c-24e2-cf32-82d3-1e1bf89a0f5e@pgmasters.net>
 <ZRYTa6Qs9Ecseux1@paquier.xyz>
 <d0ce5b28-a14c-9c08-2505-751c5ff50c0d@pgmasters.net>
 <ZSzQG3IF960zQe3-@paquier.xyz>
 <58a6e18b112b4cd8bd9ab66d3f0ff5e77ada8799.camel@cybertec.at>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="tT7qug/pVlpHEI1V"
Content-Disposition: inline
In-Reply-To: <58a6e18b112b4cd8bd9ab66d3f0ff5e77ada8799.camel@cybertec.at>
Archived-At: <https://www.postgresql.org/message-id/ZS3Fg16lGdK1bCYW%40paquier.xyz>
Precedence: bulk


--tT7qug/pVlpHEI1V
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Oct 16, 2023 at 05:48:43PM +0200, Laurenz Albe wrote:
> I don't have strong feelings either way.  If you have backup_label
> but no signal file, starting PostgreSQL may succeed (if the WAL
> with the checkpoint happens to be in pg_wal) or it may fail with
> an error message.  There is no danger of causing damage unless you
> remove backup_label, right?

A bit more happens currently if you have a backup_label with no signal
files, unfortunately, because this causes some startup states to not
be initialized.  See around here:
https://www.postgresql.org/message-id/Y/Q/17rpYS7YGbIt@paquier.xyz
https://www.postgresql.org/message-id/Y/v0c+3W89NBT/if@paquier.xyz

> I cannot think of a use case where you use such a configuration on
> purpose, and the current error message is more crypric than a plain
> "you must have a signal file to start from a backup", so perhaps
> your patch is a good idea.

I hope so.
--
Michael

--tT7qug/pVlpHEI1V
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmUtxYMACgkQnvQgOdby
QH0GJBAAqkiXWN/8ruzXHZk7qtTVfD+iMloQ39f3/vR+HWRh1rFAf0E/SmmapgqB
r5RgtKjPlKjBnwqXQ7ZqLDn0owGx3cPjjOl+y7JzpUHZ05nze5bE9bEgKB6rblol
ft8VVInG7pv2PF2YrMNifQtncj6HeWEII2jjM3Ojne01RO7Vv9yQ5TB/5myvFzt9
nq3n227NBDsGTCOs6Z9z1aFYgbfdn4Q2nGuv07Bj9LfbOtoFyGtpMPSmlDCxXN5q
05yaQduIuUPBYeLkdUIOyQ5G2Jykm8m+2Kf+FqMJGVGS5+pB3/768FCKhLyCsRMa
qlrIA30fcNXV5hkFUMYgqPtjRolJIddFuX8K4ECbOeVRCGX7+3lQjbeeIohyJdbB
GicZSnIQzcnqcvPXZRgDWJ/tQNtf8f1RXHCaNWOwJxa17k/N+WJ+HhBe2FcFPZ3C
yBieSRbnPaw1GMmfIhe97k0k2qLBuMJwSVT4KKzk7mi+z/yPBRKJzmfnarQxoI9A
1tGseeuvUPKjzfmOSHIKZH/jeMfCQGwOHcLW86EWnKZfixI7IsNhpS/l7PMfPXlR
sMbJZMtj3SZ/ZoYgxzZ16/RUS1FqM3hUN+E9mhW+QFcZpN3NHldZcP29y9LQ2BCP
m/U24I1AvAuico4zPI8wlE7EEB5ZpMfurWUxai40y78nxYXeC6g=
=0dzV
-----END PGP SIGNATURE-----

--tT7qug/pVlpHEI1V--