Feedback-ID: i0fe9450f:Fastmail
Date: Wed, 18 Oct 2023 15:39:16 +0900
From: Michael Paquier <michael@paquier.xyz>
To: "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>
Cc: "'pgsql-hackers@lists.postgresql.org'" <pgsql-hackers@lists.postgresql.org>
Subject: Re: Remove wal_level settings for subscribers in tap tests
Message-ID: <ZS99lGjSOlMcc3gJ@paquier.xyz>
References: <TYAPR01MB5866946BCEB747ABE513ACC6F5D5A@TYAPR01MB5866.jpnprd01.prod.outlook.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="0ROqoApECtfzzoC+"
Content-Disposition: inline
In-Reply-To: <TYAPR01MB5866946BCEB747ABE513ACC6F5D5A@TYAPR01MB5866.jpnprd01.prod.outlook.com>
Archived-At: <https://www.postgresql.org/message-id/ZS99lGjSOlMcc3gJ%40paquier.xyz>
Precedence: bulk


--0ROqoApECtfzzoC+
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Oct 18, 2023 at 02:59:52AM +0000, Hayato Kuroda (Fujitsu) wrote:
> While discussing [1], I found that in tap tests, wal_level was set to log=
ical for
> subscribers too. The setting is not needed for subscriber side, and it ma=
y cause
> misunderstanding for newcomers. Therefore, I wanted to propose the patch =
which
> removes unnecessary "allows_streaming =3D> 'logical'".
> I grepped with the string and checked the necessity of them one by one.
>=20
> How do you think?
>=20
> [1]: https://commitfest.postgresql.org/45/4273/

Hmm, okay.  On top of your argument, this may be a good idea for a
different reason: it makes the tests a bit cheaper as "logical"
generates a bit more WAL.  Still the gain is marginal.=20
--
Michael

--0ROqoApECtfzzoC+
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmUvfZQACgkQnvQgOdby
QH1JvhAAm83ToRB4ftF4jzZfkU8TVwNguA33ihhzJ8zI2VToIlSDdyO6N1mjf25H
Ct8NoVQH8LpahyBR9CNY9nSwmVeCNK+vv5IjgU5ihQ33RBkKCD+r1bKlqrBynynC
PZ/rc3lFXFG6V/dNy2Tf/p9Av7QJ0/E176ywZCOQpcb1gDS63abYyxlrA/D+/19m
XpUtIkk9Wdz3QtjXnAIKnpH3hoX+bfMfYHQI9DXBLrsLD3BN0ZG2k6Go7H14WDHa
rg6f0RPwqELl9mAu3L2mQGJEzktfeIVekAS5iRvtaSbDutCipEConcrLQ8sEeune
x3vO9J8SVp0cld1d2yvDowjmGANYV0t7CHELQX2agtmAIy34RuXMZJFEfPYEQw6v
qdCZW6jhxn2hxi7fGVciOKhi2Yty9fSxZZBTSGisUkXmZubz1EGpapGSFR9+m3cH
k25cWsHwTMIz5GCHx8PlIWlgQ/aC0tClx6Jk6IiUTfs1UAaxnlWK2nVDC7dfiCaN
AtuV5omP/jm1DL/P+Pd080Eo9zc9JOgqiI8NhMJIu9kHfia9YA55f0MzSJyDE5Am
PgVu2zpz+CQF6eGfnkSL3viIXnhqyU9Gujg6P0ZbausHmjDE2H2SNdN1jKhnKbL0
NO3iN8yjmLvb61VibPoCZpJcQ9Us7KeWg5qa8q4gLOXEF6eEM9U=
=9e5h
-----END PGP SIGNATURE-----

--0ROqoApECtfzzoC+--