Feedback-ID: i0fe9450f:Fastmail
Date: Tue, 10 Oct 2023 15:04:14 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Nishant Sharma <nishant.sharma@enterprisedb.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: [Code Cleanup] : Small code cleanup in twophase.sql
Message-ID: <ZSTpXqGUmEcp77mR@paquier.xyz>
References: <CADrsxdb0ueGV9nrC6s8zvXLkGUhnEjx7Ou_p5wo38TvmSvF83A@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="tvP/09DIp9rbLMYc"
Content-Disposition: inline
In-Reply-To: <CADrsxdb0ueGV9nrC6s8zvXLkGUhnEjx7Ou_p5wo38TvmSvF83A@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/ZSTpXqGUmEcp77mR%40paquier.xyz>
Precedence: bulk


--tvP/09DIp9rbLMYc
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Sep 26, 2023 at 06:31:42PM +0530, Nishant Sharma wrote:
> To support it I have below points:-
>=20
> 1) Grepping this table 'test_prepared_savepoint' shows occurrences
> only in twophase.out & twophase.sql files. This means that table is
> local to that sql test file and not used in any other test file.
>=20
> 2) I don't see any comment on why this was not added in the cleanup
> section of twophase.sql, but drop for other two test tables are done.
>=20
> 3) I ran "make check-world" with the patch and I don't see any failures.

Note that sometimes tables are left around in the regression tests for
pg_upgrade, so as we can test dedicated upgrade paths for some object
types.  But, here, I think you're right: this is not a table that
matters for an upgrade and the end of the test file also expects a
cleanup.  So okay for me to drop this table here.
--
Michael

--tvP/09DIp9rbLMYc
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmUk6V4ACgkQnvQgOdby
QH0YGQ/+JUeC1xeQFwWd6zpd15PUmSPw5EIocVXSzX8mNLyqZppBOjXfrLZZmeSg
WXHeP9jGilN6rvs/lsMzNnCav5RLsZleXjLr109st1Z/o1DCjAPPha8QzCnj/+ab
WNgcVPzdUBJqInU8y40HUgQjAdI16MRFh7BolQmBzqcKZTyLbsh5chSlKDBFyo99
FZqi6HW8HFllW+tLBWQyN9rl/mgAL1PKpnPV4tDjBr0LMeOz61v+o2/GbCTFAJZC
HZFf/sYdzwnT09tUwpb4D858wihNtF/Gog1JiAd44mH+q3x1bxjWyEKZXryMK6en
BW2ee45MJF6jPlsECBMJJhZzgSlM1Kud10Rv2FO+lrUaZYaYoMDWqYiopOB172S3
5mpZQaSN2h3a6P0tRkM7oHfg+EDodm8kq5mz+KTBn7q31z9deZtEtQsbGq5TfNrt
zbJtbTUowmTzIybgvTF+MI2xHiyKlN3XDb6U9GXeKuKbsy5PENy8JrK1Wc2+1sTU
WHq9Pg5nWtTYGvu47lc2S090B3bSoeCdfHOoGzGcTteSwOQirslWOkYOSdZ3KJaJ
1eFnCTFdjuMNhJEJPVpyaaxCOlTjwBm2hEwLSMrJQg9qb/fSFUTKTtK1OONtrBiD
xg8vEI0q7/DoN3npKqSWIvGNy7w5o+ouulbjLX3Jp5F3Rg7ZmnY=
=sWOW
-----END PGP SIGNATURE-----

--tvP/09DIp9rbLMYc--