Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qqMFT-009ZuR-Tu for pgsql-hackers@arkaria.postgresql.org; Tue, 10 Oct 2023 23:34:48 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1qqMFR-00B3PP-FT for pgsql-hackers@arkaria.postgresql.org; Tue, 10 Oct 2023 23:34:46 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qqMFR-00B3OE-55 for pgsql-hackers@lists.postgresql.org; Tue, 10 Oct 2023 23:34:46 +0000 Received: from wout4-smtp.messagingengine.com ([64.147.123.20]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qqMFP-0011m0-0r for pgsql-hackers@postgresql.org; Tue, 10 Oct 2023 23:34:44 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 5B5D332009DF; Tue, 10 Oct 2023 19:34:40 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Tue, 10 Oct 2023 19:34:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1696980880; x=1697067280; bh=Ih D+Nr6Hnexfl2aYBV3oQcfhseKpjTWDlHhQkwRnzkc=; b=T81ttg2dxtUMsN/a7S rj1xfy5ewdmdPMA67ym6W1sEZ5Q9Ox+GXfcJoyqOKd/osrVEz9Zuj2KkrJELt1wa 1r37vkJ5i9IovxcM+XsRDJIi9wFBJ/PS4ukzW+ghD9GKGegOlIN930Rt/KAXmNcT R24n61APDpfs+CWaye1+HAEMKzb6XdfRSvddoCfhYZKP47FximLKhwORa4qxdT9N sTJT2BuC1zaltA4vkmD8i8Vbj7CIFu2/gx819382qkuVmMm3popyRCe0eNm6HC4X 08VXlAk2cUP3zYUh3CmUovYU9zqYs1x+X5Dsl9Aew+0DkyZo+Do42lt4J3vnW+xH uUuQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1696980880; x=1697067280; bh=IhD+Nr6Hnexfl 2aYBV3oQcfhseKpjTWDlHhQkwRnzkc=; b=qOB8SxrLL+JhEz6eIU9veQSgHNqEn DvPyPOQIfkcenCIT1g1cFBv6JZMxxvsxBlaCAC/M5EFDageE9xIy42F6f3Nx704N wDO5Hy3fA2mQzwDKWo34O/+dDz3ns3MQgbEgrsvqzn2nDkkIf+8ySF/m+aQXjXLV mQVwVLsPHl5Jqjul9SQp/Jzz2sx0g/2c1Q4VNpr2A1zntKC6dUGKHDjV7wHmuGsy aJIszOPUDBz5WH8GATzKkP6UE6Lig5t4xJ48RZo8SFZ60a5owDtF5rSwcuIhRFHg 0TWM01W1HOB0jOs+chwcaysJ4ZZN1oxl442p9B3GTn0jJHYlog4PQPitA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrheeigddvvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfg hrlhcuvffnffculdejtddmnecujfgurhepfffhvfevuffkfhggtggujgesghdtroertddt jeenucfhrhhomhepofhitghhrggvlhcurfgrqhhuihgvrhcuoehmihgthhgrvghlsehprg hquhhivghrrdighiiiqeenucggtffrrghtthgvrhhnpeegffffudeiveetueekffeiudet ffdufefgudejjeeifffggfeludejiedtvefftdenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpehmihgthhgrvghlsehprghquhhivghrrdighiii X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 10 Oct 2023 19:34:37 -0400 (EDT) Date: Wed, 11 Oct 2023 08:34:33 +0900 From: Michael Paquier To: Evan Jones Cc: Thomas Munro , Tom Lane , pgsql-hackers@postgresql.org Subject: Re: [PATCH] hstore: Fix parsing on Mac OS X: isspace() is locale specific Message-ID: References: <2765603.1687106292@sss.pgh.pa.us> <2823519.1687137059@sss.pgh.pa.us> <3685079.1687318771@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="PzyBy+eFFGre8IJA" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --PzyBy+eFFGre8IJA Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Oct 10, 2023 at 10:51:10AM -0400, Evan Jones wrote: > Here is a quick demonstration of this issue, showing that the quoting > behavior is different between these two. Mac OS X with the "default" loca= le > includes quotes because =C4=85 includes 0x85 in its UTF-8 encoding: Ugh. rowtypes.c has reminded me as well of gistfuncs.c in pageinspect where included columns are printed in a ROW-like fashion. And it also uses isspace() when we check if double quotes are needed or not. So the use of the quotes would equally depend on what macos thinks is a correct space in this case. -- Michael --PzyBy+eFFGre8IJA Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmUl34kACgkQnvQgOdby QH1CEg//YnL0Bl6DFvqMI0XsDk/f/8ZdfvDkChmzp03Jrfq9+qHSCzwCa+odIJWL HcPVKxiR7TYToesTyf86vUsRDn3W+QpFdLePiMgciDjF5prhTxfQlD00Kd0b6hvl m18U+AiWgKH2qBsZuZRFsYljK51paDwIZukJ3YCQ9B/Ei45oC6IeDLckUU9+gYZf OfQ/5RI4i9yvmLRdEhLVjG4b93ThAxkOL9hX44ULqb/XlpvPDrkz488oDuvC6uPW QCqyW+PJwKpBoljo1XTyY3u14Gvlj9FJ1Z6YIA+ADL4dXovZMmszXp0P2qjfXAVn xURFkuzVpSEoMpXJ0s3SR1+hNPn7vg+2qbJrxGZ6faXpY0OhRsvS/e6pS8pgTlfK 4t1GXE+jAQnTUHBrqhKJx0pHvWgLLF6El1NH1+SPd/PjojDDF0y19WydXREZhmtS VJoViL92I3YJt49ByhciiDzV084IttLriQi46MgkAoZmaa31F9uk/dxqqPELHo6a OkWSp65VpNNYTfuQh5dOV6Ot5RCq15TPxGqYZPPcwbMSWYpoi9uFgN67r0BNiVHw 4RRC5hH3Viq7fhdJ2Ps8r1Qk8ie8/76pv2y803NcMsxqHwv2fM9dDN0KkOJALLr6 rlePPtS1lkVgL9RnweUpZmvRMW949lRlR7OG5uokX7PGlZWeiV8= =sLsY -----END PGP SIGNATURE----- --PzyBy+eFFGre8IJA--