Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qrAlu-002v9C-U7 for pgsql-hackers@arkaria.postgresql.org; Fri, 13 Oct 2023 05:31:38 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1qrAls-00EPhC-Kc for pgsql-hackers@arkaria.postgresql.org; Fri, 13 Oct 2023 05:31:37 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qrAls-00EPh0-B3 for pgsql-hackers@lists.postgresql.org; Fri, 13 Oct 2023 05:31:37 +0000 Received: from out4-smtp.messagingengine.com ([66.111.4.28]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qrAll-000F5Y-Uv for pgsql-hackers@postgresql.org; Fri, 13 Oct 2023 05:31:35 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 4AFE15C01D5; Fri, 13 Oct 2023 01:31:29 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Fri, 13 Oct 2023 01:31:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1697175089; x=1697261489; bh=uj sb/il8+S/EpegL/qujVdGkg0Lwxch06RsQuqdv+iw=; b=rkDAQB3hiuwKL5D/3C HMOYTfoMiJ752OGoL+7uq28DrHv7HwMP34HlNxZNE2KjGvjZISjuNvKJbZCvzPB2 O8xP100FlvT1kOQ072JmUkbBv3g8Sf1TpirMBShtUlSXASGScdC7toaD0xdkRfVU iVZTFislfFB+vtumIT5EggPk4I+Q+vokzyZXa2L/BvfjTNxR+YYRLWR/5xPum1sE R5JRxV1wCrpGnrlXvgZsSBMuUVvYoineQ6J40dPiN+C5l0MXZVuxMeB4ys7cPOrl /tVe/0WCYiIfVHM5rh0yQd2svfJQ4t1n4TP94idsc9/3Jz/9+0nqQ4mGVhQYUHzf Rujg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1697175089; x=1697261489; bh=ujsb/il8+S/Ep egL/qujVdGkg0Lwxch06RsQuqdv+iw=; b=VfLPRuLd6npxSAKZCTZCBiP7vvJ+5 H2KeF9/mAJjWrOqiB2xgMS5Xb30NMT6fq61nvO6Fmqcg+B2hPKXo9R8vpbCjZHzz nxsJGDhWWrApeR1TBXkopGRUdY8B3l5w/rELe1mM7l+WPtKK5ssLO23x1eZ4+Jii gmE2WRJXK2FucYI4WwGW+ip06BxKJV/Ynx2A0sYNVR/hX07r5eM5ecewWWdxF7CD J8E80mX7sbKzIYfAmpyZ5gToef1RU0NOJ3U6VOJ6uoxRIODI+1l5Zfx02lI8jjbN mjo+5WpdOGLVnoxlURyskgXxux0Odnq20160TTv9aL1BqyAbqGZ0xCGWw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedriedugdelhecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfg hrlhcuvffnffculdefhedmnecujfgurhepfffhvfevuffkfhggtggujgesghdtreertddt vdenucfhrhhomhepofhitghhrggvlhcurfgrqhhuihgvrhcuoehmihgthhgrvghlsehprg hquhhivghrrdighiiiqeenucggtffrrghtthgvrhhnpeegffejvefgveduvdejtddvtdei jeehudeuledvudeftdfgfeejvdekveekiedvvdenucffohhmrghinhepphhoshhtghhrvg hsqhhlrdhorhhgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhf rhhomhepmhhitghhrggvlhesphgrqhhuihgvrhdrgiihii X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 13 Oct 2023 01:31:26 -0400 (EDT) Date: Fri, 13 Oct 2023 14:31:22 +0900 From: Michael Paquier To: Vik Fearing Cc: Dagfinn Ilmari =?iso-8859-1?Q?Manns=E5ker?= , Jim Jones , pgsql-hackers@postgresql.org Subject: Re: Tab completion for AT TIME ZONE Message-ID: References: <87jzyzsvgv.fsf@wibble.ilmari.org> <87zg7dq96c.fsf@wibble.ilmari.org> <8f76a2e7-1ea3-76df-3176-887d94ee3aea@uni-muenster.de> <87pm86reuq.fsf@wibble.ilmari.org> <87cyxknqbd.fsf@wibble.ilmari.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="j0oR5HyXKcKWVx2S" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --j0oR5HyXKcKWVx2S Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Oct 13, 2023 at 03:07:25AM +0200, Vik Fearing wrote: > The SQL committee already has another operator starting with AT which is AT > LOCAL. The other patch was the reason why I looked at this one. At the end, I've made peace with Dagfinn's argument two messages ago, and applied the patch after adding LOCAL to the keywords, but after also removing the completion for "ZONE" after typing "AT TIME" because AT would be completed by "TIME ZONE". > I am implementing it in https://commitfest.postgresql.org/45/4343/ > where I humbly admit that I did not think of psql tab completion at all. psql completion is always nice to have but not really mandatory IMO, so leaving it out if one does not want to implement it is fine by me to not complicate a patch. Completion could always be tackled on top of any feature related to it that got committed. -- Michael --j0oR5HyXKcKWVx2S Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmUo1ioACgkQnvQgOdby QH1zrw//XCp9Uf4BJ5ozMd+cU8YTHq4ecFKR6kmiHQaEHgYwHtUI2mlSGwiZNyB0 yYvItXgK4hpbv93NAMFquP0JJdRckwqqa/HJ2mgyzHFGP0cnCeIImxlSwhC1tGuj sVp1CuWIIHRiR3wvnxJb3V70LfjFUsuIXKIsxr3ZgEneWS9YnxJw/CkOTtxM29n0 QVSCAL2DJGkaJczbquHemh2CCgxK3c5hq1NLmDIkiBQOVm3xdaE2vO6a4dhTlUch 78jrkj+BtRCFVuGO1eX5QRNa8rsGrZzuq53PieGRnOm0mtNKAE4KeEuJkFjULhjx OnfyO1nfc8e7fDceI1SJlhaWrvrfIgh0p+nOpVe7XQfCpMmyJUBN07ldUqUY2tp1 XKBkFb6PF2McvSqK4fCiRXhdXqd9YENtd2tdb6CwTZ6ywMhvmSWZXAxyaCymLmW2 ZQVk4I/0xd3iUv8XQlAsB68OCAOelrnkmyuLLX3LE84Mev59gv33jCvfYEouwmOD U98V7DNMD68wYuLHjzXdzcYoMg2JEzLFtypTDZRJ1O5NrCdDSRRCS0ri6zco4dAt PWMvezMStlvW6/B3llNmEkEm4Ejv7Q+DORwkfTq6jwR0QS/XKROZruKE3EIBRLID ajtbmB7fwMN5mlvrx8fMpD2ezLHQMk6Kj0hpNQGNanFnvae6P4s= =XWMA -----END PGP SIGNATURE----- --j0oR5HyXKcKWVx2S--