Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qrCf4-0036Dm-F1 for pgsql-hackers@arkaria.postgresql.org; Fri, 13 Oct 2023 07:32:42 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1qrCf2-00FRpG-8Z for pgsql-hackers@arkaria.postgresql.org; Fri, 13 Oct 2023 07:32:40 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qrCf1-00FRod-V6 for pgsql-hackers@lists.postgresql.org; Fri, 13 Oct 2023 07:32:40 +0000 Received: from out4-smtp.messagingengine.com ([66.111.4.28]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qrCey-000JBG-Ot for pgsql-hackers@postgresql.org; Fri, 13 Oct 2023 07:32:40 +0000 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id C00E25C0167; Fri, 13 Oct 2023 03:32:36 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Fri, 13 Oct 2023 03:32:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1697182356; x=1697268756; bh=7D roTDCiLvz69+T/AowLvnnuh4J2QtiHVzVcBtxRxgI=; b=U3mLkDlmAfMZ37nAU/ pECdwbyaY3NG4O/cgKf1o/MO2tWKsnvJEQTfLZN8e+3K/3m0bWNywqTw/Yohqm66 Herg6bLc9vHrELm6QcVHEIKRxfbWs7MKKRDCyTqanzjQAWNudcAZL/4vYbbUoWq5 tlzA3KKljBEBs4BlaJMqd2PKXoytk/kjjqH7IlyNiBoT6Z/VBYV/jytnYjYVv7mp AH5tSmLo95bTJSBwYAPqghzEJ2YS1Clns8tl7JrLxFnBmF71w/EXvsJ3Rdm5B/oN weRniMcF9unDRAgApRLZ3R/v9ECk1++iRjammWowxNKokaBmxiWwIM43j8BYcMbC VEMA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1697182356; x=1697268756; bh=7DroTDCiLvz69 +T/AowLvnnuh4J2QtiHVzVcBtxRxgI=; b=DtMciSaVA334alO/WtIqZAeH+jT8/ xa27JLCsK2dcBs3cCuwC3YuYZ+9gBGMj1gv3z5WldlF8tIj+JNPR1Ezi5xyFWv6W pnfGEkPvnpgpa2VbtLYYkd6H9bNJUhR6xT474HyY+TaayEUz2zFvhTv0xVbChRbc r65/eYoF1clMCK6ADJXsfkEOuYL4ZRQB4Az1PWv3e6F7ioFtinY7xvgYxz2DI8Az tGr7cz2Q7OicUnh+2DAWiE+TkdJeWn4ZQVJblfPgp7NLmUWsuCtANOwT0CyB7VXs Ybvk4QZirPaG8ggGFYS1pko7Rn093bSHPROiCWszPSu3u/IgqGSW41S1g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedriedugdduudelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne gfrhhlucfvnfffucdljedtmdenucfjughrpeffhffvvefukfhfgggtuggjsehgtderredt tddvnecuhfhrohhmpefoihgthhgrvghlucfrrghquhhivghruceomhhitghhrggvlhesph grqhhuihgvrhdrgiihiieqnecuggftrfgrthhtvghrnhepteelieefudffhffhtdetleeg geegfffhkeeuveetiefgudduvedutefggeeivdejnecuvehluhhsthgvrhfuihiivgepud enucfrrghrrghmpehmrghilhhfrhhomhepmhhitghhrggvlhesphgrqhhuihgvrhdrgiih ii X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 13 Oct 2023 03:32:34 -0400 (EDT) Date: Fri, 13 Oct 2023 16:32:30 +0900 From: Michael Paquier To: Vik Fearing Cc: Dagfinn Ilmari =?iso-8859-1?Q?Manns=E5ker?= , Jim Jones , pgsql-hackers@postgresql.org Subject: Re: Tab completion for AT TIME ZONE Message-ID: References: <87jzyzsvgv.fsf@wibble.ilmari.org> <87zg7dq96c.fsf@wibble.ilmari.org> <8f76a2e7-1ea3-76df-3176-887d94ee3aea@uni-muenster.de> <87pm86reuq.fsf@wibble.ilmari.org> <87cyxknqbd.fsf@wibble.ilmari.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="wlg7H3XoFbGUnytA" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --wlg7H3XoFbGUnytA Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Oct 13, 2023 at 08:01:08AM +0200, Vik Fearing wrote: > On 10/13/23 06:31, Michael Paquier wrote: >> but after also removing >> the completion for "ZONE" after typing "AT TIME" because AT would be >> completed by "TIME ZONE". >=20 > Why? The user can tab at any point. IMO this leads to unnecessary bloat in tab-complete.c because we finish with the full completion as long as "TIME" is not fully typed. -- Michael --wlg7H3XoFbGUnytA Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmUo8o4ACgkQnvQgOdby QH2D0g/9HtjQSXfZMKybwxsiHfP1fCvTgFqdnCanJpVRSC90cFmIK4WbuJaTiXl/ dUqIwI3/jzqC9QO62jB7b4R4wbKUUWHiBa5OOZXuQO8K7UrTjbQejon50Hii5Cjl RD0OAyBmu3sMvdVU6KYXECwZ4Y/UyvR9B+X2sBVZJsv+MBW4TR8xfUh9ZZNM5E/B m7GfxHHIWBWPhivUIYjdkLYrFFgCZXf3G6W07oAT0lrvbm0/WW0aSBwBkgngJhh0 sGhwaHBZZfyxy+fj6zTEDQEEojooghyw1bbPPgoRNRgCRAJkEhJYw04oh3CEn/9+ fVxSP913FUlMFxS7W+KCtjem5sQG+5hTdg4uC2DdzioxBr5nC08qKxIL2dOiK9X8 RFZdHrVH+6zccwtHh45m0Id8GYzW0qwTdWVKwqkOUd68BHUHswwXfXIf2ystoB1+ CI8c9iI3FO7W+FyVNAzFjLkpGQAXpSPiwHuR4wt3gI8nhq1B5QhkJ+xfSnZt/8KC DxvJgT0EEJkvthaLVatfKfc7FTB8xAp1E+HVIdgi/guBLwSk0zDJ5M5zIdcEGPRg orYSKxhm5yIeZQHhhVJBRqJma0DUTuBBKa5KpzkzKsJAMOz7pdrX8f/wnF43Svxl CaHVUhVpIpLj2ubfZBPFLXtVXDq1+mi5nu6OaVtmP8rB3BmvLOc= =vSsL -----END PGP SIGNATURE----- --wlg7H3XoFbGUnytA--