Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qsCPO-0078De-Sj for pgsql-hackers@arkaria.postgresql.org; Mon, 16 Oct 2023 01:28:38 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1qsCPL-00EWxr-DG for pgsql-hackers@arkaria.postgresql.org; Mon, 16 Oct 2023 01:28:36 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qsCPL-00EWxj-3b for pgsql-hackers@lists.postgresql.org; Mon, 16 Oct 2023 01:28:35 +0000 Received: from out2-smtp.messagingengine.com ([66.111.4.26]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qsCPJ-000fya-En for pgsql-hackers@lists.postgresql.org; Mon, 16 Oct 2023 01:28:34 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id B3AE25C0281; Sun, 15 Oct 2023 21:28:32 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Sun, 15 Oct 2023 21:28:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; t=1697419712; x=1697506112; bh=T5 q+48bSjoFBjmxOTeNBCu6+O0pHsgiV/izcE1RytCk=; b=TSYahLgIdPtmoQmTZy ZP8x0KEjd/6k+O0o9pq1RktN85A1wPvQfENXQUTNVmpA81HWy3RsrVyhwMwXOGCR ZAFqWL9IjTAJcyjEqQCC5Byfz5V/brsMs13TESRpp+qAY7Q7RGBrxWVzWEdyHOME 8SCvIl/lFWhx8yLUZJyt7A6w9sp+2hDuOqPKUhS+EUGrZquXdbDFy4Kje+okGRmH MFeo6aUBQ6LNdW8AUBPWGhw8AzxCLiH6PZr7R5AWXxMmGtXWvbLfFY1oljF5/uDt LdRaMWDtVrPD8oEw57KWCn3ysnxjxWe+0nSkCh8PyVpZrCUqmDRcgsw8QAMAR2Ex iZDw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1697419712; x=1697506112; bh=T5q+48bSjoFBj mxOTeNBCu6+O0pHsgiV/izcE1RytCk=; b=EUKhymg4ARblyB73Lx5bn9XINmSlQ owikzLKB/qEFOuiIwhxctCwyEz0zPBZNmpnEkWJF5hFb+XbGG98YPScFh+CvEQ1W oVj139MvIpV6v6L+qX3Pyi3GQxXcYEcxvQZCfU7ie3sN8NG/z6v9EJc0engtaVGm GpJJHlK5auBKdvuXiSrN2bSQbBOg6+xnFtJi37u8RzjDtK+4RJPLPNaEiBuMRPZv ODsWl3m9xlrTDast+5J6rkdnrNRMO6DPbohPJA+hnKP6NMA1gZaASrs0WmbLMbdg Plv5hIK9bx2vzKiLaeqThU5GhaOJcx7pifUHBWs3UBlaxXbi3Mw15B/cA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrieelgdegiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfg hrlhcuvffnffculdejtddmnecujfgurhepfffhvfevuffkfhggtggujgesghdtreertddt vdenucfhrhhomhepofhitghhrggvlhcurfgrqhhuihgvrhcuoehmihgthhgrvghlsehprg hquhhivghrrdighiiiqeenucggtffrrghtthgvrhhnpeetleeifedufffhhfdtteelgeeg geffhfekueevteeigfduudevudetgfegiedvjeenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpehmihgthhgrvghlsehprghquhhivghrrdighiii X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 15 Oct 2023 21:28:30 -0400 (EDT) Date: Mon, 16 Oct 2023 10:28:27 +0900 From: Michael Paquier To: Tom Lane Cc: Thomas Munro , Vik Fearing , cary huang , pgsql-hackers@lists.postgresql.org Subject: Re: Add support for AT LOCAL Message-ID: References: <65b620bd-4f05-4381-97c3-5ec9ac39d5b9@postgresfriends.org> <2129576.1697407071@sss.pgh.pa.us> <2149166.1697410024@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="mGNaySKXosgOxWoG" Content-Disposition: inline In-Reply-To: <2149166.1697410024@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --mGNaySKXosgOxWoG Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sun, Oct 15, 2023 at 06:47:04PM -0400, Tom Lane wrote: > Another possibly interesting factoid: it appears that before > 97957fdba, we had zero regression test coverage of timetz_zone --- > and we still have none of timetz_izone, which contains essentially > the same code. So if there is a problem here, whether it's ours or > the compiler's, it's not hard to see why we didn't notice. Right. This one is just a lucky, or say unlucky find. I didn't notice that this path was entirely missing coverage, planting an assertion in the middle of timetz_zone() passes check-world. -- Michael --mGNaySKXosgOxWoG Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmUskbsACgkQnvQgOdby QH1+Hg/9EaynB6yQ5Q3eCzj7V6OuzGhbL/cauoWJikJFVt0NmURsMgw83rfvyhqB 3U5mV/rbg7Lrz+N71BGFDzVTdj47l8TsdSLwjz/I4sDW1B0/OcjJGhAGaDCSZJzd 22EhQNA4hNoD1wsD/utFBy1SlV6qxG9Hk588OXTlQ/WaFyLAMpvOVGsovoyudfmL vKPZ9fy66pwaWcNxQ+yAcb4Q06PPaFFwjqkEaKS09rL/05mU8UDLYrJb0ye4KoJ0 rbfB4oaj6Isz8xNY/vrm2wkbCtxwDXAagHpUNZpR1sYVQcSeXjH9N2FljaulJFuH aHdU8+Q/w9MIfEaJ8+xTx93MwkeW98+VNPxhVhUb6SpzpZxcD42QaUvocMjrlMhp konJxb9Yh2tYVZFO6j6GWWiBoWVbVJzCqI3XxA9DD1jkggyr7vR7Vi5UPGcdfIun GwlhxsMto8eM1/jPKFkNc3nz6RjqDI/6v6L6VZ1si79ji2loE4DLYdAQZsJ2zWs4 zt/ZPhSJRYSQkhwk/7x5eB1RwXA3Pq7+H6FnUQw3dUF4CJ9mcRYlSj8fniB8w/gZ /xUAklLCk1HzrAvOuX+wbpoLzHF7aVH2AXUwlFYKVaPFtwoIxYm1U2MvP0ZaJ832 5vCnHVFc4YjivR5IFZOxN3MZga5KESLtMeaEdW2XvutYaiYHV80= =R+yA -----END PGP SIGNATURE----- --mGNaySKXosgOxWoG--