Feedback-ID: i0fe9450f:Fastmail
Date: Thu, 19 Oct 2023 14:53:12 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Andres Freund <andres@anarazel.de>, Dilip Kumar <dilipbalaut@gmail.com>,
	Heikki Linnakangas <hlinnaka@iki.fi>,
	pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: New WAL record to detect the checkpoint redo location
Message-ID: <ZTDESPN-FhH697Ls@paquier.xyz>
References: <CA+TgmoZ_C1DKuNT0w13_b_6J8JgSupHFSLBCKgQdhJf3FannbA@mail.gmail.com>
 <CA+TgmoZAM24Ub=uxP0aWuWstNYTUJQ64j976FYJeVaMJ+qD0uw@mail.gmail.com>
 <20231005183400.n5myso7vu6crd656@alap3.anarazel.de>
 <CA+Tgmob90XtBJ+WdSHA+y8ZikHPSxQvZwYDefEBLC7Bkwx=3-g@mail.gmail.com>
 <20231009204702.cy3ilp6wgh7a5qms@awork3.anarazel.de>
 <CA+TgmoaaMge7NNBE45kSWz9HkgbSoe9mwicOuOOxLAkb6i2JdQ@mail.gmail.com>
 <ZSjxyCP9JaE4dJUA@paquier.xyz>
 <CA+Tgmoar8fD7tocgauu6xtFF5HEwK-dBqoTKEGeDBA8Prv=fkQ@mail.gmail.com>
 <ZS8oRWqglxVqJqdw@paquier.xyz>
 <CA+TgmoYV0+U94mU2O2agx03AVzmK81w7uv98_6N5ciguc3VF-A@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="AVgj33gvoury7yLG"
Content-Disposition: inline
In-Reply-To: <CA+TgmoYV0+U94mU2O2agx03AVzmK81w7uv98_6N5ciguc3VF-A@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/ZTDESPN-FhH697Ls%40paquier.xyz>
Precedence: bulk


--AVgj33gvoury7yLG
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Oct 18, 2023 at 10:24:50AM -0400, Robert Haas wrote:
> I added a variant of this test case. Here's v10.

+-- Verify that an XLOG_CHECKPOINT_REDO record begins at precisely the redo=
 LSN
+-- of the checkpoint we just performed.
+SELECT redo_lsn FROM pg_control_checkpoint() \gset
+SELECT start_lsn =3D :'redo_lsn'::pg_lsn AS same_lsn, resource_manager,
+    record_type FROM pg_get_wal_record_info(:'redo_lsn');
+ same_lsn | resource_manager |   record_type  =20
+----------+------------------+-----------------
+ t        | XLOG             | CHECKPOINT_REDO
+(1 row)

Seems fine to me.  Thanks for considering the idea.
--
Michael

--AVgj33gvoury7yLG
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmUwxEgACgkQnvQgOdby
QH0P0A/9HNy+pgdvEWAYmoTXKicglbB89CEds0+Rnd9zmSOmimmtsHQnmtgj1Xgt
b9V3XQFzqj5pVFCUVSGhRf3IYS9NPhpjkdOev5JQjZ/DyhdgNcDBz4lKa8xZlsBB
Gz/H3lxq71jWB2xuIeN68i51Ck42ojFXuODqaD8Y8GuGgyptVlP9+50GZi5s9a0G
mvvCJMOPWW0uCAJeOxgd3gHEGzBpHAC9/svbF+vgWNK1iInBLRRagfHF0LLqLvj0
tL3lNs9IXkVe0C0ztPU8l76kc/Kz8PSYv2hwbzhusMy87yi5B0CyTjolAuX1V84o
4y7+fjiofKwsnS0LtQjW41UpNbUmAGxGgibQzGXwhyJSZPfH/iXNERN6Eans5VYi
m6xDklqoqW0eijO1T8NnMGMwUnU6EQcrnhqy/6BYUDTcnR9ZJhaCOCZiDiSILSK2
UoBPRO6ou6drPIeAy1kAVtUWguD8cANC205dPQ9rlDblnGx9wrACN7G878WbMKUX
+v0/f46wuVnIlYC393oX2U71XAUAhnf4nDQ0Kh41ALpm707/xb6g12URZzKUSBGh
driG3LTyK0O/QliNdi3dhjmFKt/KBXXaTtz4mB/S2TvD8BDeDJ5NJ38IawZDria8
SSiTe/TbMDEwRwXJ0cdo92/Y9ygUzXBRKiOTviXfCYN5u0463I8=
=GzTz
-----END PGP SIGNATURE-----

--AVgj33gvoury7yLG--