Feedback-ID: i0fe9450f:Fastmail
Date: Fri, 20 Oct 2023 17:18:56 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Xiang Gao <Xiang.Gao@arm.com>
Cc: "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
Subject: Re: CRC32C Parallel Computation Optimization on ARM
Message-ID: <ZTI38L_FBAGq8w3H@paquier.xyz>
References: <DB9PR08MB6991329A73923BF8ED4B3422F5DBA@DB9PR08MB6991.eurprd08.prod.outlook.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="Hn3AX9MPqmk5etiy"
Content-Disposition: inline
In-Reply-To: <DB9PR08MB6991329A73923BF8ED4B3422F5DBA@DB9PR08MB6991.eurprd08.prod.outlook.com>
Archived-At: <https://www.postgresql.org/message-id/ZTI38L_FBAGq8w3H%40paquier.xyz>
Precedence: bulk


--Hn3AX9MPqmk5etiy
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Oct 20, 2023 at 07:08:58AM +0000, Xiang Gao wrote:
> This patch uses a parallel computing optimization algorithm to
> improve crc32c computing performance on ARM. The algorithm comes
> from Intel whitepaper:
> crc-iscsi-polynomial-crc32-instruction-paper. Input data is divided
> into three equal-sized blocks.Three parallel blocks (crc0, crc1,
> crc2) for 1024 Bytes.One Block: 42(BLK_LENGTH) * 8(step length:
> crc32c_u64) bytes=20
>=20
> Crc32c unitest: https://gist.github.com/gaoxyt/138fd53ca1eead8102eeb92040=
67f7e4
> Crc32c benchmark: https://gist.github.com/gaoxyt/4506c10fc06b3501445e32c4=
257113e9
> It gets ~2x speedup compared to linear Arm crc32c instructions.

Interesting.  Could you attached to this thread the test files you
used and the results obtained please?  If this data gets deleted from
github, then it would not be possible to refer back to what you did at
the related benchmark results.

Note that your patch is forgetting about meson; it just patches
=2E/configure.
--
Michael

--Hn3AX9MPqmk5etiy
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmUyN/AACgkQnvQgOdby
QH0oNw//VQMJ/nKURYJxkOBix3P/JyPXuisLVQioGAOHmZCRhRNyLW+vd753DoAP
/0w2eR+2jCTUuvj3G/SDdSrOwguxG7kzLidGLTWOPYyPF9O0eRm0kkU+bBEIDsSE
n4g0y8Ae1HGsMhGk3ozKV6ixoVV3r3F4+AleL/uGz77Pj0BleZ4hpVqsI/A1pHHH
zabRJYGOD0b4ntvbXv7OaxUkUcIKGvqqSuyoSqzIXSSQKAZ0c21DPprwgn/Grlk7
I2ulg1At2MqV+JHHyJekinkhk45ZLm028gAD42OCu/oRN34ux1Y6G/kXAT1OoDQt
XkP5HPELm+cRte+z9CIJHydaTYgAUAV2OpjhAe/8hnGkt8IRVuvhSn8Sbh9FJrYj
9lQON3lsqFSYDN72IyNsNN+X4m4L3FYcXmPGsagTa8yYfEQRiaX6pa48cBKuqIjo
IIR6HFOWWEE6S1J2z/JHBcfv1laYUUcJPLmKJtUTfGnxVGZinsvA3fIvKAnzqFaP
Cw+lFv5ccEaqyFOUNO2oNEu8ELX8uAMeqRFrXn2dB0w8R/bZaZUhcbFpAFKzu9Ti
/61TaUDiCyby6SapGTvb+p47uXQGY0+o2dLILM07319saT2oGwH4pqBFbTux13He
hNotKJ9qnynp4kFISADsQJpot2Kjig46BIBa/nXOdKXSdT+c9Lk=
=BKJe
-----END PGP SIGNATURE-----

--Hn3AX9MPqmk5etiy--