public inbox for [email protected]
help / color / mirror / Atom feedFrom: Michael Paquier <[email protected]>
To: Bharath Rupireddy <[email protected]>
Cc: Tom Lane <[email protected]>
Cc: Gurjeet Singh <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: Remove extraneous break condition in logical slot advance function
Date: Mon, 23 Oct 2023 10:24:30 +0900
Message-ID: <[email protected]> (raw)
In-Reply-To: <CALj2ACWbyogkFFeLQe5Hs4umqd-igffg0YpoosvniC+G8ukzXQ@mail.gmail.com>
References: <CALj2ACWfGDLQ2cy7ZKwxnJqbDkO6Yvqqrqxne5ZN4HYm=PRTGg@mail.gmail.com>
<CABwTF4X0c97t0PP+A7iTY5JfM76TYa0FUqrGZo1F5ZJomv-48g@mail.gmail.com>
<[email protected]>
<CALj2ACWbyogkFFeLQe5Hs4umqd-igffg0YpoosvniC+G8ukzXQ@mail.gmail.com>
On Sun, Oct 22, 2023 at 11:59:00PM +0530, Bharath Rupireddy wrote:
> AFAICS, there's no correctness argument for breaking before CFI. As
> rightly said, CFIs can happen before the break condition either down
> inside LogicalDecodingProcessRecord or XLogReadRecord (page_read
> callbacks for instance).
>
> Having said that, what may happen if CFI happens and interrupts are
> processed before the break condition is that the decoding occurs again
> which IMV is not a big problem.
>
> An idea to keep all of XLogReadRecord() -
> LogicalDecodingProcessRecord() loops consistent is by having CFI at
> the start of the loops before the XLogReadRecord().
Passing by.. All that just looks like an oversight of 38a957316d7e
that simplified the main while loop, so I've just applied your v2.
--
Michael
Attachments:
[application/pgp-signature] signature.asc (833B, ../[email protected]/2-signature.asc)
download
view thread (2+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: Remove extraneous break condition in logical slot advance function
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox