Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qvJNp-004Ryl-52 for pgsql-hackers@arkaria.postgresql.org; Tue, 24 Oct 2023 15:31:53 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1qvJNm-0090sx-I0 for pgsql-hackers@arkaria.postgresql.org; Tue, 24 Oct 2023 15:31:51 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qvJNm-0090sp-8b for pgsql-hackers@lists.postgresql.org; Tue, 24 Oct 2023 15:31:50 +0000 Received: from feynman.df7cb.de ([195.49.152.168]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qvJNg-002U0X-8z for pgsql-hackers@lists.postgresql.org; Tue, 24 Oct 2023 15:31:50 +0000 Received: from msg.df7cb.de (unknown [IPv6:2a02:908:1482:3660:b7d0:f584:a987:bc23]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-384) server-digest SHA384) (Client did not present a certificate) by feynman.df7cb.de (Postfix) with ESMTPSA id 4SFGHz52W8z3Fvp; Tue, 24 Oct 2023 17:31:43 +0200 (CEST) Date: Tue, 24 Oct 2023 17:31:43 +0200 From: Christoph Berg To: Tom Lane Cc: Tommy Pavlicek , Dagfinn Ilmari =?iso-8859-1?Q?Manns=E5ker?= , pgsql-hackers@lists.postgresql.org, Tomas Vondra , jian.universality@gmail.com Subject: Re: [PATCH] Extend ALTER OPERATOR to support adding commutator, negator, hashes, and merges Message-ID: References: <4082750.1687455374@sss.pgh.pa.us> <15382.1687519306@sss.pgh.pa.us> <1092363.1695932314@sss.pgh.pa.us> <447166.1696969927@sss.pgh.pa.us> <560086.1698160614@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <560086.1698160614@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Re: Tom Lane > > We might be able to simply delete the @ operators, but doesn't this > > new check break the general possibility to have more than one spelling > > for the same operator? > > You can have more than one operator atop the same function. > But why didn't you make the @ operators commutators of each other, > rather than this mess? Historical something. You are right that the commutators could be fixed that way, but the negators are a different question. There is no legacy spelling for these. Anyway, if this doesn't raise any "oh we didn't think of this" concerns, we'll just remove the old operators in pgsphere. Christoph